* [ath9k-devel] [PATCH] ath9k: use pci_dev->subsystem_device
@ 2011-07-22 15:58 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2011-07-22 15:58 UTC (permalink / raw)
To: ath9k-devel
The driver reads PCI subsystem ID from the PCI configuration register while it's
already stored by the PCI subsystem in the 'subsystem_device' field of 'struct
pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
drivers/net/wireless/ath/ath9k/pci.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/net/wireless/ath/ath9k/pci.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/ath/ath9k/pci.c
+++ linux-2.6/drivers/net/wireless/ath/ath9k/pci.c
@@ -129,7 +129,6 @@ static int ath_pci_probe(struct pci_dev
struct ath_softc *sc;
struct ieee80211_hw *hw;
u8 csz;
- u16 subsysid;
u32 val;
int ret = 0;
char hw_name[64];
@@ -223,8 +222,8 @@ static int ath_pci_probe(struct pci_dev
sc->irq = pdev->irq;
- pci_read_config_word(pdev, PCI_SUBSYSTEM_ID, &subsysid);
- ret = ath9k_init_device(id->device, sc, subsysid, &ath_pci_bus_ops);
+ ret = ath9k_init_device(id->device, sc, pdev->subsystem_device,
+ &ath_pci_bus_ops);
if (ret) {
dev_err(&pdev->dev, "Failed to initialize device\n");
goto err_init;
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] ath9k: use pci_dev->subsystem_device
@ 2011-07-22 15:58 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2011-07-22 15:58 UTC (permalink / raw)
To: netdev, linville, linux-wireless, ath9k-devel
Cc: jmalinen, lrodriguez, vasanth, senthilkumar
The driver reads PCI subsystem ID from the PCI configuration register while it's
already stored by the PCI subsystem in the 'subsystem_device' field of 'struct
pci_dev'...
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
---
The patch is against the recent Linus' tree.
drivers/net/wireless/ath/ath9k/pci.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6/drivers/net/wireless/ath/ath9k/pci.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/ath/ath9k/pci.c
+++ linux-2.6/drivers/net/wireless/ath/ath9k/pci.c
@@ -129,7 +129,6 @@ static int ath_pci_probe(struct pci_dev
struct ath_softc *sc;
struct ieee80211_hw *hw;
u8 csz;
- u16 subsysid;
u32 val;
int ret = 0;
char hw_name[64];
@@ -223,8 +222,8 @@ static int ath_pci_probe(struct pci_dev
sc->irq = pdev->irq;
- pci_read_config_word(pdev, PCI_SUBSYSTEM_ID, &subsysid);
- ret = ath9k_init_device(id->device, sc, subsysid, &ath_pci_bus_ops);
+ ret = ath9k_init_device(id->device, sc, pdev->subsystem_device,
+ &ath_pci_bus_ops);
if (ret) {
dev_err(&pdev->dev, "Failed to initialize device\n");
goto err_init;
^ permalink raw reply [flat|nested] 5+ messages in thread* [ath9k-devel] [PATCH] ath9k: use pci_dev->subsystem_device
2011-07-22 15:58 ` Sergei Shtylyov
(?)
@ 2011-07-23 7:53 ` Pavel Roskin
-1 siblings, 0 replies; 5+ messages in thread
From: Pavel Roskin @ 2011-07-23 7:53 UTC (permalink / raw)
To: ath9k-devel
On 07/22/2011 11:58 AM, Sergei Shtylyov wrote:
> The driver reads PCI subsystem ID from the PCI configuration register while it's
> already stored by the PCI subsystem in the 'subsystem_device' field of 'struct
> pci_dev'...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
subsysid doesn't appear to be used anywhere. It can be removed easily.
The patch will be sent separately.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ath9k-devel] [PATCH] ath9k: use pci_dev->subsystem_device
@ 2011-07-23 7:53 ` Pavel Roskin
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Roskin @ 2011-07-23 7:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linville-2XuSBdqkA4R54TAoqtyWWQ,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
ath9k-devel-xDcbHBWguxHbcTqmT+pZeQ,
senthilkumar-DlyHzToyqoxBDgjK7y7TUQ,
vasanth-DlyHzToyqoxBDgjK7y7TUQ, jmalinen-DlyHzToyqoxBDgjK7y7TUQ
On 07/22/2011 11:58 AM, Sergei Shtylyov wrote:
> The driver reads PCI subsystem ID from the PCI configuration register while it's
> already stored by the PCI subsystem in the 'subsystem_device' field of 'struct
> pci_dev'...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
subsysid doesn't appear to be used anywhere. It can be removed easily.
The patch will be sent separately.
--
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ath9k-devel] [PATCH] ath9k: use pci_dev->subsystem_device
@ 2011-07-23 7:53 ` Pavel Roskin
0 siblings, 0 replies; 5+ messages in thread
From: Pavel Roskin @ 2011-07-23 7:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: netdev, linville, linux-wireless, ath9k-devel, senthilkumar,
vasanth, jmalinen
On 07/22/2011 11:58 AM, Sergei Shtylyov wrote:
> The driver reads PCI subsystem ID from the PCI configuration register while it's
> already stored by the PCI subsystem in the 'subsystem_device' field of 'struct
> pci_dev'...
>
> Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com>
subsysid doesn't appear to be used anywhere. It can be removed easily.
The patch will be sent separately.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-23 7:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-22 15:58 [ath9k-devel] [PATCH] ath9k: use pci_dev->subsystem_device Sergei Shtylyov
2011-07-22 15:58 ` Sergei Shtylyov
2011-07-23 7:53 ` [ath9k-devel] " Pavel Roskin
2011-07-23 7:53 ` Pavel Roskin
2011-07-23 7:53 ` Pavel Roskin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.