All of lore.kernel.org
 help / color / mirror / Atom feed
* [ath9k-devel] LEDs
@ 2011-07-20 12:49 Mihai Moldovan
  2011-07-20 14:44 ` Mohammed Shafi
  0 siblings, 1 reply; 5+ messages in thread
From: Mihai Moldovan @ 2011-07-20 12:49 UTC (permalink / raw)
  To: ath9k-devel

Hi all,

quick question, is there any way to enable the LED on an ath9k supported
card?

I tried loading ath9k with blink=1 but it doesn't light anything.

Besides, the driver emits those messages:

[   15.118448] Registered led device: ath9k-phy1::radio
[   15.118471] Registered led device: ath9k-phy1::assoc
[   15.118498] Registered led device: ath9k-phy1::tx

I'm not entirely sure what those led devices are supposed to be, as both
cards have one LED only (probably radio on?)

Best regards,


Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4369 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20110720/01d50c65/attachment.bin 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ath9k-devel] LEDs
  2011-07-20 12:49 [ath9k-devel] LEDs Mihai Moldovan
@ 2011-07-20 14:44 ` Mohammed Shafi
  2011-07-20 17:56   ` Mihai Moldovan
  0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Shafi @ 2011-07-20 14:44 UTC (permalink / raw)
  To: ath9k-devel

On Wed, Jul 20, 2011 at 6:19 PM, Mihai Moldovan <ionic@ionic.de> wrote:
> Hi all,
>
> quick question, is there any way to enable the LED on an ath9k supported
> card?

please tell us which card you are using. does the LED is not even getting ON

>
> I tried loading ath9k with blink=1 but it doesn't light anything.

sudo modprobe ath9k blink=1 will enable LED blinking on tx traffic

>
> Besides, the driver emits those messages:
>
> [ ? 15.118448] Registered led device: ath9k-phy1::radio
> [ ? 15.118471] Registered led device: ath9k-phy1::assoc
> [ ? 15.118498] Registered led device: ath9k-phy1::tx
>
> I'm not entirely sure what those led devices are supposed to be, as both
> cards have one LED only (probably radio on?)

are you using latest wireless-testing or compat wireless , current
ath9k LED makes use led control support via mac80211

>
> Best regards,
>
>
> Mihai
>
>
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>
>



-- 
shafi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ath9k-devel] LEDs
  2011-07-20 14:44 ` Mohammed Shafi
@ 2011-07-20 17:56   ` Mihai Moldovan
  2011-07-21  4:57     ` Mohammed Shafi
  0 siblings, 1 reply; 5+ messages in thread
From: Mihai Moldovan @ 2011-07-20 17:56 UTC (permalink / raw)
  To: ath9k-devel

* On 20.07.2011 04:44 PM, Mohammed Shafi wrote:
> please tell us which card you are using.

AR9380 (AR9300) mounted in an mPCIe to PCIe adapter (not sure those will
actually handle all device's LEDs) and some AR5008 card.


>  does the LED is not even getting ON

Nope, never did.


> sudo modprobe ath9k blink=1 will enable LED blinking on tx traffic

Yeah I know, but I thought I might give it a try. :)


> are you using latest wireless-testing or compat wireless , current
> ath9k LED makes use led control support via mac80211

Nope, in-kernel drivers in 2.6.38.6. I used to use compat-wireless, but
it broke once in a while. May give it a try though.
On the other hand, that's not really an issue and I hestitate to change
a running system, I'm just wondering why the LEDs did never work. :)

Best regards,


Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4369 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20110720/61554e08/attachment.bin 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [ath9k-devel] LEDs
  2011-07-20 17:56   ` Mihai Moldovan
@ 2011-07-21  4:57     ` Mohammed Shafi
  2011-07-23 13:26       ` Mihai Moldovan
  0 siblings, 1 reply; 5+ messages in thread
From: Mohammed Shafi @ 2011-07-21  4:57 UTC (permalink / raw)
  To: ath9k-devel

On Wed, Jul 20, 2011 at 11:26 PM, Mihai Moldovan <ionic@ionic.de> wrote:
> * On 20.07.2011 04:44 PM, Mohammed Shafi wrote:
>> please tell us which card you are using.
>
> AR9380 (AR9300) mounted in an mPCIe to PCIe adapter (not sure those will
> actually handle all device's LEDs) and some AR5008 card.
>
>
>> ?does the LED is not even getting ON
>
> Nope, never did.
>
>
>> sudo modprobe ath9k blink=1 will enable LED blinking on tx traffic
>
> Yeah I know, but I thought I might give it a try. :)
>
>
>> are you using latest wireless-testing or compat wireless , current
>> ath9k LED makes use led control support via mac80211
>
> Nope, in-kernel drivers in 2.6.38.6. I used to use compat-wireless, but
> it broke once in a while. May give it a try though.
> On the other hand, that's not really an issue and I hestitate to change
> a running system, I'm just wondering why the LEDs did never work. :)

*i guess this commit may be missing in 2.6.38.6, please give it a try

commit 353e5019e048562dc8f434c6237d41ef5e758922
Author: Senthil Balasubramanian <senthilkumar@atheros.com>
Date:   Fri Apr 22 11:32:08 2011 +0530

    ath9k: Fix LED gpio for AR93xx chipsets.

    The LED gpio is incorrectly programmed for AR9300 and so the led
    is not working propelry. AR93xx uses gpio 10 for LED and not the
    default.

    Signed-off-by: Senthil Balasubramanian <senthilkumar@atheros.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h
b/drivers/net/wireless/ath/ath9k/ath9k.h
index a6b5388..5ebfc57 100644
--- a/drivers/net/wireless/ath/ath9k/ath9k.h
+++ b/drivers/net/wireless/ath/ath9k/ath9k.h
@@ -453,6 +453,7 @@ void ath9k_btcoex_timer_pause(struct ath_softc *sc);

 #define ATH_LED_PIN_DEF                1
 #define ATH_LED_PIN_9287               8
+#define ATH_LED_PIN_9300               10
 #define ATH_LED_PIN_9485               6

 #ifdef CONFIG_MAC80211_LEDS
diff --git a/drivers/net/wireless/ath/ath9k/gpio.c
b/drivers/net/wireless/ath/ath9k/gpio.c
index cc5fad6..2c59452 100644
--- a/drivers/net/wireless/ath/ath9k/gpio.c
+++ b/drivers/net/wireless/ath/ath9k/gpio.c
@@ -46,6 +46,8 @@ void ath_init_leds(struct ath_softc *sc)
                        sc->sc_ah->led_pin = ATH_LED_PIN_9287;
                else if (AR_SREV_9485(sc->sc_ah))
                        sc->sc_ah->led_pin = ATH_LED_PIN_9485;
+               else if (AR_SREV_9300(sc->sc_ah))
+                       sc->sc_ah->led_pin = ATH_LED_PIN_9300;
                else
                        sc->sc_ah->led_pin = ATH_LED_PIN_DEF;
        }


*please take a try with the stable compat wireless
 http://linuxwireless.org/en/users/Download/stable/#compat-wireless_3.0_stable_releases




>
> Best regards,
>
>
> Mihai
>
>



-- 
shafi

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [ath9k-devel] LEDs
  2011-07-21  4:57     ` Mohammed Shafi
@ 2011-07-23 13:26       ` Mihai Moldovan
  0 siblings, 0 replies; 5+ messages in thread
From: Mihai Moldovan @ 2011-07-23 13:26 UTC (permalink / raw)
  To: ath9k-devel

* On 21.07.2011 06:57 AM, Mohammed Shafi wrote:
> *i guess this commit may be missing in 2.6.38.6, please give it a try

Aaah indeed, it's included in 3.0 too, and I want to give it a try.
Let's see whether it works. :S

Otherwise, I'll try compat-wireless (and I'll even upgrade if 3.0 works.)

Thanks so far. :)

Best regards,


Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4369 bytes
Desc: S/MIME Cryptographic Signature
Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20110723/2e39e1f1/attachment-0001.bin 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-07-23 13:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-20 12:49 [ath9k-devel] LEDs Mihai Moldovan
2011-07-20 14:44 ` Mohammed Shafi
2011-07-20 17:56   ` Mihai Moldovan
2011-07-21  4:57     ` Mohammed Shafi
2011-07-23 13:26       ` Mihai Moldovan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.