All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alexandre Raymond <cerbere@gmail.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds
Date: Mon, 25 Jul 2011 07:16:32 -0500	[thread overview]
Message-ID: <4E2D5EA0.5020104@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJSP0QWn_wU_3q8r=q4Fqey=jSgzi__V_iJ1EyY0OA6Nnu_-8Q@mail.gmail.com>

On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote:
> On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymond<cerbere@gmail.com>  wrote:
>> This patch fixes a minor bugs which prevented QEMU from being built
>> out of tree.
>>
>> Signed-off-by: Alexandre Raymond<cerbere@gmail.com>
>> ---
>>   Makefile |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> I don't normally use --source-path but it still seems broken to me
> after applying your patch?
>
> $ cd /tmp; mkdir out; cd out
> $ ~/qemu/configure --source-path=$HOME/qemu
> $ make
>    GEN   config-all-devices.mak
> cat: i386-softmmu/config-devices.mak: No such file or directory
> cat: x86_64-softmmu/config-devices.mak: No such file or directory
> cat: alpha-softmmu/config-devices.mak: No such file or directory
>
> Stefan
>

Works okay for me with and without the patch if I do a `make distclean` 
in $HOME/qemu beforehand.

Not sure what the trigger is for the breakage Alexandre is trying to 
address.


WARNING: multiple messages have this Message-ID (diff)
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Alexandre Raymond <cerbere@gmail.com>,
	qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds
Date: Mon, 25 Jul 2011 07:16:32 -0500	[thread overview]
Message-ID: <4E2D5EA0.5020104@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAJSP0QWn_wU_3q8r=q4Fqey=jSgzi__V_iJ1EyY0OA6Nnu_-8Q@mail.gmail.com>

On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote:
> On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymond<cerbere@gmail.com>  wrote:
>> This patch fixes a minor bugs which prevented QEMU from being built
>> out of tree.
>>
>> Signed-off-by: Alexandre Raymond<cerbere@gmail.com>
>> ---
>>   Makefile |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> I don't normally use --source-path but it still seems broken to me
> after applying your patch?
>
> $ cd /tmp; mkdir out; cd out
> $ ~/qemu/configure --source-path=$HOME/qemu
> $ make
>    GEN   config-all-devices.mak
> cat: i386-softmmu/config-devices.mak: No such file or directory
> cat: x86_64-softmmu/config-devices.mak: No such file or directory
> cat: alpha-softmmu/config-devices.mak: No such file or directory
>
> Stefan
>

Works okay for me with and without the patch if I do a `make distclean` 
in $HOME/qemu beforehand.

Not sure what the trigger is for the breakage Alexandre is trying to 
address.

  reply	other threads:[~2011-07-25 12:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-21  4:41 [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds Alexandre Raymond
2011-07-25 10:15 ` Stefan Hajnoczi
2011-07-25 10:15   ` [Qemu-devel] " Stefan Hajnoczi
2011-07-25 12:16   ` Michael Roth [this message]
2011-07-25 12:16     ` Michael Roth
2011-07-25 12:43     ` Stefan Hajnoczi
2011-07-25 12:43       ` [Qemu-devel] " Stefan Hajnoczi
2011-07-25 13:57       ` Michael Roth
2011-07-25 13:57         ` [Qemu-devel] " Michael Roth
2011-07-25 14:43         ` Stefan Hajnoczi
2011-07-25 14:43           ` [Qemu-devel] " Stefan Hajnoczi
2011-07-25 15:06           ` Michael Roth
2011-07-25 15:06             ` [Qemu-devel] " Michael Roth
2011-07-25 15:51             ` Alexandre Raymond
2011-07-25 15:51               ` [Qemu-devel] " Alexandre Raymond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2D5EA0.5020104@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=cerbere@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.