From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 17:21:26 +0200 [thread overview]
Message-ID: <4E2D89F6.7060908@redhat.com> (raw)
In-Reply-To: <CAAu8pHuoW0zxRS6XMAfqbsKpFLUgtuOQU1ftP19DhVU++Uedyw@mail.gmail.com>
On 07/25/2011 04:56 PM, Blue Swirl wrote:
> > qemu_malloc uses g_malloc => you keep tracepoints, you just do not trace
> > memory allocated by glib
>
> Unless the plan is to replace all qemu_malloc() calls with calls to g_malloc().
We can worry when the day comes... there is already another task
blocking that replacement (balancing qemu_malloc with qemu_free).
> > The former is much less code, however it requires qemu_malloc to be always
> > balanced with qemu_free (patches ready and on my github tree, won't be sent
> > before KVM Forum though...).
>
> Freeing qemu_malloc() memory with plain free() is a bug.
We have many bugs, then. :)
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()
Date: Mon, 25 Jul 2011 17:21:26 +0200 [thread overview]
Message-ID: <4E2D89F6.7060908@redhat.com> (raw)
In-Reply-To: <CAAu8pHuoW0zxRS6XMAfqbsKpFLUgtuOQU1ftP19DhVU++Uedyw@mail.gmail.com>
On 07/25/2011 04:56 PM, Blue Swirl wrote:
> > qemu_malloc uses g_malloc => you keep tracepoints, you just do not trace
> > memory allocated by glib
>
> Unless the plan is to replace all qemu_malloc() calls with calls to g_malloc().
We can worry when the day comes... there is already another task
blocking that replacement (balancing qemu_malloc with qemu_free).
> > The former is much less code, however it requires qemu_malloc to be always
> > balanced with qemu_free (patches ready and on my github tree, won't be sent
> > before KVM Forum though...).
>
> Freeing qemu_malloc() memory with plain free() is a bug.
We have many bugs, then. :)
Paolo
next prev parent reply other threads:[~2011-07-25 15:21 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 8:51 [PATCH] Introduce QEMU_NEW() Avi Kivity
2011-07-25 8:51 ` [Qemu-devel] " Avi Kivity
2011-07-25 9:32 ` Alexander Graf
2011-07-25 9:32 ` [Qemu-devel] " Alexander Graf
2011-07-25 9:37 ` Sasha Levin
2011-07-25 9:37 ` [Qemu-devel] " Sasha Levin
2011-07-25 9:43 ` Alexander Graf
2011-07-25 9:43 ` [Qemu-devel] " Alexander Graf
2011-07-25 9:49 ` Avi Kivity
2011-07-25 9:49 ` [Qemu-devel] " Avi Kivity
2011-07-25 9:48 ` Peter Maydell
2011-07-25 9:48 ` Peter Maydell
2011-07-25 9:52 ` Avi Kivity
2011-07-25 9:52 ` Avi Kivity
2011-07-25 9:56 ` Alexander Graf
2011-07-25 9:56 ` [Qemu-devel] " Alexander Graf
2011-07-25 10:02 ` Avi Kivity
2011-07-25 10:02 ` [Qemu-devel] " Avi Kivity
2011-07-25 10:04 ` Alexander Graf
2011-07-25 10:09 ` Avi Kivity
2011-07-25 10:19 ` Alexander Graf
2011-07-25 10:19 ` [Qemu-devel] " Alexander Graf
2011-07-25 10:46 ` malc
2011-07-25 10:46 ` malc
2011-07-25 10:59 ` Markus Armbruster
2011-07-25 10:59 ` [Qemu-devel] " Markus Armbruster
2011-07-25 11:11 ` Alexander Graf
2011-07-25 11:11 ` Alexander Graf
2011-07-25 12:19 ` Anthony Liguori
2011-07-25 12:19 ` Anthony Liguori
2011-07-25 14:16 ` Blue Swirl
2011-07-25 14:16 ` Blue Swirl
2011-07-25 14:20 ` Avi Kivity
2011-07-25 14:20 ` [Qemu-devel] " Avi Kivity
2011-07-25 12:30 ` Anthony Liguori
2011-07-25 11:35 ` Avi Kivity
2011-07-25 11:35 ` [Qemu-devel] " Avi Kivity
2011-07-25 10:06 ` Stefan Hajnoczi
2011-07-25 10:06 ` [Qemu-devel] " Stefan Hajnoczi
2011-07-25 10:12 ` Avi Kivity
2011-07-25 10:25 ` Kevin Wolf
2011-07-25 10:25 ` Kevin Wolf
2011-07-25 10:28 ` Stefan Hajnoczi
2011-07-25 10:28 ` Stefan Hajnoczi
2011-07-25 11:02 ` Markus Armbruster
2011-07-25 11:02 ` Markus Armbruster
2011-07-25 11:45 ` Avi Kivity
2011-07-25 15:10 ` Jes Sorensen
2011-07-25 15:10 ` [Qemu-devel] " Jes Sorensen
2011-07-25 15:15 ` Anthony Liguori
2011-07-25 15:17 ` Jes Sorensen
2011-07-25 15:20 ` Avi Kivity
2011-07-25 15:20 ` [Qemu-devel] " Avi Kivity
2011-07-25 15:21 ` Jes Sorensen
2011-07-25 15:21 ` Jes Sorensen
2011-07-25 15:24 ` Avi Kivity
2011-07-25 15:24 ` [Qemu-devel] " Avi Kivity
2011-07-25 15:28 ` Jes Sorensen
2011-07-25 15:28 ` Jes Sorensen
2011-07-25 15:35 ` Avi Kivity
2011-07-25 15:35 ` [Qemu-devel] " Avi Kivity
2011-07-25 12:11 ` Anthony Liguori
2011-07-25 12:11 ` [Qemu-devel] " Anthony Liguori
2011-07-25 12:18 ` Avi Kivity
2011-07-25 12:21 ` Anthony Liguori
2011-07-25 12:41 ` Avi Kivity
2011-07-25 12:41 ` [Qemu-devel] " Avi Kivity
2011-07-25 14:23 ` Blue Swirl
2011-07-25 14:23 ` Blue Swirl
2011-07-25 14:25 ` Anthony Liguori
2011-07-25 14:30 ` Max Filippov
2011-07-25 14:30 ` [Qemu-devel] " Max Filippov
2011-07-25 14:43 ` Anthony Liguori
2011-07-25 14:47 ` malc
2011-07-25 14:47 ` [Qemu-devel] " malc
2011-07-25 14:50 ` Avi Kivity
2011-07-25 14:50 ` Avi Kivity
2011-07-25 14:58 ` malc
2011-07-25 14:58 ` malc
2011-07-25 14:59 ` Avi Kivity
2011-07-25 14:59 ` Avi Kivity
2011-07-25 14:51 ` Paolo Bonzini
2011-07-25 14:51 ` Paolo Bonzini
2011-07-25 14:56 ` Blue Swirl
2011-07-25 14:56 ` Blue Swirl
2011-07-25 15:21 ` Paolo Bonzini [this message]
2011-07-25 15:21 ` Paolo Bonzini
2011-08-01 10:49 ` Richard W.M. Jones
2011-08-01 10:49 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D89F6.7060908@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.