Re: [PATCH v2 04/23] memory: merge adjacent segments of a single memory region

[Avi Kivity <avi@redhat.com>]

On 07/26/2011 02:36 PM, Paolo Bonzini wrote:
> On 07/26/2011 01:26 PM, Avi Kivity wrote:
>> +    while (i < view->nr) {
>> +        j = i + 1;
>> +        while (j < view->nr
>> + && can_merge(&view->ranges[j-1], &view->ranges[j])) {
>> +            view->ranges[i].addr.size += view->ranges[j].addr.size;
>> +            ++j;
>> +        }
>> +        ++i;
>
> if (j != i) {
>
>> +        memmove(&view->ranges[i], &view->ranges[j],
>> +                (view->nr - j) * sizeof(view->ranges[j]));
>> +        view->nr -= j - i;
>> +    }
>
> }

Seems to work both ways?

-- 
error compiling committee.c: too many arguments to function