* Re: [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 11:16 [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c ruslanpisarev
@ 2011-07-26 16:17 ` Jeremy Fitzhardinge
2011-07-26 16:31 ` [Xen-devel] " Ian Campbell
2011-07-26 16:31 ` Ian Campbell
2011-07-26 16:17 ` Jeremy Fitzhardinge
` (2 subsequent siblings)
3 siblings, 2 replies; 7+ messages in thread
From: Jeremy Fitzhardinge @ 2011-07-26 16:17 UTC (permalink / raw)
To: ruslanpisarev
Cc: Ruslan Pisarev, jeremy.fitzhardinge, xen-devel, konrad.wilk,
virtualization
On 07/26/2011 04:16 AM, ruslanpisarev@gmail.com wrote:
> From: Ruslan Pisarev <ruslan@rpisarev.org.ua>
>
> This is a patch to the xenbus_client.c file that fixed up whitespaces, tabs errors found by the checkpatch.pl tools.
>
> Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
> ---
> drivers/xen/xenbus/xenbus_client.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
> index cdacf92..ff4f03c 100644
> --- a/drivers/xen/xenbus/xenbus_client.c
> +++ b/drivers/xen/xenbus/xenbus_client.c
> @@ -43,15 +43,15 @@
> const char *xenbus_strstate(enum xenbus_state state)
> {
> static const char *const name[] = {
> - [ XenbusStateUnknown ] = "Unknown",
> - [ XenbusStateInitialising ] = "Initialising",
> - [ XenbusStateInitWait ] = "InitWait",
> - [ XenbusStateInitialised ] = "Initialised",
> - [ XenbusStateConnected ] = "Connected",
> - [ XenbusStateClosing ] = "Closing",
> - [ XenbusStateClosed ] = "Closed",
> - [XenbusStateReconfiguring] = "Reconfiguring",
> - [XenbusStateReconfigured] = "Reconfigured",
> + [XenbusStateUnknown] = "Unknown",
> + [XenbusStateInitialising] = "Initialising",
> + [XenbusStateInitWait] = "InitWait",
> + [XenbusStateInitialised] = "Initialised",
> + [XenbusStateConnected] = "Connected",
> + [XenbusStateClosing] = "Closing",
> + [XenbusStateClosed] = "Closed",
> + [XenbusStateReconfiguring] = "Reconfiguring",
> + [XenbusStateReconfigured] = "Reconfigured",
> };
Eh, I think this looks worse now.
J
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Xen-devel] Re: [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 16:17 ` Jeremy Fitzhardinge
@ 2011-07-26 16:31 ` Ian Campbell
2011-07-26 16:31 ` Ian Campbell
1 sibling, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2011-07-26 16:31 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: xen-devel@lists.xensource.com, ruslanpisarev@gmail.com,
konrad.wilk@oracle.com, Ruslan Pisarev,
virtualization@lists.linux-foundation.org, Jeremy Fitzhardinge
On Tue, 2011-07-26 at 12:17 -0400, Jeremy Fitzhardinge wrote:
> On 07/26/2011 04:16 AM, ruslanpisarev@gmail.com wrote:
> > @@ -43,15 +43,15 @@
> > const char *xenbus_strstate(enum xenbus_state state)
> > {
> > static const char *const name[] = {
> > - [ XenbusStateUnknown ] = "Unknown",
> > - [ XenbusStateInitialising ] = "Initialising",
> > - [ XenbusStateInitWait ] = "InitWait",
> > - [ XenbusStateInitialised ] = "Initialised",
> > - [ XenbusStateConnected ] = "Connected",
> > - [ XenbusStateClosing ] = "Closing",
> > - [ XenbusStateClosed ] = "Closed",
> > - [XenbusStateReconfiguring] = "Reconfiguring",
> > - [XenbusStateReconfigured] = "Reconfigured",
> > + [XenbusStateUnknown] = "Unknown",
> > + [XenbusStateInitialising] = "Initialising",
> > + [XenbusStateInitWait] = "InitWait",
> > + [XenbusStateInitialised] = "Initialised",
> > + [XenbusStateConnected] = "Connected",
> > + [XenbusStateClosing] = "Closing",
> > + [XenbusStateClosed] = "Closed",
> > + [XenbusStateReconfiguring] = "Reconfiguring",
> > + [XenbusStateReconfigured] = "Reconfigured",
> > };
>
> Eh, I think this looks worse now.
Me too.
If we're going to change this to anything I'd suggest
#define N(x) [XenbusState#x] = ##x
...
N(Connected),
N(Closing),
...
#undef N
(modulo my never quite remembering the cpp stringification rules first
time)
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Re: [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 16:17 ` Jeremy Fitzhardinge
2011-07-26 16:31 ` [Xen-devel] " Ian Campbell
@ 2011-07-26 16:31 ` Ian Campbell
1 sibling, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2011-07-26 16:31 UTC (permalink / raw)
To: Jeremy Fitzhardinge
Cc: xen-devel@lists.xensource.com, ruslanpisarev@gmail.com,
konrad.wilk@oracle.com, Ruslan Pisarev,
virtualization@lists.linux-foundation.org, Jeremy Fitzhardinge
On Tue, 2011-07-26 at 12:17 -0400, Jeremy Fitzhardinge wrote:
> On 07/26/2011 04:16 AM, ruslanpisarev@gmail.com wrote:
> > @@ -43,15 +43,15 @@
> > const char *xenbus_strstate(enum xenbus_state state)
> > {
> > static const char *const name[] = {
> > - [ XenbusStateUnknown ] = "Unknown",
> > - [ XenbusStateInitialising ] = "Initialising",
> > - [ XenbusStateInitWait ] = "InitWait",
> > - [ XenbusStateInitialised ] = "Initialised",
> > - [ XenbusStateConnected ] = "Connected",
> > - [ XenbusStateClosing ] = "Closing",
> > - [ XenbusStateClosed ] = "Closed",
> > - [XenbusStateReconfiguring] = "Reconfiguring",
> > - [XenbusStateReconfigured] = "Reconfigured",
> > + [XenbusStateUnknown] = "Unknown",
> > + [XenbusStateInitialising] = "Initialising",
> > + [XenbusStateInitWait] = "InitWait",
> > + [XenbusStateInitialised] = "Initialised",
> > + [XenbusStateConnected] = "Connected",
> > + [XenbusStateClosing] = "Closing",
> > + [XenbusStateClosed] = "Closed",
> > + [XenbusStateReconfiguring] = "Reconfiguring",
> > + [XenbusStateReconfigured] = "Reconfigured",
> > };
>
> Eh, I think this looks worse now.
Me too.
If we're going to change this to anything I'd suggest
#define N(x) [XenbusState#x] = ##x
...
N(Connected),
N(Closing),
...
#undef N
(modulo my never quite remembering the cpp stringification rules first
time)
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 11:16 [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c ruslanpisarev
2011-07-26 16:17 ` Jeremy Fitzhardinge
@ 2011-07-26 16:17 ` Jeremy Fitzhardinge
2011-07-27 15:36 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-07-27 15:36 ` Konrad Rzeszutek Wilk
3 siblings, 0 replies; 7+ messages in thread
From: Jeremy Fitzhardinge @ 2011-07-26 16:17 UTC (permalink / raw)
To: ruslanpisarev
Cc: Ruslan Pisarev, jeremy.fitzhardinge, xen-devel, konrad.wilk,
virtualization
On 07/26/2011 04:16 AM, ruslanpisarev@gmail.com wrote:
> From: Ruslan Pisarev <ruslan@rpisarev.org.ua>
>
> This is a patch to the xenbus_client.c file that fixed up whitespaces, tabs errors found by the checkpatch.pl tools.
>
> Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
> ---
> drivers/xen/xenbus/xenbus_client.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
> index cdacf92..ff4f03c 100644
> --- a/drivers/xen/xenbus/xenbus_client.c
> +++ b/drivers/xen/xenbus/xenbus_client.c
> @@ -43,15 +43,15 @@
> const char *xenbus_strstate(enum xenbus_state state)
> {
> static const char *const name[] = {
> - [ XenbusStateUnknown ] = "Unknown",
> - [ XenbusStateInitialising ] = "Initialising",
> - [ XenbusStateInitWait ] = "InitWait",
> - [ XenbusStateInitialised ] = "Initialised",
> - [ XenbusStateConnected ] = "Connected",
> - [ XenbusStateClosing ] = "Closing",
> - [ XenbusStateClosed ] = "Closed",
> - [XenbusStateReconfiguring] = "Reconfiguring",
> - [XenbusStateReconfigured] = "Reconfigured",
> + [XenbusStateUnknown] = "Unknown",
> + [XenbusStateInitialising] = "Initialising",
> + [XenbusStateInitWait] = "InitWait",
> + [XenbusStateInitialised] = "Initialised",
> + [XenbusStateConnected] = "Connected",
> + [XenbusStateClosing] = "Closing",
> + [XenbusStateClosed] = "Closed",
> + [XenbusStateReconfiguring] = "Reconfiguring",
> + [XenbusStateReconfigured] = "Reconfigured",
> };
Eh, I think this looks worse now.
J
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Xen-devel] [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 11:16 [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c ruslanpisarev
2011-07-26 16:17 ` Jeremy Fitzhardinge
2011-07-26 16:17 ` Jeremy Fitzhardinge
@ 2011-07-27 15:36 ` Konrad Rzeszutek Wilk
2011-07-27 15:36 ` Konrad Rzeszutek Wilk
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-07-27 15:36 UTC (permalink / raw)
To: ruslanpisarev
Cc: Ruslan Pisarev, jeremy.fitzhardinge, xen-devel, virtualization
On Tue, Jul 26, 2011 at 02:16:49PM +0300, ruslanpisarev@gmail.com wrote:
> From: Ruslan Pisarev <ruslan@rpisarev.org.ua>
>
> This is a patch to the xenbus_client.c file that fixed up whitespaces, tabs errors found by the checkpatch.pl tools.
Not sure why you resent this patchset, but I am not taking this patch in.
Please address the concerns that were raised the first time you sent this patch.
I've the other six queued up for 3.2.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c
2011-07-26 11:16 [PATCH 5/7] Xen: fix whitespaces, tabs coding style issue in drivers/xen/xenbus/xenbus_client.c ruslanpisarev
` (2 preceding siblings ...)
2011-07-27 15:36 ` [Xen-devel] " Konrad Rzeszutek Wilk
@ 2011-07-27 15:36 ` Konrad Rzeszutek Wilk
3 siblings, 0 replies; 7+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-07-27 15:36 UTC (permalink / raw)
To: ruslanpisarev
Cc: Ruslan Pisarev, jeremy.fitzhardinge, xen-devel, virtualization
On Tue, Jul 26, 2011 at 02:16:49PM +0300, ruslanpisarev@gmail.com wrote:
> From: Ruslan Pisarev <ruslan@rpisarev.org.ua>
>
> This is a patch to the xenbus_client.c file that fixed up whitespaces, tabs errors found by the checkpatch.pl tools.
Not sure why you resent this patchset, but I am not taking this patch in.
Please address the concerns that were raised the first time you sent this patch.
I've the other six queued up for 3.2.
^ permalink raw reply [flat|nested] 7+ messages in thread