From: Larry Finger <Larry.Finger@lwfinger.net>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH] b43legacy: remove 64-bit DMA support
Date: Tue, 26 Jul 2011 14:12:46 -0500 [thread overview]
Message-ID: <4E2F11AE.1030608@lwfinger.net> (raw)
In-Reply-To: <4E2F0F44.3060105@gnu.org>
On 07/26/2011 02:02 PM, Pavel Roskin wrote:
> On 07/26/2011 01:47 PM, Larry Finger wrote:
>> On 07/25/2011 04:40 PM, Pavel Roskin wrote:
>>> Devices supported by b43legacy don't support 64-bit DMA.
>>>
>>> Signed-off-by: Pavel Roskin<proski@gnu.org>
>>> ---
>>> The patch was tested on Broadcom 4306.
>>>
>>> drivers/net/wireless/b43legacy/dma.c | 374
>>> ++++++----------------------------
>>> drivers/net/wireless/b43legacy/dma.h | 107 ----------
>>> 2 files changed, 71 insertions(+), 410 deletions(-)
>>
>> Tested on BCM4303.
>
> Appreciated!
>
>>> + value&= B43legacy_DMA32_RXSTATE;
>>
>> I am surprised that checkpatch doesn't see the spacing around the &= as
>> an error.
>
> It's a Mozilla Thunderbird bug. What you are seeing is not what I sent.
>
> checkpatch would catch that in the real code.
Ahh. The BCM4303 is in a different machine than I the one used to do Email.
Saving the message from Thunderbird to an NFS-mounted device and copying to the
test machine came out right. When I saw it in the mail, I ran checkpatch, saw
that it was clean, and failed to check the actual patch that I had applied.
Interesting.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] b43legacy: remove 64-bit DMA support
Date: Tue, 26 Jul 2011 14:12:46 -0500 [thread overview]
Message-ID: <4E2F11AE.1030608@lwfinger.net> (raw)
In-Reply-To: <4E2F0F44.3060105@gnu.org>
On 07/26/2011 02:02 PM, Pavel Roskin wrote:
> On 07/26/2011 01:47 PM, Larry Finger wrote:
>> On 07/25/2011 04:40 PM, Pavel Roskin wrote:
>>> Devices supported by b43legacy don't support 64-bit DMA.
>>>
>>> Signed-off-by: Pavel Roskin<proski@gnu.org>
>>> ---
>>> The patch was tested on Broadcom 4306.
>>>
>>> drivers/net/wireless/b43legacy/dma.c | 374
>>> ++++++----------------------------
>>> drivers/net/wireless/b43legacy/dma.h | 107 ----------
>>> 2 files changed, 71 insertions(+), 410 deletions(-)
>>
>> Tested on BCM4303.
>
> Appreciated!
>
>>> + value&= B43legacy_DMA32_RXSTATE;
>>
>> I am surprised that checkpatch doesn't see the spacing around the &= as
>> an error.
>
> It's a Mozilla Thunderbird bug. What you are seeing is not what I sent.
>
> checkpatch would catch that in the real code.
Ahh. The BCM4303 is in a different machine than I the one used to do Email.
Saving the message from Thunderbird to an NFS-mounted device and copying to the
test machine came out right. When I saw it in the mail, I ran checkpatch, saw
that it was clean, and failed to check the actual patch that I had applied.
Interesting.
Larry
next prev parent reply other threads:[~2011-07-26 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 21:40 [PATCH] b43legacy: remove 64-bit DMA support Pavel Roskin
2011-07-26 17:47 ` Larry Finger
2011-07-26 17:47 ` Larry Finger
2011-07-26 19:02 ` Pavel Roskin
2011-07-26 19:12 ` Larry Finger [this message]
2011-07-26 19:12 ` Larry Finger
2011-07-26 20:05 ` Rafał Miłecki
2011-07-26 20:05 ` Rafał Miłecki
2011-07-26 20:56 ` Larry Finger
2011-07-26 20:56 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2F11AE.1030608@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.