From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Archit Taneja <archit@ti.com>
Cc: linux-omap@vger.kernel.org, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields
Date: Wed, 27 Jul 2011 11:51:24 +0530 [thread overview]
Message-ID: <4E2FAE64.7020806@ti.com> (raw)
In-Reply-To: <1311747632-26899-1-git-send-email-archit@ti.com>
+ Benoit
On 7/27/2011 11:50 AM, Archit Taneja wrote:
> Fix the shift and mask macros for DSIx_PPID fields in CONTROL_DSIPHY. The Latest
> TRM mentions the correct fields in the register.
You can mention the TRM version instead of 'latest'
Latest is very much relative :)
>
> Signed-off-by: Archit Taneja<archit@ti.com>
Change looks good to me.
Autogen scripts needs to be checked as well.
> ---
> .../include/mach/ctrl_module_pad_core_44xx.h | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> index c88420d..8321add 100644
> --- a/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> +++ b/arch/arm/mach-omap2/include/mach/ctrl_module_pad_core_44xx.h
> @@ -941,10 +941,10 @@
> #define OMAP4_DSI2_LANEENABLE_MASK (0x7<< 29)
> #define OMAP4_DSI1_LANEENABLE_SHIFT 24
> #define OMAP4_DSI1_LANEENABLE_MASK (0x1f<< 24)
> -#define OMAP4_DSI1_PIPD_SHIFT 19
> -#define OMAP4_DSI1_PIPD_MASK (0x1f<< 19)
> -#define OMAP4_DSI2_PIPD_SHIFT 14
> -#define OMAP4_DSI2_PIPD_MASK (0x1f<< 14)
> +#define OMAP4_DSI1_PIPD_SHIFT 14
> +#define OMAP4_DSI1_PIPD_MASK (0x1f<< 14)
> +#define OMAP4_DSI2_PIPD_SHIFT 19
> +#define OMAP4_DSI2_PIPD_MASK (0x1f<< 19)
>
> /* CONTROL_MCBSPLP */
> #define OMAP4_ALBCTRLRX_FSX_SHIFT 31
next prev parent reply other threads:[~2011-07-27 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 6:20 [PATCH] OMAP: ctrl: Fix CONTROL_DSIPHY register fields Archit Taneja
2011-07-27 6:21 ` Santosh Shilimkar [this message]
2011-07-27 9:06 ` Cousson, Benoit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2FAE64.7020806@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=archit@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.