Q: How to add more modules when -H is specified?

Q: How to add more modules when -H is specified?

[WANG Cong]

Hi, dracut people,

I am not sure about the expected behaviour when I specify both
-H and --add foo (where module foo is not automatially added
by -H). It looks like with -H specified, --add foo will not
take any effect?

At least `-H --add nfs` doesn't work if my rootfs is not nfs,
I see the following check in modules.d/95nfs/module-setup.sh,

    [ $hostonly ] && ! egrep -q '/ nfs[34 ]' /proc/mounts && return 1

So, is this expected? I mean as long as I specify -H, there is
no way to add more modules? Or just the nfs check code is wrong?

Also, I am looking for a way to add all needed modules for
devices mounted in current system, as -H only adds modules
needed by rootfs.

Thanks!

Re: Q: How to add more modules when -H is specified?

[Harald Hoyer]

On 29.07.2011 10:57, WANG Cong wrote:
> 
> Hi, dracut people,
> 
> I am not sure about the expected behaviour when I specify both
> -H and --add foo (where module foo is not automatially added
> by -H). It looks like with -H specified, --add foo will not
> take any effect?
> 
> At least `-H --add nfs` doesn't work if my rootfs is not nfs,
> I see the following check in modules.d/95nfs/module-setup.sh,
> 
>     [ $hostonly ] && ! egrep -q '/ nfs[34 ]' /proc/mounts && return 1
> 
> So, is this expected? I mean as long as I specify -H, there is
> no way to add more modules? Or just the nfs check code is wrong?

Hmm, yes, currently all "add" modules also have the hostonly check.
Sometimes you want that behaviour, sometimes not..

We might want s.th. like "--force-add" for that use case.

> 
> Also, I am looking for a way to add all needed modules for
> devices mounted in current system, as -H only adds modules
> needed by rootfs.
> 
> Thanks!
> 

Not (yet) implemented. I accept patches :-)

Re: Q: How to add more modules when -H is specified?

[Américo Wang]

On Fri, Jul 29, 2011 at 5:24 PM, Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On 29.07.2011 10:57, WANG Cong wrote:
>>
>> Hi, dracut people,
>>
>> I am not sure about the expected behaviour when I specify both
>> -H and --add foo (where module foo is not automatially added
>> by -H). It looks like with -H specified, --add foo will not
>> take any effect?
>>
>> At least `-H --add nfs` doesn't work if my rootfs is not nfs,
>> I see the following check in modules.d/95nfs/module-setup.sh,
>>
>>     [ $hostonly ] && ! egrep -q '/ nfs[34 ]' /proc/mounts && return 1
>>
>> So, is this expected? I mean as long as I specify -H, there is
>> no way to add more modules? Or just the nfs check code is wrong?
>
> Hmm, yes, currently all "add" modules also have the hostonly check.
> Sometimes you want that behaviour, sometimes not..
>
> We might want s.th. like "--force-add" for that use case.

This is exactly what comes into my mind. :-D

>
>>
>> Also, I am looking for a way to add all needed modules for
>> devices mounted in current system, as -H only adds modules
>> needed by rootfs.
>>
>> Thanks!
>>
>
> Not (yet) implemented. I accept patches :-)
>

How about add a new option, e.g. '--all-mounted'?
Anyway, I will try to make some patches.

Thanks!