All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfstests: Add support for btrfs in 079
Date: Fri, 29 Jul 2011 16:30:12 +0200	[thread overview]
Message-ID: <4E32C3F4.8040505@giantdisaster.de> (raw)
In-Reply-To: <20110729123028.GA4764@infradead.org>

On 7/29/2011 2:30 PM, Christoph Hellwig wrote:
> On Fri, Jul 29, 2011 at 02:24:30PM +0200, Stefan Behrens wrote:

>> The difference between the filesystems is whether the append-only
>> flag from the directory is inherited to the newly create file inside
>> that directory. XFS does not inherit that append-only flag, ext2,
>> ext3, ext4 and btrfs do inherit it.

> Having different behaviour for different filesystems is a bad thing,
> and given that XFS is the lonely one out there I think we should
> remove the inheritance.  I'll preparate a patch for it.

In order to make it consistent, it would be needed to _add_ the
inheritance to XFS, not to remove it from XFS. Or to remove it from
ext2, ext3, ext4 and btrfs.

A different thread is whether it makes sense to inherit this flag
from directories to files. I would prefer to not inherit the
append-only flag from a directory to files created in that
directory, because the use case for setting the append-only flag
on directories is different to the use case for having the flag set
on files. I cannot imagine use cases where the inheritance of this
flag from the directory to the file is useful.
But I cannot find real-world use cases for setting this flag on
directories anyway, to all imaginable needs in this area the
solution is the sticky bit on the directory or ACLs.

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfstests: Add support for btrfs in 079
Date: Fri, 29 Jul 2011 16:30:12 +0200	[thread overview]
Message-ID: <4E32C3F4.8040505@giantdisaster.de> (raw)
In-Reply-To: <20110729123028.GA4764@infradead.org>

On 7/29/2011 2:30 PM, Christoph Hellwig wrote:
> On Fri, Jul 29, 2011 at 02:24:30PM +0200, Stefan Behrens wrote:

>> The difference between the filesystems is whether the append-only
>> flag from the directory is inherited to the newly create file inside
>> that directory. XFS does not inherit that append-only flag, ext2,
>> ext3, ext4 and btrfs do inherit it.

> Having different behaviour for different filesystems is a bad thing,
> and given that XFS is the lonely one out there I think we should
> remove the inheritance.  I'll preparate a patch for it.

In order to make it consistent, it would be needed to _add_ the
inheritance to XFS, not to remove it from XFS. Or to remove it from
ext2, ext3, ext4 and btrfs.

A different thread is whether it makes sense to inherit this flag
from directories to files. I would prefer to not inherit the
append-only flag from a directory to files created in that
directory, because the use case for setting the append-only flag
on directories is different to the use case for having the flag set
on files. I cannot imagine use cases where the inheritance of this
flag from the directory to the file is useful.
But I cannot find real-world use cases for setting this flag on
directories anyway, to all imaginable needs in this area the
solution is the sticky bit on the directory or ACLs.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-29 14:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-28  8:27 [PATCH 0/4] xfstests: Add support for btrfs in a couple of xfstests Stefan Behrens
2011-07-28  8:27 ` Stefan Behrens
2011-07-28  8:27 ` [PATCH 1/4] xfstests: Add support for btrfs in 062 Stefan Behrens
2011-07-28  8:27   ` Stefan Behrens
2011-07-28  8:45   ` Christoph Hellwig
2011-07-28  8:45     ` Christoph Hellwig
2011-07-28 17:51     ` Stefan Behrens
2011-07-28 17:51       ` Stefan Behrens
2011-07-28  8:27 ` [PATCH 2/4] xfstests: Add support for btrfs in 083, 117, 120 and 192 Stefan Behrens
2011-07-28  8:27   ` Stefan Behrens
2011-07-28  8:46   ` Christoph Hellwig
2011-07-28  8:46     ` Christoph Hellwig
2011-07-28  8:28 ` [PATCH 3/4] xfstests: Add support for btrfs in 015 Stefan Behrens
2011-07-28  8:28   ` Stefan Behrens
2011-07-28  8:47   ` Christoph Hellwig
2011-07-28  8:47     ` Christoph Hellwig
2011-07-28 17:54     ` Stefan Behrens
2011-07-28 17:54       ` Stefan Behrens
2011-07-28 20:05       ` Christoph Hellwig
2011-07-28 20:05         ` Christoph Hellwig
2011-07-28  8:28 ` [PATCH 4/4] xfstests: Add support for btrfs in 079 Stefan Behrens
2011-07-28  8:28   ` Stefan Behrens
2011-07-28  8:51   ` Christoph Hellwig
2011-07-28  8:51     ` Christoph Hellwig
2011-07-29 12:24     ` Stefan Behrens
2011-07-29 12:24       ` Stefan Behrens
2011-07-29 12:30       ` Christoph Hellwig
2011-07-29 12:30         ` Christoph Hellwig
2011-07-29 14:30         ` Stefan Behrens [this message]
2011-07-29 14:30           ` Stefan Behrens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E32C3F4.8040505@giantdisaster.de \
    --to=sbehrens@giantdisaster.de \
    --cc=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.