From: David Ahern <dsahern@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, paulus@samba.org, anton@samba.org,
acme@ghostprotocols.net, mingo@elte.hu,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] perf: powerpc: Disable pagefaults during callchain stack read
Date: Mon, 01 Aug 2011 06:44:36 -0600 [thread overview]
Message-ID: <4E369FB4.3070603@gmail.com> (raw)
In-Reply-To: <1312195147.8793.794.camel@pasglop>
On 08/01/2011 04:39 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2011-08-01 at 11:59 +0200, Peter Zijlstra wrote:
>>> Signed-off-by: David Ahern <dsahern@gmail.com>
>>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> CC: Anton Blanchard <anton@samba.org>
>>
>> Hmm, Paul, didn't you fix something like this early on? Anyway, I've
>> no
>> objections since I'm really not familiar enough with the PPC side of
>> things.
>
> I'm travelling so I haven't had a chance to review properly or even test
> but it looks like an ad-hoc fix for the immediate problem.
>
> Ultimately, I want to rework that stuff to do a __gup_fast like x86 does
> (maybe as a fallback from an attempt at access first) so we work around
> access permissions blocked by lack of dirty/accessed bits but in the
> meantime, this should fix the immediate issue.
The problem goes back to all kernel releases with perf, so this patch
should get applied to the stable trains too.
David
>
> Cheers,
> Ben.
>
>
WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
anton@samba.org, acme@ghostprotocols.net, mingo@elte.hu,
paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: powerpc: Disable pagefaults during callchain stack read
Date: Mon, 01 Aug 2011 06:44:36 -0600 [thread overview]
Message-ID: <4E369FB4.3070603@gmail.com> (raw)
In-Reply-To: <1312195147.8793.794.camel@pasglop>
On 08/01/2011 04:39 AM, Benjamin Herrenschmidt wrote:
> On Mon, 2011-08-01 at 11:59 +0200, Peter Zijlstra wrote:
>>> Signed-off-by: David Ahern <dsahern@gmail.com>
>>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>>> CC: Anton Blanchard <anton@samba.org>
>>
>> Hmm, Paul, didn't you fix something like this early on? Anyway, I've
>> no
>> objections since I'm really not familiar enough with the PPC side of
>> things.
>
> I'm travelling so I haven't had a chance to review properly or even test
> but it looks like an ad-hoc fix for the immediate problem.
>
> Ultimately, I want to rework that stuff to do a __gup_fast like x86 does
> (maybe as a fallback from an attempt at access first) so we work around
> access permissions blocked by lack of dirty/accessed bits but in the
> meantime, this should fix the immediate issue.
The problem goes back to all kernel releases with perf, so this patch
should get applied to the stable trains too.
David
>
> Cheers,
> Ben.
>
>
next prev parent reply other threads:[~2011-08-01 12:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-30 20:53 [PATCH] perf: powerpc: Disable pagefaults during callchain stack read David Ahern
2011-07-30 20:53 ` David Ahern
2011-08-01 9:59 ` Peter Zijlstra
2011-08-01 9:59 ` Peter Zijlstra
2011-08-01 10:39 ` Benjamin Herrenschmidt
2011-08-01 10:39 ` Benjamin Herrenschmidt
2011-08-01 12:44 ` David Ahern [this message]
2011-08-01 12:44 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2011-07-20 21:57 perf PPC: kernel panic with callchains and context switch events David Ahern
2011-07-24 17:18 ` David Ahern
2011-07-25 0:05 ` [PATCH] perf: powerpc: Disable pagefaults during callchain stack read Anton Blanchard
2011-07-25 0:05 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E369FB4.3070603@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.