From: Paolo Bonzini <pbonzini@redhat.com>
To: Umesh Deshpande <udeshpan@redhat.com>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
Juan Quintela <quintela@redhat.com>,
mtosatti@redhat.com
Subject: Re: [RFC PATCH v2 1/3] separate thread for VM migration
Date: Tue, 02 Aug 2011 09:44:18 +0200 [thread overview]
Message-ID: <4E37AAD2.2090706@redhat.com> (raw)
In-Reply-To: <4E371406.7040109@redhat.com>
On 08/01/2011 11:00 PM, Umesh Deshpande wrote:
>>
> I kept this in migration.c to call qemu_savevm_state_begin. (The way it
> is done currently. i.e. to keep access to FdMigrationState in migration.c)
> Calling it from buffered_file.c would be inconsistent in that sense. or
> we will have to call it from the iothread before spawning the migration
> thread.
Right, I missed that. Perhaps you can call it the first time put_ready
is called.
> Also why is the separation between FdMigrationState and QEMUFileBuffered
> is required. Is QEMUFileBuffered designed to use also for things other
> than migration?
No, but let's keep it this way for now. It may be an annoyance, but it
also helps making a reusable architecture, and it can probably be
cleaned up substantially with thread support.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Umesh Deshpande <udeshpan@redhat.com>
Cc: mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org,
Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 1/3] separate thread for VM migration
Date: Tue, 02 Aug 2011 09:44:18 +0200 [thread overview]
Message-ID: <4E37AAD2.2090706@redhat.com> (raw)
In-Reply-To: <4E371406.7040109@redhat.com>
On 08/01/2011 11:00 PM, Umesh Deshpande wrote:
>>
> I kept this in migration.c to call qemu_savevm_state_begin. (The way it
> is done currently. i.e. to keep access to FdMigrationState in migration.c)
> Calling it from buffered_file.c would be inconsistent in that sense. or
> we will have to call it from the iothread before spawning the migration
> thread.
Right, I missed that. Perhaps you can call it the first time put_ready
is called.
> Also why is the separation between FdMigrationState and QEMUFileBuffered
> is required. Is QEMUFileBuffered designed to use also for things other
> than migration?
No, but let's keep it this way for now. It may be an annoyance, but it
also helps making a reusable architecture, and it can probably be
cleaned up substantially with thread support.
Paolo
next prev parent reply other threads:[~2011-08-02 7:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 20:57 [RFC PATCH v2 0/3] separate thread for VM migration Umesh Deshpande
2011-07-29 20:57 ` [Qemu-devel] " Umesh Deshpande
2011-07-29 20:57 ` [RFC PATCH v2 1/3] " Umesh Deshpande
2011-07-29 20:57 ` [Qemu-devel] " Umesh Deshpande
2011-08-01 9:37 ` Paolo Bonzini
2011-08-01 9:37 ` [Qemu-devel] " Paolo Bonzini
2011-08-01 21:00 ` Umesh Deshpande
2011-08-01 21:00 ` [Qemu-devel] " Umesh Deshpande
2011-08-02 7:44 ` Paolo Bonzini [this message]
2011-08-02 7:44 ` Paolo Bonzini
2011-07-29 20:57 ` [RFC PATCH v2 2/3] fine grained qemu_mutex locking for migration Umesh Deshpande
2011-07-29 20:57 ` [Qemu-devel] " Umesh Deshpande
2011-08-01 9:39 ` Paolo Bonzini
2011-08-01 9:39 ` [Qemu-devel] " Paolo Bonzini
2011-08-02 16:30 ` Marcelo Tosatti
2011-08-02 16:30 ` [Qemu-devel] " Marcelo Tosatti
2011-07-29 20:57 ` [RFC PATCH v2 3/3] Per memslot dirty bitmap Umesh Deshpande
2011-07-29 20:57 ` [Qemu-devel] " Umesh Deshpande
2011-08-02 16:29 ` Marcelo Tosatti
2011-08-02 16:29 ` [Qemu-devel] " Marcelo Tosatti
2011-08-01 9:41 ` [RFC PATCH v2 0/3] separate thread for VM migration shawn che
2011-08-01 9:41 ` [Qemu-devel] " shawn che
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37AAD2.2090706@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=udeshpan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.