From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: julia@diku.dk
Cc: takata@linux-m32r.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org,
benh@kernel.crashing.org, jesper.nilsson@axis.com,
cmetcalf@tilera.com, linux-m32r@ml.linux-m32r.org,
linux-m32r-ja@ml.linux-m32r.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/11] arch/m32r/kernel/smp.c: trivial: use BUG_ON
Date: Tue, 02 Aug 2011 10:55:13 +0000 [thread overview]
Message-ID: <4E37D791.5070804@jp.fujitsu.com> (raw)
In-Reply-To: <1312281304-11847-8-git-send-email-julia@diku.dk>
(2011/08/02 19:35), Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
>
> @@ identifier x; @@
> -if (!x) BUG();
> +BUG_ON(!x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Indeed.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> ---
> arch/m32r/kernel/smp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
> --- a/arch/m32r/kernel/smp.c
> +++ b/arch/m32r/kernel/smp.c
> @@ -327,8 +327,7 @@ void smp_flush_tlb_page(struct vm_area_s
> cpumask_clear_cpu(cpu_id, &cpu_mask);
>
> #ifdef DEBUG_SMP
> - if (!mm)
> - BUG();
> + BUG_ON(!mm);
> #endif
>
> if (*mmc != NO_CONTEXT) {
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: julia@diku.dk
Cc: takata@linux-m32r.org, trivial@kernel.org,
kernel-janitors@vger.kernel.org, akpm@linux-foundation.org,
benh@kernel.crashing.org, jesper.nilsson@axis.com,
cmetcalf@tilera.com, linux-m32r@ml.linux-m32r.org,
linux-m32r-ja@ml.linux-m32r.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/11] arch/m32r/kernel/smp.c: trivial: use BUG_ON
Date: Tue, 02 Aug 2011 19:55:13 +0900 [thread overview]
Message-ID: <4E37D791.5070804@jp.fujitsu.com> (raw)
In-Reply-To: <1312281304-11847-8-git-send-email-julia@diku.dk>
(2011/08/02 19:35), Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
>
> @@ identifier x; @@
> -if (!x) BUG();
> +BUG_ON(!x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Indeed.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> ---
> arch/m32r/kernel/smp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
> --- a/arch/m32r/kernel/smp.c
> +++ b/arch/m32r/kernel/smp.c
> @@ -327,8 +327,7 @@ void smp_flush_tlb_page(struct vm_area_s
> cpumask_clear_cpu(cpu_id, &cpu_mask);
>
> #ifdef DEBUG_SMP
> - if (!mm)
> - BUG();
> + BUG_ON(!mm);
> #endif
>
> if (*mmc != NO_CONTEXT) {
>
>
>
next prev parent reply other threads:[~2011-08-02 10:55 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 10:34 [PATCH 0/11] trivial: use BUG_ON Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 10:34 ` [PATCH 1/11] kernel/kfifo.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 11:33 ` Andrea Righi
2011-08-02 11:33 ` Andrea Righi
2011-08-02 11:52 ` Julia Lawall
2011-08-02 11:52 ` Julia Lawall
2011-08-02 12:03 ` Andrea Righi
2011-08-02 12:03 ` Andrea Righi
2011-08-02 15:20 ` Julia Lawall
2011-08-02 15:20 ` Julia Lawall
2011-08-02 19:27 ` Julia Lawall
2011-08-02 19:27 ` Julia Lawall
2011-08-02 20:09 ` Andrea Righi
2011-08-02 20:09 ` Andrea Righi
2011-08-03 6:30 ` Stefani Seibold
2011-08-03 6:30 ` Stefani Seibold
2011-08-02 10:34 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-04 6:54 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use Nandigama, Nagalakshmi
2011-08-04 6:54 ` [PATCH 2/11] drivers/message/fusion/mptsas.c: trivial: use BUG_ON Nandigama, Nagalakshmi
2011-08-04 7:13 ` walter harms
2011-08-02 10:34 ` [PATCH 3/11] arch/arm/mach-s3c64xx/dma.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 10:34 ` [PATCH 4/11] arch/x86/kvm/vmx.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 16:44 ` Marcelo Tosatti
2011-08-02 16:44 ` Marcelo Tosatti
2011-08-02 10:34 ` [PATCH 5/11] kernel/sysctl.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 10:34 ` [PATCH 6/11] drivers/iommu/iommu.c: " Julia Lawall
2011-08-02 10:34 ` Julia Lawall
2011-08-02 10:35 ` [PATCH 7/11] arch/m32r/kernel/smp.c: " Julia Lawall
2011-08-02 10:35 ` Julia Lawall
2011-08-02 10:55 ` KOSAKI Motohiro [this message]
2011-08-02 10:55 ` KOSAKI Motohiro
2011-08-02 10:35 ` [PATCH 8/11] fs/btrfs/volumes.c: " Julia Lawall
2011-08-02 10:35 ` Julia Lawall
2011-08-02 10:35 ` [PATCH 9/11] drivers/target/target_core_rd.c: " Julia Lawall
2011-08-02 10:35 ` Julia Lawall
2011-08-04 18:05 ` [PATCH 9/11] drivers/target/target_core_rd.c: trivial: use Nicholas A. Bellinger
2011-08-04 18:05 ` [PATCH 9/11] drivers/target/target_core_rd.c: trivial: use BUG_ON Nicholas A. Bellinger
2011-08-02 10:35 ` [PATCH 10/11] arch/openrisc/mm/init.c: " Julia Lawall
2011-08-02 10:35 ` Julia Lawall
2011-08-02 13:55 ` Jonas Bonn
2011-08-02 13:55 ` Jonas Bonn
2011-08-02 10:35 ` [PATCH 11/11] arch/tile/mm/init.c: " Julia Lawall
2011-08-02 10:35 ` Julia Lawall
2011-08-02 20:28 ` Chris Metcalf
2011-08-02 20:28 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E37D791.5070804@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=jesper.nilsson@axis.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r-ja@ml.linux-m32r.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=takata@linux-m32r.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.