* [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
@ 2011-08-02 8:14 Kumar Gala
2011-08-02 10:09 ` Richard Purdie
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Kumar Gala @ 2011-08-02 8:14 UTC (permalink / raw)
To: openembedded-core
Add a fixup for trying to create ustar archives when the users
UID or GID is larger than the format allows.
Based on a patch from Tom Rini
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
meta/recipes-devtools/automake/automake.inc | 2 +-
.../prefer-cpio-over-pax-for-ustar-archives.patch | 26 ++++++++++++++++++++
meta/recipes-devtools/automake/automake_1.11.1.bb | 8 +++++-
3 files changed, 34 insertions(+), 2 deletions(-)
create mode 100644 meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
diff --git a/meta/recipes-devtools/automake/automake.inc b/meta/recipes-devtools/automake/automake.inc
index beeec7b..96d797f 100644
--- a/meta/recipes-devtools/automake/automake.inc
+++ b/meta/recipes-devtools/automake/automake.inc
@@ -4,7 +4,7 @@ Standards. Automake requires the use of Autoconf."
LICENSE = "GPLv2"
HOMEPAGE = "http://www.gnu.org/software/automake/"
SECTION = "devel"
-PR = "r2"
+PR = "r3"
SRC_URI = "${GNU_MIRROR}/automake/automake-${PV}.tar.bz2 "
diff --git a/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
new file mode 100644
index 0000000..3fda937
--- /dev/null
+++ b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
@@ -0,0 +1,26 @@
+Index: automake-1.11.1/m4/tar.m4
+===================================================================
+--- automake-1.11.1.orig/m4/tar.m4
++++ automake-1.11.1/m4/tar.m4
+@@ -30,7 +30,7 @@ m4_if([$1], [v7],
+ [m4_fatal([Unknown tar format])])
+ AC_MSG_CHECKING([how to create a $1 tar archive])
+ # Loop over all known methods to create a tar archive until one works.
+-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
+ _am_tools=${am_cv_prog_tar_$1-$_am_tools}
+ # Do not fold the above two line into one, because Tru64 sh and
+ # Solaris sh will not grok spaces in the rhs of `-'.
+Index: automake-1.11.1/Makefile.in
+===================================================================
+--- automake-1.11.1.orig/Makefile.in
++++ automake-1.11.1/Makefile.in
+@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
+ $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
+ $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
+ $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
+- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
++ $(top_srcdir)/m4/substnot.m4 \
+ $(top_srcdir)/configure.ac
+ am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
+ $(ACLOCAL_M4)
diff --git a/meta/recipes-devtools/automake/automake_1.11.1.bb b/meta/recipes-devtools/automake/automake_1.11.1.bb
index b231a94..764b6fc 100644
--- a/meta/recipes-devtools/automake/automake_1.11.1.bb
+++ b/meta/recipes-devtools/automake/automake_1.11.1.bb
@@ -32,11 +32,17 @@ RDEPENDS_automake-native = "autoconf-native perl-native-runtime"
PATHFIXPATCH = "file://path_prog_fixes.patch;patch=1"
PATHFIXPATCH_virtclass-native = ""
-SRC_URI += "${PATHFIXPATCH}"
+SRC_URI += "${PATHFIXPATCH} \
+ file://prefer-cpio-over-pax-for-ustar-archives.patch;patch=1"
SRC_URI[md5sum] = "c2972c4d9b3e29c03d5f2af86249876f"
SRC_URI[sha256sum] = "5b159d3c0e0a1f87de71b68bcb9f1a1c49e9e71749c9b723f17e2e1e0295c7ae"
+do_configure () {
+ touch ${S}/Makefile.in
+ autotools_do_configure
+}
+
do_install () {
oe_runmake 'DESTDIR=${D}' install
install -d ${D}${datadir}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 8:14 [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs Kumar Gala
@ 2011-08-02 10:09 ` Richard Purdie
2011-08-02 15:09 ` Khem Raj
2011-08-02 15:19 ` Phil Blundell
2 siblings, 0 replies; 9+ messages in thread
From: Richard Purdie @ 2011-08-02 10:09 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
> Add a fixup for trying to create ustar archives when the users
> UID or GID is larger than the format allows.
>
> Based on a patch from Tom Rini
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> meta/recipes-devtools/automake/automake.inc | 2 +-
> .../prefer-cpio-over-pax-for-ustar-archives.patch | 26 ++++++++++++++++++++
> meta/recipes-devtools/automake/automake_1.11.1.bb | 8 +++++-
> 3 files changed, 34 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
>
> diff --git a/meta/recipes-devtools/automake/automake.inc b/meta/recipes-devtools/automake/automake.inc
> index beeec7b..96d797f 100644
> --- a/meta/recipes-devtools/automake/automake.inc
> +++ b/meta/recipes-devtools/automake/automake.inc
> @@ -4,7 +4,7 @@ Standards. Automake requires the use of Autoconf."
> LICENSE = "GPLv2"
> HOMEPAGE = "http://www.gnu.org/software/automake/"
> SECTION = "devel"
> -PR = "r2"
> +PR = "r3"
>
> SRC_URI = "${GNU_MIRROR}/automake/automake-${PV}.tar.bz2 "
>
> diff --git a/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
> new file mode 100644
> index 0000000..3fda937
> --- /dev/null
> +++ b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
Can we add some documentation into the patch header about why this is
necessary and how it solved the problem please?
> @@ -0,0 +1,26 @@
> +Index: automake-1.11.1/m4/tar.m4
> +===================================================================
> +--- automake-1.11.1.orig/m4/tar.m4
> ++++ automake-1.11.1/m4/tar.m4
> +@@ -30,7 +30,7 @@ m4_if([$1], [v7],
> + [m4_fatal([Unknown tar format])])
> + AC_MSG_CHECKING([how to create a $1 tar archive])
> + # Loop over all known methods to create a tar archive until one works.
> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
> + _am_tools=${am_cv_prog_tar_$1-$_am_tools}
> + # Do not fold the above two line into one, because Tru64 sh and
> + # Solaris sh will not grok spaces in the rhs of `-'.
> +Index: automake-1.11.1/Makefile.in
> +===================================================================
> +--- automake-1.11.1.orig/Makefile.in
> ++++ automake-1.11.1/Makefile.in
> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
> ++ $(top_srcdir)/m4/substnot.m4 \
> + $(top_srcdir)/configure.ac
> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> + $(ACLOCAL_M4)
> diff --git a/meta/recipes-devtools/automake/automake_1.11.1.bb b/meta/recipes-devtools/automake/automake_1.11.1.bb
> index b231a94..764b6fc 100644
> --- a/meta/recipes-devtools/automake/automake_1.11.1.bb
> +++ b/meta/recipes-devtools/automake/automake_1.11.1.bb
> @@ -32,11 +32,17 @@ RDEPENDS_automake-native = "autoconf-native perl-native-runtime"
> PATHFIXPATCH = "file://path_prog_fixes.patch;patch=1"
> PATHFIXPATCH_virtclass-native = ""
>
> -SRC_URI += "${PATHFIXPATCH}"
> +SRC_URI += "${PATHFIXPATCH} \
> + file://prefer-cpio-over-pax-for-ustar-archives.patch;patch=1"
>
> SRC_URI[md5sum] = "c2972c4d9b3e29c03d5f2af86249876f"
> SRC_URI[sha256sum] = "5b159d3c0e0a1f87de71b68bcb9f1a1c49e9e71749c9b723f17e2e1e0295c7ae"
>
> +do_configure () {
> + touch ${S}/Makefile.in
> + autotools_do_configure
> +}
> +
and a comment here would be very useful too to explain why this is
necessary?
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 8:14 [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs Kumar Gala
2011-08-02 10:09 ` Richard Purdie
@ 2011-08-02 15:09 ` Khem Raj
2011-08-02 15:19 ` Phil Blundell
2 siblings, 0 replies; 9+ messages in thread
From: Khem Raj @ 2011-08-02 15:09 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Cc: openembedded-core@lists.openembedded.org
On Aug 2, 2011, at 1:14 AM, Kumar Gala <galak@kernel.crashing.org> wrote:
> Add a fixup for trying to create ustar archives when the users
> UID or GID is larger than the format allows.
>
> Based on a patch from Tom Rini
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> meta/recipes-devtools/automake/automake.inc | 2 +-
> .../prefer-cpio-over-pax-for-ustar-archives.patch | 26 ++++++++++++++++++++
> meta/recipes-devtools/automake/automake_1.11.1.bb | 8 +++++-
> 3 files changed, 34 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
>
> diff --git a/meta/recipes-devtools/automake/automake.inc b/meta/recipes-devtools/automake/automake.inc
> index beeec7b..96d797f 100644
> --- a/meta/recipes-devtools/automake/automake.inc
> +++ b/meta/recipes-devtools/automake/automake.inc
> @@ -4,7 +4,7 @@ Standards. Automake requires the use of Autoconf."
> LICENSE = "GPLv2"
> HOMEPAGE = "http://www.gnu.org/software/automake/"
> SECTION = "devel"
> -PR = "r2"
> +PR = "r3"
>
> SRC_URI = "${GNU_MIRROR}/automake/automake-${PV}.tar.bz2 "
>
> diff --git a/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
> new file mode 100644
> index 0000000..3fda937
> --- /dev/null
> +++ b/meta/recipes-devtools/automake/automake/prefer-cpio-over-pax-for-ustar-archives.patch
> @@ -0,0 +1,26 @@
> +Index: automake-1.11.1/m4/tar.m4
> +===================================================================
> +--- automake-1.11.1.orig/m4/tar.m4
> ++++ automake-1.11.1/m4/tar.m4
> +@@ -30,7 +30,7 @@ m4_if([$1], [v7],
> + [m4_fatal([Unknown tar format])])
> + AC_MSG_CHECKING([how to create a $1 tar archive])
> + # Loop over all known methods to create a tar archive until one works.
> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
> + _am_tools=${am_cv_prog_tar_$1-$_am_tools}
> + # Do not fold the above two line into one, because Tru64 sh and
> + # Solaris sh will not grok spaces in the rhs of `-'.
> +Index: automake-1.11.1/Makefile.in
> +===================================================================
> +--- automake-1.11.1.orig/Makefile.in
> ++++ automake-1.11.1/Makefile.in
> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
> ++ $(top_srcdir)/m4/substnot.m4 \
> + $(top_srcdir)/configure.ac
> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> + $(ACLOCAL_M4)
> diff --git a/meta/recipes-devtools/automake/automake_1.11.1.bb b/meta/recipes-devtools/automake/automake_1.11.1.bb
> index b231a94..764b6fc 100644
> --- a/meta/recipes-devtools/automake/automake_1.11.1.bb
> +++ b/meta/recipes-devtools/automake/automake_1.11.1.bb
> @@ -32,11 +32,17 @@ RDEPENDS_automake-native = "autoconf-native perl-native-runtime"
> PATHFIXPATCH = "file://path_prog_fixes.patch;patch=1"
> PATHFIXPATCH_virtclass-native = ""
>
> -SRC_URI += "${PATHFIXPATCH}"
> +SRC_URI += "${PATHFIXPATCH} \
> + file://prefer-cpio-over-pax-for-ustar-archives.patch;patch=1"
Patch level 1 is default so patch=1 is not needed here
>
> SRC_URI[md5sum] = "c2972c4d9b3e29c03d5f2af86249876f"
> SRC_URI[sha256sum] = "5b159d3c0e0a1f87de71b68bcb9f1a1c49e9e71749c9b723f17e2e1e0295c7ae"
>
> +do_configure () {
> + touch ${S}/Makefile.in
> + autotools_do_configure
> +}
> +
> do_install () {
> oe_runmake 'DESTDIR=${D}' install
> install -d ${D}${datadir}
> --
> 1.7.3.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 8:14 [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs Kumar Gala
2011-08-02 10:09 ` Richard Purdie
2011-08-02 15:09 ` Khem Raj
@ 2011-08-02 15:19 ` Phil Blundell
2011-08-02 15:34 ` Tom Rini
2 siblings, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2011-08-02 15:19 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
Have you discussed that with upstream? If not, are you confident that
preferring cpio will not simply mean that we are swapping one deficiency
for another?
> +Index: automake-1.11.1/Makefile.in
> +===================================================================
> +--- automake-1.11.1.orig/Makefile.in
> ++++ automake-1.11.1/Makefile.in
> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
> ++ $(top_srcdir)/m4/substnot.m4 \
> + $(top_srcdir)/configure.ac
> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
> + $(ACLOCAL_M4)
Can you explain why this hunk is necessary?
> +do_configure () {
> + touch ${S}/Makefile.in
> + autotools_do_configure
> +}
... and this one?
Also, your patch is missing a Signed-off-by line. See:
http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines#Patch_Headers_and_Commit_Messages
p.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 15:19 ` Phil Blundell
@ 2011-08-02 15:34 ` Tom Rini
2011-08-02 15:35 ` Tom Rini
2011-08-02 16:01 ` Kumar Gala
0 siblings, 2 replies; 9+ messages in thread
From: Tom Rini @ 2011-08-02 15:34 UTC (permalink / raw)
To: openembedded-core
On 08/02/2011 08:19 AM, Phil Blundell wrote:
> On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
>> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
>> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
>
> Have you discussed that with upstream? If not, are you confident that
> preferring cpio will not simply mean that we are swapping one deficiency
> for another?
A bug was filed with upstream automake. At issue is that pax does not
fail gracefully when it cannot create ustar archives while cpio does.
>> +Index: automake-1.11.1/Makefile.in
>> +===================================================================
>> +--- automake-1.11.1.orig/Makefile.in
>> ++++ automake-1.11.1/Makefile.in
>> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
>> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
>> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
>> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
>> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
>> ++ $(top_srcdir)/m4/substnot.m4 \
>> + $(top_srcdir)/configure.ac
>> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
>> + $(ACLOCAL_M4)
>
> Can you explain why this hunk is necessary?
That I don't recall. Possibly some sort of re-gen hell I was trying /
needing to avoid.
>
>> +do_configure () {
>> + touch ${S}/Makefile.in
>> + autotools_do_configure
>> +}
>
> ... and this one?
Didn't do that one. Kumar? :)
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 15:34 ` Tom Rini
@ 2011-08-02 15:35 ` Tom Rini
2011-08-02 16:01 ` Kumar Gala
1 sibling, 0 replies; 9+ messages in thread
From: Tom Rini @ 2011-08-02 15:35 UTC (permalink / raw)
To: openembedded-core
On 08/02/2011 08:34 AM, Tom Rini wrote:
> On 08/02/2011 08:19 AM, Phil Blundell wrote:
>> On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
>>> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
>>> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
>>
>> Have you discussed that with upstream? If not, are you confident that
>> preferring cpio will not simply mean that we are swapping one deficiency
>> for another?
>
> A bug was filed with upstream automake. At issue is that pax does not
> fail gracefully when it cannot create ustar archives while cpio does.
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8343 and should be in the
patch header...
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 15:34 ` Tom Rini
2011-08-02 15:35 ` Tom Rini
@ 2011-08-02 16:01 ` Kumar Gala
2011-08-02 16:04 ` Tom Rini
1 sibling, 1 reply; 9+ messages in thread
From: Kumar Gala @ 2011-08-02 16:01 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Aug 2, 2011, at 10:34 AM, Tom Rini wrote:
> On 08/02/2011 08:19 AM, Phil Blundell wrote:
>> On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
>>> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
>>> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
>>
>> Have you discussed that with upstream? If not, are you confident that
>> preferring cpio will not simply mean that we are swapping one deficiency
>> for another?
>
> A bug was filed with upstream automake. At issue is that pax does not
> fail gracefully when it cannot create ustar archives while cpio does.
>
>>> +Index: automake-1.11.1/Makefile.in
>>> +===================================================================
>>> +--- automake-1.11.1.orig/Makefile.in
>>> ++++ automake-1.11.1/Makefile.in
>>> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
>>> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
>>> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
>>> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
>>> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
>>> ++ $(top_srcdir)/m4/substnot.m4 \
>>> + $(top_srcdir)/configure.ac
>>> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
>>> + $(ACLOCAL_M4)
>>
>> Can you explain why this hunk is necessary?
>
> That I don't recall. Possibly some sort of re-gen hell I was trying /
> needing to avoid.
>
>>
>>> +do_configure () {
>>> + touch ${S}/Makefile.in
>>> + autotools_do_configure
>>> +}
>>
>> ... and this one?
>
> Didn't do that one. Kumar? :)
I think I pulled that from the SB3 change you made.
- k
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 16:01 ` Kumar Gala
@ 2011-08-02 16:04 ` Tom Rini
2011-08-02 16:08 ` Kumar Gala
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2011-08-02 16:04 UTC (permalink / raw)
To: openembedded-core
On 08/02/2011 09:01 AM, Kumar Gala wrote:
>
> On Aug 2, 2011, at 10:34 AM, Tom Rini wrote:
>
>> On 08/02/2011 08:19 AM, Phil Blundell wrote:
>>> On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
>>>> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
>>>> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
>>>
>>> Have you discussed that with upstream? If not, are you confident that
>>> preferring cpio will not simply mean that we are swapping one deficiency
>>> for another?
>>
>> A bug was filed with upstream automake. At issue is that pax does not
>> fail gracefully when it cannot create ustar archives while cpio does.
>>
>>>> +Index: automake-1.11.1/Makefile.in
>>>> +===================================================================
>>>> +--- automake-1.11.1.orig/Makefile.in
>>>> ++++ automake-1.11.1/Makefile.in
>>>> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
>>>> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
>>>> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
>>>> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
>>>> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
>>>> ++ $(top_srcdir)/m4/substnot.m4 \
>>>> + $(top_srcdir)/configure.ac
>>>> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
>>>> + $(ACLOCAL_M4)
>>>
>>> Can you explain why this hunk is necessary?
>>
>> That I don't recall. Possibly some sort of re-gen hell I was trying /
>> needing to avoid.
>>
>>>
>>>> +do_configure () {
>>>> + touch ${S}/Makefile.in
>>>> + autotools_do_configure
>>>> +}
>>>
>>> ... and this one?
>>
>> Didn't do that one. Kumar? :)
>
> I think I pulled that from the SB3 change you made.
Gah, you're right. I think it was more "avoid re-gen" bits.
--
Tom Rini
Mentor Graphics Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs
2011-08-02 16:04 ` Tom Rini
@ 2011-08-02 16:08 ` Kumar Gala
0 siblings, 0 replies; 9+ messages in thread
From: Kumar Gala @ 2011-08-02 16:08 UTC (permalink / raw)
To: Tom Rini; +Cc: Patches and discussions about the oe-core layer
On Aug 2, 2011, at 11:04 AM, Tom Rini wrote:
> On 08/02/2011 09:01 AM, Kumar Gala wrote:
>>
>> On Aug 2, 2011, at 10:34 AM, Tom Rini wrote:
>>
>>> On 08/02/2011 08:19 AM, Phil Blundell wrote:
>>>> On Tue, 2011-08-02 at 03:14 -0500, Kumar Gala wrote:
>>>>> +-_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) pax cpio none'
>>>>> ++_am_tools='gnutar m4_if([$1], [ustar], [plaintar]) cpio pax none'
>>>>
>>>> Have you discussed that with upstream? If not, are you confident that
>>>> preferring cpio will not simply mean that we are swapping one deficiency
>>>> for another?
>>>
>>> A bug was filed with upstream automake. At issue is that pax does not
>>> fail gracefully when it cannot create ustar archives while cpio does.
>>>
>>>>> +Index: automake-1.11.1/Makefile.in
>>>>> +===================================================================
>>>>> +--- automake-1.11.1.orig/Makefile.in
>>>>> ++++ automake-1.11.1/Makefile.in
>>>>> +@@ -44,7 +44,7 @@ am__aclocal_m4_deps = $(top_srcdir)/m4/a
>>>>> + $(top_srcdir)/m4/missing.m4 $(top_srcdir)/m4/mkdirp.m4 \
>>>>> + $(top_srcdir)/m4/options.m4 $(top_srcdir)/m4/runlog.m4 \
>>>>> + $(top_srcdir)/m4/sanity.m4 $(top_srcdir)/m4/strip.m4 \
>>>>> +- $(top_srcdir)/m4/substnot.m4 $(top_srcdir)/m4/tar.m4 \
>>>>> ++ $(top_srcdir)/m4/substnot.m4 \
>>>>> + $(top_srcdir)/configure.ac
>>>>> + am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \
>>>>> + $(ACLOCAL_M4)
>>>>
>>>> Can you explain why this hunk is necessary?
>>>
>>> That I don't recall. Possibly some sort of re-gen hell I was trying /
>>> needing to avoid.
>>>
>>>>
>>>>> +do_configure () {
>>>>> + touch ${S}/Makefile.in
>>>>> + autotools_do_configure
>>>>> +}
>>>>
>>>> ... and this one?
>>>
>>> Didn't do that one. Kumar? :)
>>
>> I think I pulled that from the SB3 change you made.
>
> Gah, you're right. I think it was more "avoid re-gen" bits.
Tom,
Do you mind take a stab at updating this patch based on feedback as your far more familiar with that I am ;)
- k
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-02 16:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-02 8:14 [PATCH] automake: Fix issue with tar configure failing with large UID/GIDs Kumar Gala
2011-08-02 10:09 ` Richard Purdie
2011-08-02 15:09 ` Khem Raj
2011-08-02 15:19 ` Phil Blundell
2011-08-02 15:34 ` Tom Rini
2011-08-02 15:35 ` Tom Rini
2011-08-02 16:01 ` Kumar Gala
2011-08-02 16:04 ` Tom Rini
2011-08-02 16:08 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.