From: Li Zefan <lizf@cn.fujitsu.com>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg from void * to journal_t * explicitly in kjournald/kjournald2
Date: Wed, 03 Aug 2011 10:31:13 +0800 [thread overview]
Message-ID: <4E38B2F1.8040903@cn.fujitsu.com> (raw)
In-Reply-To: <4E38AFC2.3070608@gmail.com>
Wang Sheng-Hui wrote:
> On 2011年08月03日 10:04, Li Zefan wrote:
>> 09:58, Wang Sheng-Hui wrote:
>>> The patch is against 3.0
>>>
>>> The arg of kjournald/kjournald2 is void *, and points to type
>>> journal_t. We should convert it to journal_t * explicitly in
>>> the kjournald/kjournald2 function body.
>>>
>>
>> Why?
>>
>> Implicit convertion from void * to foo * is ok. Did the compiler
>> complain about this to you?
>
> I remember any * can be assigned directly to void * in ANSI C, but
> void * should be converted to specific point * type. Right?
>
No.
> And I checked the code of kswapd, in which explicitly conversion is
> taken on the arg *. I think it should do so in journal.c too.
>
Please check more similar code.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Wang Sheng-Hui <shhuiw@gmail.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg from void * to journal_t * explicitly in kjournald/kjournald2
Date: Wed, 03 Aug 2011 10:31:13 +0800 [thread overview]
Message-ID: <4E38B2F1.8040903@cn.fujitsu.com> (raw)
In-Reply-To: <4E38AFC2.3070608@gmail.com>
Wang Sheng-Hui wrote:
> On 2011年08月03日 10:04, Li Zefan wrote:
>> 09:58, Wang Sheng-Hui wrote:
>>> The patch is against 3.0
>>>
>>> The arg of kjournald/kjournald2 is void *, and points to type
>>> journal_t. We should convert it to journal_t * explicitly in
>>> the kjournald/kjournald2 function body.
>>>
>>
>> Why?
>>
>> Implicit convertion from void * to foo * is ok. Did the compiler
>> complain about this to you?
>
> I remember any * can be assigned directly to void * in ANSI C, but
> void * should be converted to specific point * type. Right?
>
No.
> And I checked the code of kswapd, in which explicitly conversion is
> taken on the arg *. I think it should do so in journal.c too.
>
Please check more similar code.
next prev parent reply other threads:[~2011-08-03 2:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-03 1:58 [PATCH] jbd/jbd2: add pointer type conversion on void *arg from void * to journal_t * explicitly in kjournald/kjournald2 Wang Sheng-Hui
2011-08-03 2:04 ` Li Zefan
2011-08-03 2:17 ` Wang Sheng-Hui
2011-08-03 2:17 ` Wang Sheng-Hui
2011-08-03 2:31 ` Li Zefan [this message]
2011-08-03 2:31 ` Li Zefan
2011-08-03 2:52 ` Américo Wang
2011-08-03 2:55 ` Wang Sheng-Hui
2011-08-03 2:55 ` Wang Sheng-Hui
2011-08-03 3:24 ` Arnaud Lacombe
2011-08-03 5:38 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E38B2F1.8040903@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shhuiw@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.