From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.
Date: Wed, 03 Aug 2011 07:14:51 +0200 [thread overview]
Message-ID: <4E38D94B.7020100@denx.de> (raw)
In-Reply-To: <20110802201932.GA8861@schlenkerla.am.freescale.net>
Hello Scott,
Scott Wood wrote:
> Sorry for the delay, didn't see this the first time around -- just
> noticed it in patchwork.
No problem. Thanks for the review!
> On Sat, Jul 16, 2011 at 12:06:44AM -0000, Heiko Schocher wrote:
>> @@ -739,6 +743,10 @@ U_BOOT_CMD(
>> "nand env.oob set off|partition - set enviromnent offset\n"
>> "nand env.oob get - get environment offset"
>> #endif
>> +#ifdef CONFIG_CMD_NAND_HWFUNC
>> + "\n"
>> + "nand hwfunc " CONFIG_CMD_NAND_HWFUNC "\n"
>> +#endif
>
> Why not just define hardware-specific commands at whatever scope they
> makes sense (board code, controller driver, etc.), rather than add a
> generic hook here?
Hmm... because if I define a hw specific command for example at
soc scope, it is not a nand subcommand ... and I like to have all
nand commands (I use it for switching between different read/write
functions) accessable under "nand ..." from the u-boot shell ...
I don;t like to have all over the code randomised some nand commands ...
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2011-08-03 5:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 10:06 [U-Boot] [PATCH 0/9] arm, davinci: add support for dm368 based cam_enc_4xx board Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 1/9] mkimage: add UBL header support for booting davinci cpus Heiko Schocher
2011-07-28 14:52 ` Wolfgang Denk
2011-07-16 10:06 ` [U-Boot] [PATCH 2/9] arm, arm926: fix missing symbols in NAND_SPL mode Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 3/9] nand: add a hw specific subcommand to the nand command Heiko Schocher
2011-08-02 20:19 ` [U-Boot] [U-Boot, " Scott Wood
2011-08-03 5:14 ` Heiko Schocher [this message]
2011-08-03 15:56 ` Scott Wood
2011-08-04 5:40 ` Heiko Schocher
2011-08-04 19:42 ` Scott Wood
2011-08-04 20:14 ` Wolfgang Denk
2011-08-04 20:28 ` Scott Wood
2011-08-04 20:46 ` Wolfgang Denk
2011-07-16 10:06 ` [U-Boot] [PATCH 4/9] arm, davinci: add header files for dm365 Heiko Schocher
2011-10-05 14:28 ` [U-Boot] [PATCH v2 06/10] " Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 5/9] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 6/9] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-10-05 14:29 ` [U-Boot] [PATCH v2 07/10] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-10-05 14:29 ` [U-Boot] [PATCH v2 08/10] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 7/9] arm926ejs, davinci: add missing spi defines " Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 8/9] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-08-02 20:49 ` [U-Boot] [U-Boot, " Scott Wood
2011-07-16 10:06 ` [U-Boot] [PATCH 9/9] arm, davinci: add cam_enc_4xx support Heiko Schocher
2011-10-05 14:30 ` [U-Boot] [PATCH v2 10/10] " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E38D94B.7020100@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.