From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 3/9] nand: add a hw specific subcommand to the nand command.
Date: Thu, 4 Aug 2011 15:28:57 -0500 [thread overview]
Message-ID: <4E3B0109.5070201@freescale.com> (raw)
In-Reply-To: <20110804201406.25EFD177A7AE@gemini.denx.de>
On 08/04/2011 03:14 PM, Wolfgang Denk wrote:
> Dear Scott Wood,
>
> In message<4E3AF62B.8080605@freescale.com> you wrote:
>>
>> Again, I think "nand hwfunc" conveys little information about what it's
>> actually going to do, versus something like:
>>
>> => nandrbl
>> off
>
> I agree with Heiko that NAND related commands should be implemented as
> subcommands of the "nand" command.
>
> Havong "nand<subcommand>" and "nandrbl" at the same time is not
> acceptable to me - that should be changed into "nand rbl".
>
>> At least "nand hwfunc type" or "nand hwfunc rbl" would be more
>> informative, but I question the benefit that the verbosity buys us.
>
> I agree that "hwfunc" is an unlucky name.
>
>> So now it's "nand hwfunc ctrl type rbl"? Just to avoid grepping for
>> U_BOOT_CMD?
>
> No. I would not like this either.
How about some way of board/controller/etc. code plugging in commands to
"nand" without "hwfunc"? Could be a chained handler, or copying entries
into a command table, or some way of generalizing the stuff in
common/command.c to operate on multiple command lists. Though without
some change to how linker scripts are managed, to be practical that last
option would need to avoid introducing a new section per subtable (maybe
just filter out others when iterating). Would be nice to get tab
completion on subcommands.
-Scott
next prev parent reply other threads:[~2011-08-04 20:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-16 10:06 [U-Boot] [PATCH 0/9] arm, davinci: add support for dm368 based cam_enc_4xx board Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 1/9] mkimage: add UBL header support for booting davinci cpus Heiko Schocher
2011-07-28 14:52 ` Wolfgang Denk
2011-07-16 10:06 ` [U-Boot] [PATCH 2/9] arm, arm926: fix missing symbols in NAND_SPL mode Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 3/9] nand: add a hw specific subcommand to the nand command Heiko Schocher
2011-08-02 20:19 ` [U-Boot] [U-Boot, " Scott Wood
2011-08-03 5:14 ` Heiko Schocher
2011-08-03 15:56 ` Scott Wood
2011-08-04 5:40 ` Heiko Schocher
2011-08-04 19:42 ` Scott Wood
2011-08-04 20:14 ` Wolfgang Denk
2011-08-04 20:28 ` Scott Wood [this message]
2011-08-04 20:46 ` Wolfgang Denk
2011-07-16 10:06 ` [U-Boot] [PATCH 4/9] arm, davinci: add header files for dm365 Heiko Schocher
2011-10-05 14:28 ` [U-Boot] [PATCH v2 06/10] " Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 5/9] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 6/9] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-10-05 14:29 ` [U-Boot] [PATCH v2 07/10] arm, davinci: add lowlevel function for dm365 soc Heiko Schocher
2011-10-05 14:29 ` [U-Boot] [PATCH v2 08/10] arm926ejs, davinci: add cpuinfo for dm365 Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 7/9] arm926ejs, davinci: add missing spi defines " Heiko Schocher
2011-07-16 10:06 ` [U-Boot] [PATCH 8/9] spl, nand: add 4bit HW ecc oob first nand_read_page function Heiko Schocher
2011-08-02 20:49 ` [U-Boot] [U-Boot, " Scott Wood
2011-07-16 10:06 ` [U-Boot] [PATCH 9/9] arm, davinci: add cam_enc_4xx support Heiko Schocher
2011-10-05 14:30 ` [U-Boot] [PATCH v2 10/10] " Heiko Schocher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3B0109.5070201@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.