From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jay Vosburgh <fubar@us.ibm.com>, Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org
Subject: bonding and ifenslave version.
Date: Wed, 03 Aug 2011 08:43:47 +0200 [thread overview]
Message-ID: <4E38EE23.8030703@gmail.com> (raw)
In-Reply-To: <1312315615-5739-1-git-send-email-nicolas.2p.debian@free.fr>
Le 02/08/2011 22:06, Nicolas de Pesloüan a écrit :
> Commit 655f8919d549ad1872e24d826b6ce42530516d2e
> bonding: add min links parameter to 802.3ad
>
> and commit ebd8e4977a87cb81d93c62a9bff0102a9713722f
> bonding: add all_slaves_active parameter
>
> introduced new options to bonding, but didn't provide the documentation
> for those options.
>
> Signed-off-by: Nicolas de Pesloüan<nicolas.2p.debian@free.fr>
> ---
Jay, Andy,
While working at this patch, I noticed that the bonding driver version wasn't bumped up at the time
those options were introduced.
I thought introducing a new option should cause the driver version to change. Am I right?
On a different but related topic, the version in Documentation/networking/ifenslave.c (1.1.0) didn't
change since the git origin and probably since 2003.
Arguably, none of the commit regarding this file introduced a significant change (with the possible
exception of commit e6d184e33109010412ad1d59719af74755a935f4, [NET]: Fix ifenslave to not fail on
lack of IP information). But if we never change a 3-level version number, whatever the level of
change, this version number might be useless. Any comment?
Nicolas.
next prev parent reply other threads:[~2011-08-03 6:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 20:06 [PATCH] bonding: document two undocumented options Nicolas de Pesloüan
2011-08-03 6:43 ` Nicolas de Pesloüan [this message]
2011-08-03 19:03 ` bonding and ifenslave version Andy Gospodarek
2011-08-03 19:38 ` Nicolas de Pesloüan
2011-08-03 20:07 ` Jay Vosburgh
2011-08-03 20:38 ` Nicolas de Pesloüan
2011-08-03 21:33 ` Stephen Hemminger
2011-08-04 5:31 ` Nicolas de Pesloüan
2011-08-04 16:57 ` Stephen Hemminger
2011-08-04 21:20 ` Nicolas de Pesloüan
2011-08-03 10:44 ` [PATCH] bonding: document two undocumented options David Miller
2011-08-03 20:01 ` Nicolas de Pesloüan
2011-08-03 20:59 ` Jay Vosburgh
2011-08-04 5:41 ` Nicolas de Pesloüan
2011-08-06 17:06 ` [PATCH v3] " Nicolas de Pesloüan
2011-08-08 5:16 ` David Miller
2011-08-03 20:02 ` [PATCH] " Nicolas de Pesloüan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E38EE23.8030703@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.