All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Andy Gospodarek <andy@greyhouse.net>, netdev@vger.kernel.org
Subject: Re: bonding and ifenslave version.
Date: Wed, 03 Aug 2011 22:38:03 +0200	[thread overview]
Message-ID: <4E39B1AB.7050502@gmail.com> (raw)
In-Reply-To: <1718.1312402077@death>

Le 03/08/2011 22:07, Jay Vosburgh a écrit :
> Nicolas de Pesloüan<nicolas.2p.debian@gmail.com>  wrote:
>> Le 03/08/2011 21:03, Andy Gospodarek a écrit :

>>> Distributions benefit from version numbers on userspace utils.  It
>>> would probably be better to keep ifenslave's version number as it is
>>> to help those maintaining those distro packages.
>>
>> As one of the maintainers for the ifenslave package on Debian, I perfectly
>> understand the need for an upstream version, but as such, I expected the
>> upstream version number to change when the file change... Version numbers
>> in Debian use upstream version numbers when available and add a subversion
>> number for Debian specific changes. I would expect to change the version
>> number and not only the Debian subversion when the only change is a new
>> upstream version.
>
> 	One thing to remember here is that currently very few (perhaps
> no) distros use the ifenslave.c that comes with mainline.  The distros
> I'm familiar with configure bonding via sysfs, either directly in
> initscripts / sysconfig, or via a shell script ifenslave (which I
> believe is what Debian has).  Many distros still install it in
> /sbin/ifenslave, but it isn't used by the network configuration stuff.

The ifenslave package on Debian provide two things:

- The binary ifenslave, simply compiled from mainline ifenslave.c.
- A plug-in for ifupdown to allow for bonding related options in /etc/network/interfaces. I can 
confirm that this plug-in doesn't use the ifenslave command, but sysfs, since version 1.1.0-12 
(current stable version of this package is 1.1.0-17).

> 	The ifenslave.c in mainline is pretty much just a legacy for
> backwards compatibility; it has not had a bug fix since 2005 (a few typo
> repairs since then), and no major functional changes since before the
> git era.
>
> 	I was considering proposing feature removal for ifenslave.c and
> the ioctl API to add and remove slaves, but some discussion a few months
> ago indicated that there are apparently still some users out there (I'd
> guess embedded of some variety).

Unfortunately, there exist *many* how-to that suggest to use ifenslave, causing many users to use it 
instead of sysfs for bonding setup.

At least, we can:
- update the bonding documentation to clarify that ifenslave is deprecated (and move most ifenslave 
related stuffs at the end of the documentation);
- possibly issue a warning when the API is used, suggesting to use sysfs instead.

I can take care of the documentation update if appropriate.

	Nicolas.

  reply	other threads:[~2011-08-03 20:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02 20:06 [PATCH] bonding: document two undocumented options Nicolas de Pesloüan
2011-08-03  6:43 ` bonding and ifenslave version Nicolas de Pesloüan
2011-08-03 19:03   ` Andy Gospodarek
2011-08-03 19:38     ` Nicolas de Pesloüan
2011-08-03 20:07       ` Jay Vosburgh
2011-08-03 20:38         ` Nicolas de Pesloüan [this message]
2011-08-03 21:33           ` Stephen Hemminger
2011-08-04  5:31             ` Nicolas de Pesloüan
2011-08-04 16:57               ` Stephen Hemminger
2011-08-04 21:20                 ` Nicolas de Pesloüan
2011-08-03 10:44 ` [PATCH] bonding: document two undocumented options David Miller
2011-08-03 20:01   ` Nicolas de Pesloüan
2011-08-03 20:59     ` Jay Vosburgh
2011-08-04  5:41       ` Nicolas de Pesloüan
2011-08-06 17:06       ` [PATCH v3] " Nicolas de Pesloüan
2011-08-08  5:16         ` David Miller
2011-08-03 20:02   ` [PATCH] " Nicolas de Pesloüan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E39B1AB.7050502@gmail.com \
    --to=nicolas.2p.debian@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=fubar@us.ibm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.