From: Jan Kiszka <jan.kiszka@siemens.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path
Date: Wed, 03 Aug 2011 15:22:25 +0200 [thread overview]
Message-ID: <4E394B91.90301@siemens.com> (raw)
In-Reply-To: <4E38FAE3.8070408@msgid.tls.msk.ru>
On 2011-08-03 09:38, Michael Tokarev wrote:
> So, can we decide on this somehow? I don't see a code
> path where we don't call monitor_resume at the end,
> so the "intermediate" monitor_resume can be dropped.
> This way we fix real bug. If there will be other
> problem from that, it can be fixed later - this will
> mean that code path is found...
I do not see any reason for the spurious resume as well, so you may add my
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Should I resend the initial patch again?
May help to finally trigger the merge. Direct it to Luiz Capitulino as
the subsystem maintainer.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-08-03 13:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 11:46 [Qemu-devel] [PATCH] do not call monitor_resume() from migrate_fd_put_buffer() error path Michael Tokarev
2011-07-19 21:48 ` Jan Kiszka
2011-07-20 16:34 ` Marcelo Tosatti
2011-07-20 22:06 ` Jan Kiszka
2011-08-03 7:38 ` Michael Tokarev
2011-08-03 13:22 ` Jan Kiszka [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-03 14:51 Michael Tokarev
2011-08-04 19:24 ` Luiz Capitulino
2011-08-04 19:52 ` Michael Tokarev
2011-08-04 20:00 ` Michael Tokarev
2011-08-04 22:19 ` Jan Kiszka
2011-08-05 6:51 ` Michael Tokarev
2011-08-05 7:11 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E394B91.90301@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=mjt@tls.msk.ru \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.