All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dor Laor <dlaor@redhat.com>
To: kvm-ia64@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped
Date: Thu, 04 Aug 2011 08:37:12 +0000	[thread overview]
Message-ID: <4E3A5A38.9080406@redhat.com> (raw)
In-Reply-To: <1312381501-27746-1-git-send-email-emunson@mgebm.net>

On 08/03/2011 05:24 PM, Eric B Munson wrote:
> This set is just a rough first pass at avoiding soft lockup warnings when a host
> pauses the execution of a guest.  A flag is set by the host in the shared page
> used for the pvclock when the host goes to stop the guest.  When the guest
> resumes and detects a soft lockup, this flag is checked and cleared and the soft
> lockup message is skipped.

While this will cover the case were the host stops a guest, there will 
be other plain cases where the host is just over committed and will 
cause a softlockup false positive on the guest.

Softlockup should use stolen time that makes use of the guest running 
info would cover both cases

>
> This currently breaks the build for non-x86 architectures but part of what I am
> looking for here is how to go about adding the function stubs for everything
> else.
>
> Eric B Munson (3):
>    Add flag to indicate that a vm was stopped by the host
>    Add functions to check if the host has stopped the vm
>    Add check for suspended vm in softlockup detector
>
>   arch/x86/include/asm/pvclock-abi.h |    1 +
>   arch/x86/include/asm/pvclock.h     |    3 +++
>   arch/x86/kernel/kvmclock.c         |   12 ++++++++++++
>   kernel/watchdog.c                  |   11 +++++++++++
>   4 files changed, 27 insertions(+), 0 deletions(-)
>


WARNING: multiple messages have this Message-ID (diff)
From: Dor Laor <dlaor@redhat.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
	kvm-ppc@vger.kernel.org, avi@redhat.com, riel@redhat.com,
	glommer@redhat.com, linux-kernel@vger.kernel.org,
	aliguori@us.ibm.com, raharper@us.ibm.com,
	Glauber Costa <glommer@gmail.com>
Subject: Re: [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped
Date: Thu, 04 Aug 2011 08:37:12 +0000	[thread overview]
Message-ID: <4E3A5A38.9080406@redhat.com> (raw)
In-Reply-To: <1312381501-27746-1-git-send-email-emunson@mgebm.net>

On 08/03/2011 05:24 PM, Eric B Munson wrote:
> This set is just a rough first pass at avoiding soft lockup warnings when a host
> pauses the execution of a guest.  A flag is set by the host in the shared page
> used for the pvclock when the host goes to stop the guest.  When the guest
> resumes and detects a soft lockup, this flag is checked and cleared and the soft
> lockup message is skipped.

While this will cover the case were the host stops a guest, there will 
be other plain cases where the host is just over committed and will 
cause a softlockup false positive on the guest.

Softlockup should use stolen time that makes use of the guest running 
info would cover both cases

>
> This currently breaks the build for non-x86 architectures but part of what I am
> looking for here is how to go about adding the function stubs for everything
> else.
>
> Eric B Munson (3):
>    Add flag to indicate that a vm was stopped by the host
>    Add functions to check if the host has stopped the vm
>    Add check for suspended vm in softlockup detector
>
>   arch/x86/include/asm/pvclock-abi.h |    1 +
>   arch/x86/include/asm/pvclock.h     |    3 +++
>   arch/x86/kernel/kvmclock.c         |   12 ++++++++++++
>   kernel/watchdog.c                  |   11 +++++++++++
>   4 files changed, 27 insertions(+), 0 deletions(-)
>


WARNING: multiple messages have this Message-ID (diff)
From: Dor Laor <dlaor@redhat.com>
To: Eric B Munson <emunson@mgebm.net>
Cc: kvm@vger.kernel.org, kvm-ia64@vger.kernel.org,
	kvm-ppc@vger.kernel.org, avi@redhat.com, riel@redhat.com,
	glommer@redhat.com, linux-kernel@vger.kernel.org,
	aliguori@us.ibm.com, raharper@us.ibm.com,
	Glauber Costa <glommer@gmail.com>
Subject: Re: [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host
Date: Thu, 04 Aug 2011 11:37:12 +0300	[thread overview]
Message-ID: <4E3A5A38.9080406@redhat.com> (raw)
In-Reply-To: <1312381501-27746-1-git-send-email-emunson@mgebm.net>

On 08/03/2011 05:24 PM, Eric B Munson wrote:
> This set is just a rough first pass at avoiding soft lockup warnings when a host
> pauses the execution of a guest.  A flag is set by the host in the shared page
> used for the pvclock when the host goes to stop the guest.  When the guest
> resumes and detects a soft lockup, this flag is checked and cleared and the soft
> lockup message is skipped.

While this will cover the case were the host stops a guest, there will 
be other plain cases where the host is just over committed and will 
cause a softlockup false positive on the guest.

Softlockup should use stolen time that makes use of the guest running 
info would cover both cases

>
> This currently breaks the build for non-x86 architectures but part of what I am
> looking for here is how to go about adding the function stubs for everything
> else.
>
> Eric B Munson (3):
>    Add flag to indicate that a vm was stopped by the host
>    Add functions to check if the host has stopped the vm
>    Add check for suspended vm in softlockup detector
>
>   arch/x86/include/asm/pvclock-abi.h |    1 +
>   arch/x86/include/asm/pvclock.h     |    3 +++
>   arch/x86/kernel/kvmclock.c         |   12 ++++++++++++
>   kernel/watchdog.c                  |   11 +++++++++++
>   4 files changed, 27 insertions(+), 0 deletions(-)
>


  reply	other threads:[~2011-08-04  8:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 14:24 [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host Eric B Munson
2011-08-03 14:24 ` Eric B Munson
2011-08-03 14:24 ` Eric B Munson
2011-08-04  8:37 ` Dor Laor [this message]
2011-08-04  8:37   ` Dor Laor
2011-08-04  8:37   ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped Dor Laor
2011-08-04 16:29 ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by Marcelo Tosatti
2011-08-04 16:29   ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host Marcelo Tosatti
2011-08-04 16:29   ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by Marcelo Tosatti
2011-08-04 18:46 ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped Anthony Liguori
2011-08-04 18:46   ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped by host Anthony Liguori
2011-08-04 18:46   ` [RFC PATCH 0/3] Avoid soft lockup message when KVM is stopped Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2011-08-03 14:24 [RFC PATCH 1/3] Add flag to indicate that a vm was stopped by the host Eric B Munson
2011-08-03 14:24 ` Eric B Munson
2011-08-03 14:24 ` Eric B Munson
2011-08-03 14:25 [RFC PATCH 2/3] Add functions to check if the host has stopped the vm Eric B Munson
2011-08-03 14:25 ` Eric B Munson
2011-08-03 14:25 ` Eric B Munson
2011-08-03 14:25 [RFC PATCH 3/3] Add check for suspended vm in softlockup detector Eric B Munson
2011-08-03 14:25 ` Eric B Munson
2011-08-03 14:25 ` Eric B Munson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3A5A38.9080406@redhat.com \
    --to=dlaor@redhat.com \
    --cc=kvm-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.