All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Barry Song <21cnbao@gmail.com>
Cc: "Hilman, Kevin" <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>,
	"G, Manjunath Kondaiah" <manjugk@ti.com>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"Nayak, Rajendra" <rnayak@ti.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: Shouldn't DT preserve pdev name and id to allow platform_match to work?
Date: Fri, 5 Aug 2011 14:31:16 +0200	[thread overview]
Message-ID: <4E3BE294.2020404@ti.com> (raw)
In-Reply-To: <CAGsJ_4x7LWRGWXsWzMG1FxZPaFYiKSUpSac2PdwH=d6vqFWRfw@mail.gmail.com>

On 8/5/2011 12:02 PM, Barry Song wrote:
>> auxdata passes platform_data and overrides the device name when there
>> is no way easy way to make the driver work without it.  It handles the
>> the current implementation of clocks and regulators which aren't yet
>> populated from the device tree.  It will go away when clock&
>> regulator bindings are implemented.
> Yes. As OF_DEV_AUXDATA_ID still requires hardware information like
> 0x48000100 as below, it seems it is not
> consistent with the origin purpose of ARM DT.
> OF_DEV_AUXDATA_ID("ti,omap-i2c", 0x48000100, "omap-i2c.1", 1,&i2c_pdata)
> And the information 0x48000100 is something that doesn't want to be in
> kernel codes.it should be only in dts.

FWIW, I do not care about the physical address at all. This is just used 
by the of_dev_lookup function to get the proper instance for a device 
compatible type.
That's the only way for the OF_DEV_AUXDATA to work, but in theory you 
could do the same as soon as you provide the id. So OF_DEV_AUXDATA_ID 
could avoid it.

Since OF_DEV_AUXDATA_ID seems to be already dead before it even reaches 
the mainline, let's forget about that.

Regards,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: Shouldn't DT preserve pdev name and id to allow platform_match to work?
Date: Fri, 5 Aug 2011 14:31:16 +0200	[thread overview]
Message-ID: <4E3BE294.2020404@ti.com> (raw)
In-Reply-To: <CAGsJ_4x7LWRGWXsWzMG1FxZPaFYiKSUpSac2PdwH=d6vqFWRfw@mail.gmail.com>

On 8/5/2011 12:02 PM, Barry Song wrote:
>> auxdata passes platform_data and overrides the device name when there
>> is no way easy way to make the driver work without it.  It handles the
>> the current implementation of clocks and regulators which aren't yet
>> populated from the device tree.  It will go away when clock&
>> regulator bindings are implemented.
> Yes. As OF_DEV_AUXDATA_ID still requires hardware information like
> 0x48000100 as below, it seems it is not
> consistent with the origin purpose of ARM DT.
> OF_DEV_AUXDATA_ID("ti,omap-i2c", 0x48000100, "omap-i2c.1", 1,&i2c_pdata)
> And the information 0x48000100 is something that doesn't want to be in
> kernel codes.it should be only in dts.

FWIW, I do not care about the physical address at all. This is just used 
by the of_dev_lookup function to get the proper instance for a device 
compatible type.
That's the only way for the OF_DEV_AUXDATA to work, but in theory you 
could do the same as soon as you provide the id. So OF_DEV_AUXDATA_ID 
could avoid it.

Since OF_DEV_AUXDATA_ID seems to be already dead before it even reaches 
the mainline, let's forget about that.

Regards,
Benoit

  reply	other threads:[~2011-08-05 12:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-03 15:04 Shouldn't DT preserve pdev name and id to allow platform_match to work? Cousson, Benoit
2011-08-03 15:04 ` Cousson, Benoit
2011-08-03 16:17 ` G, Manjunath Kondaiah
2011-08-03 16:17   ` G, Manjunath Kondaiah
     [not found]   ` <CAC63_iRa1qc7pO9Eub1A+cC+R=tSkwzigVPDHqcbvOngACYWqQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-03 16:27     ` Cousson, Benoit
2011-08-03 16:27       ` Cousson, Benoit
2011-08-03 16:43 ` Grant Likely
2011-08-03 16:43   ` Grant Likely
2011-08-05 10:02   ` Barry Song
2011-08-05 10:02     ` Barry Song
2011-08-05 12:31     ` Cousson, Benoit [this message]
2011-08-05 12:31       ` Cousson, Benoit
     [not found]       ` <4E3BE294.2020404-l0cyMroinI0@public.gmane.org>
2011-08-07  4:13         ` Grant Likely
2011-08-07  4:13           ` Grant Likely
2011-08-05 12:19   ` Cousson, Benoit
2011-08-05 12:19     ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E3BE294.2020404@ti.com \
    --to=b-cousson@ti.com \
    --cc=21cnbao@gmail.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=paul@pwsan.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.