From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Joerg Roedel <joerg.roedel@amd.com>
Subject: Re: [PATCH 5/6] qemu-x86: Set tsc_khz in kvm when supported
Date: Fri, 05 Aug 2011 23:28:51 +0200 [thread overview]
Message-ID: <4E3C6093.3010601@web.de> (raw)
In-Reply-To: <e7429073ed1a765180158622463e8e0fb1b296d7.1312577731.git.mtosatti@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On 2011-08-05 22:55, Marcelo Tosatti wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
>
> Make use of the KVM_TSC_CONTROL feature if available.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> ---
> target-i386/kvm.c | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 10fb2c4..923d2d5 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -354,6 +354,7 @@ int kvm_arch_init_vcpu(CPUState *env)
> uint32_t unused;
> struct kvm_cpuid_entry2 *c;
> uint32_t signature[3];
> + int r;
>
> env->cpuid_features &= kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
>
> @@ -499,7 +500,22 @@ int kvm_arch_init_vcpu(CPUState *env)
>
> qemu_add_vm_change_state_handler(cpu_update_state, env);
>
> - return kvm_vcpu_ioctl(env, KVM_SET_CPUID2, &cpuid_data);
> + r = kvm_vcpu_ioctl(env, KVM_SET_CPUID2, &cpuid_data);
> + if (r)
> + return r;
Coding style...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-x86: Set tsc_khz in kvm when supported
Date: Fri, 05 Aug 2011 23:28:51 +0200 [thread overview]
Message-ID: <4E3C6093.3010601@web.de> (raw)
In-Reply-To: <e7429073ed1a765180158622463e8e0fb1b296d7.1312577731.git.mtosatti@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On 2011-08-05 22:55, Marcelo Tosatti wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
>
> Make use of the KVM_TSC_CONTROL feature if available.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> ---
> target-i386/kvm.c | 18 +++++++++++++++++-
> 1 files changed, 17 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/kvm.c b/target-i386/kvm.c
> index 10fb2c4..923d2d5 100644
> --- a/target-i386/kvm.c
> +++ b/target-i386/kvm.c
> @@ -354,6 +354,7 @@ int kvm_arch_init_vcpu(CPUState *env)
> uint32_t unused;
> struct kvm_cpuid_entry2 *c;
> uint32_t signature[3];
> + int r;
>
> env->cpuid_features &= kvm_arch_get_supported_cpuid(s, 1, 0, R_EDX);
>
> @@ -499,7 +500,22 @@ int kvm_arch_init_vcpu(CPUState *env)
>
> qemu_add_vm_change_state_handler(cpu_update_state, env);
>
> - return kvm_vcpu_ioctl(env, KVM_SET_CPUID2, &cpuid_data);
> + r = kvm_vcpu_ioctl(env, KVM_SET_CPUID2, &cpuid_data);
> + if (r)
> + return r;
Coding style...
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2011-08-05 21:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 20:55 [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 20:55 ` [PATCH 1/6] kvmclock: Fix feature detection Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 20:55 ` [PATCH 2/6] kvm: Drop obsolete KVM_IOEVENTFD #ifdefs Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 20:55 ` [PATCH 3/6] qemu: Add strtosz_suffix_unit function Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 20:55 ` [PATCH 4/6] qemu-x86: Add tsc_freq option to -cpu Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 20:55 ` [PATCH 5/6] qemu-x86: Set tsc_khz in kvm when supported Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-05 21:28 ` Jan Kiszka [this message]
2011-08-05 21:28 ` Jan Kiszka
2011-08-05 20:55 ` [PATCH 6/6] Remove #ifdef KVM_CAP_TSC_CONTROL Marcelo Tosatti
2011-08-05 20:55 ` [Qemu-devel] " Marcelo Tosatti
2011-08-08 20:07 ` [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue Anthony Liguori
2011-08-08 20:07 ` [Qemu-devel] " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3C6093.3010601@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.