[PATCH] hfpmodem: Fix g_at_chat leak

[PATCH] hfpmodem: Fix g_at_chat leak

[=?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Dalleau]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

---
 drivers/hfpmodem/call-volume.c          |    1 +
 drivers/hfpmodem/network-registration.c |    1 +
 drivers/hfpmodem/voicecall.c            |    1 +
 3 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/hfpmodem/call-volume.c b/drivers/hfpmodem/call-volume.c
index df83657..c0c4869 100644
--- a/drivers/hfpmodem/call-volume.c
+++ b/drivers/hfpmodem/call-volume.c
@@ -206,6 +206,7 @@ static void hfp_call_volume_remove(struct ofono_call_volume *cv)
 
 	ofono_call_volume_set_data(cv, NULL);
 
+	g_at_chat_unref(vd->chat);
 	g_free(vd);
 }
 
diff --git a/drivers/hfpmodem/network-registration.c b/drivers/hfpmodem/network-registration.c
index 7d26424..6703885 100644
--- a/drivers/hfpmodem/network-registration.c
+++ b/drivers/hfpmodem/network-registration.c
@@ -331,6 +331,7 @@ static void hfp_netreg_remove(struct ofono_netreg *netreg)
 
 	ofono_netreg_set_data(netreg, NULL);
 
+	g_at_chat_unref(nd->chat);
 	g_free(nd);
 }
 
diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c
index 3c49870..9903db0 100644
--- a/drivers/hfpmodem/voicecall.c
+++ b/drivers/hfpmodem/voicecall.c
@@ -1166,6 +1166,7 @@ static void hfp_voicecall_remove(struct ofono_voicecall *vc)
 
 	ofono_voicecall_set_data(vc, NULL);
 
+	g_at_chat_unref(vd->chat);
 	g_free(vd);
 }
 
-- 
1.7.1

Re: [PATCH] hfpmodem: Fix g_at_chat leak

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Hi Frédéric,

On 08/04/2011 07:48 AM, Frédéric Dalleau wrote:
> ---
>  drivers/hfpmodem/call-volume.c          |    1 +
>  drivers/hfpmodem/network-registration.c |    1 +
>  drivers/hfpmodem/voicecall.c            |    1 +
>  3 files changed, 3 insertions(+), 0 deletions(-)
> 

Patch has been applied.  Thanks for spotting this one.  This one is my
fault since I introduced it during the hfpmodem refactoring.

Regards,
-Denis