From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
lethal@linux-sh.org, Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH V2] viafb: replace strict_strtoul to kstrto* and check
Date: Mon, 08 Aug 2011 00:10:55 +0000 [thread overview]
Message-ID: <4E3F298F.406@gmx.de> (raw)
In-Reply-To: <1312760553-2143-1-git-send-email-wangshaoyan.pt@taobao.com>
On 08/07/2011 11:42 PM, stufever@gmail.com wrote:
> diff --git drivers/video/via/viafbdev.c drivers/video/via/viafbdev.c
Um, you did something different this time, causing another (not critical)
checkpatch warning
WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch
> @@ -1325,7 +1328,8 @@ static ssize_t viafb_dfpl_proc_write(struct file *file,
> if (copy_from_user(&buf[0], buffer, length))
> return -EFAULT;
> buf[length - 1] = '\0'; /*Ensure end string */
> - strict_strtoul(&buf[0], 0, (unsigned long *)®_val);
> + if (kstrtou8(buf, -1,®_val)< 0)
Did you miss my comment about the -1 above last time? Why it is there?
> + return -EINVAL;
> viafb_write_reg_mask(CR99, VIACR, reg_val, 0x0f);
> return count;
> }
Thanks,
Florian Tobias Schandinat
WARNING: multiple messages have this Message-ID (diff)
From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: stufever@gmail.com
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
lethal@linux-sh.org, Wang Shaoyan <wangshaoyan.pt@taobao.com>
Subject: Re: [PATCH V2] viafb: replace strict_strtoul to kstrto* and check return value
Date: Mon, 08 Aug 2011 00:10:55 +0000 [thread overview]
Message-ID: <4E3F298F.406@gmx.de> (raw)
In-Reply-To: <1312760553-2143-1-git-send-email-wangshaoyan.pt@taobao.com>
On 08/07/2011 11:42 PM, stufever@gmail.com wrote:
> diff --git drivers/video/via/viafbdev.c drivers/video/via/viafbdev.c
Um, you did something different this time, causing another (not critical)
checkpatch warning
WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch
> @@ -1325,7 +1328,8 @@ static ssize_t viafb_dfpl_proc_write(struct file *file,
> if (copy_from_user(&buf[0], buffer, length))
> return -EFAULT;
> buf[length - 1] = '\0'; /*Ensure end string */
> - strict_strtoul(&buf[0], 0, (unsigned long *)®_val);
> + if (kstrtou8(buf, -1,®_val)< 0)
Did you miss my comment about the -1 above last time? Why it is there?
> + return -EINVAL;
> viafb_write_reg_mask(CR99, VIACR, reg_val, 0x0f);
> return count;
> }
Thanks,
Florian Tobias Schandinat
next prev parent reply other threads:[~2011-08-08 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-07 23:42 [PATCH V2] viafb: replace strict_strtoul to kstrto* and check return value stufever
2011-08-07 23:42 ` stufever
2011-08-08 0:10 ` Florian Tobias Schandinat [this message]
2011-08-08 0:10 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3F298F.406@gmx.de \
--to=florianschandinat@gmx.de \
--cc=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stufever@gmail.com \
--cc=wangshaoyan.pt@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.