From: Avi Kivity <avi@redhat.com>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: Christoffer Dall <cdall@cs.columbia.edu>,
tech@virtualopensystems.com, android-virt@lists.cs.columbia.edu,
kvm@vger.kernel.org
Subject: Re: [Android-virt] [PATCH v4 05/10] ARM: KVM: Inject IRQs and FIQs from userspace
Date: Tue, 09 Aug 2011 14:37:38 +0300 [thread overview]
Message-ID: <4E411C02.6070008@redhat.com> (raw)
In-Reply-To: <E836B532-FB83-4C00-A57E-AFB71E88DB08@virtualopensystems.com>
On 08/09/2011 02:27 PM, Christoffer Dall wrote:
> >
> >> +
> >> + if (irq_level->level) {
> >> + vcpu->arch.virt_irq |= mask;
> >> + vcpu->arch.wait_for_interrupts = 0;
> >> + } else
> >> + vcpu->arch.virt_irq&= ~mask;
> >> +
> >
> > This seems to be non-smp-safe? Do you need atomic ops and barriers
> > here? And a wakeup?
>
> The whole thing is not SMP tested yet, so I took some shortcuts. I only recently got hold of a SMP model and SMP support will be a focus area for the next series. Thanks for pin-pointing this though.
Note even a single vcpu guest on an smp host needs this.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-08-09 11:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-06 10:38 [PATCH v4 00/10] KVM/ARM Implementation Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 01/10] ARM: KVM: Initial skeleton to compile KVM support Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 02/10] ARM: KVM: Hypervisor identity mapping Christoffer Dall
2011-08-09 9:20 ` Avi Kivity
2011-08-09 9:29 ` Catalin Marinas
2011-08-09 9:29 ` Christoffer Dall
2011-08-09 10:23 ` [Android-virt] " Alexey Smirnov
2011-08-09 11:23 ` Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 03/10] ARM: KVM: Add hypervisor inititalization Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 04/10] ARM: KVM: Memory virtualization setup Christoffer Dall
2011-08-09 9:57 ` Avi Kivity
2011-08-09 11:24 ` [Android-virt] " Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 05/10] ARM: KVM: Inject IRQs and FIQs from userspace Christoffer Dall
2011-08-09 10:07 ` Avi Kivity
2011-08-09 11:27 ` [Android-virt] " Christoffer Dall
2011-08-09 11:37 ` Avi Kivity [this message]
2011-08-09 11:40 ` Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 06/10] ARM: KVM: World-switch implementation Christoffer Dall
2011-08-09 11:09 ` Avi Kivity
2011-08-09 11:29 ` Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 07/10] ARM: KVM: Emulation framework and CP15 emulation Christoffer Dall
2011-08-09 11:17 ` Avi Kivity
2011-08-09 11:34 ` Christoffer Dall
2011-08-09 11:39 ` Avi Kivity
2011-08-09 11:40 ` Christoffer Dall
2011-08-06 10:39 ` [PATCH v4 08/10] ARM: KVM: Handle guest faults in KVM Christoffer Dall
2011-08-09 11:24 ` Avi Kivity
2011-08-09 11:35 ` Christoffer Dall
2011-08-06 10:40 ` [PATCH v4 09/10] ARM: KVM: Handle I/O aborts Christoffer Dall
2011-08-09 11:34 ` Avi Kivity
2011-08-09 11:39 ` Christoffer Dall
2011-08-09 11:46 ` Avi Kivity
2011-08-06 10:40 ` [PATCH v4 10/10] ARM: KVM: Guest wait-for-interrupts (WFI) support Christoffer Dall
2011-08-09 11:43 ` [PATCH v4 00/10] KVM/ARM Implementation Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E411C02.6070008@redhat.com \
--to=avi@redhat.com \
--cc=android-virt@lists.cs.columbia.edu \
--cc=c.dall@virtualopensystems.com \
--cc=cdall@cs.columbia.edu \
--cc=kvm@vger.kernel.org \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.