Re: [PATCH v4 07/10] ARM: KVM: Emulation framework and CP15 emulation

[Avi Kivity <avi@redhat.com>]

On 08/09/2011 02:34 PM, Christoffer Dall wrote:
> >
> >>  +
> >>  +/**
> >>  + * emulate_cp15_c15_access -- emulates cp15 accesses for CRn == 15
> >>  + * @vcpu: The VCPU pointer
> >>  + * @p:    The coprocessor parameters struct pointer holding trap inst. details
> >>  + *
> >>  + * The CP15 c15 register is implementation defined, but some guest kernels
> >>  + * attempt to read/write a diagnostics register here. We always return 0 and
> >>  + * ignore writes and hope for the best. This may need to be refined.
> >>  + */
> >>  +static int emulate_cp15_c15_access(struct kvm_vcpu *vcpu,
> >>  +				   struct coproc_params *p)
> >>  +{
> >>  +	trace_kvm_emulate_cp15_imp(p->Op1, p->Rt1, p->CRn, p->CRm,
> >>  +				   p->Op2, p->is_write);
> >
> >  _imp?
>
> implementation defined co-processor 15 operations. Took me 10 minutes to dig out from memory, so, ok, this is not super informative or clear:) Will try to come up with something better or the right comment somewhere or something.
>

Ah, okay.  It's not related to the kvm implementation, it's 
architecturally implementation defined.

-- 
error compiling committee.c: too many arguments to function