All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
To: Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Cc: Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation
Date: Wed, 10 Aug 2011 15:24:33 +0400	[thread overview]
Message-ID: <4E426A71.1000100@ru.mvista.com> (raw)
In-Reply-To: <201108092308.11580.marvin24-Mmb7MZpHnFY@public.gmane.org>

Hello.

On 10-08-2011 1:08, Marc Dietrich wrote:

> These clocks are required for usb operation. pll_p_out4 needs to be set
> to 24 MHz. The other clocks default to "off" in order to safe some energy.

    s/safe/save/

    You didn't sign off on the patch.

> ---
>   arch/arm/mach-tegra/board-paz00.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-
> paz00.c
> index 45111f6..cde36dc 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -145,6 +145,12 @@ static __initdata struct tegra_clk_init_table
> paz00_clk_init_table[] = {
>   	/* name		parent		rate		enabled */
>   	{ "uarta",	"pll_p",	216000000,	true },
>   	{ "uartd",	"pll_p",	216000000,	true },
> +
> +	{ "pll_p_out4",	"pll_p",	24000000,	true },
> +	{ "usbd",	"clk_m",	12000000,	false },
> +	{ "usb2",	"clk_m",	12000000,	false },
> +	{ "usb3",	"clk_m",	12000000,	false },
> +
>   	{ NULL,		NULL,		0,		0},
>   };
>

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation
Date: Wed, 10 Aug 2011 15:24:33 +0400	[thread overview]
Message-ID: <4E426A71.1000100@ru.mvista.com> (raw)
In-Reply-To: <201108092308.11580.marvin24@gmx.de>

Hello.

On 10-08-2011 1:08, Marc Dietrich wrote:

> These clocks are required for usb operation. pll_p_out4 needs to be set
> to 24 MHz. The other clocks default to "off" in order to safe some energy.

    s/safe/save/

    You didn't sign off on the patch.

> ---
>   arch/arm/mach-tegra/board-paz00.c |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/mach-tegra/board-paz00.c b/arch/arm/mach-tegra/board-
> paz00.c
> index 45111f6..cde36dc 100644
> --- a/arch/arm/mach-tegra/board-paz00.c
> +++ b/arch/arm/mach-tegra/board-paz00.c
> @@ -145,6 +145,12 @@ static __initdata struct tegra_clk_init_table
> paz00_clk_init_table[] = {
>   	/* name		parent		rate		enabled */
>   	{ "uarta",	"pll_p",	216000000,	true },
>   	{ "uartd",	"pll_p",	216000000,	true },
> +
> +	{ "pll_p_out4",	"pll_p",	24000000,	true },
> +	{ "usbd",	"clk_m",	12000000,	false },
> +	{ "usb2",	"clk_m",	12000000,	false },
> +	{ "usb3",	"clk_m",	12000000,	false },
> +
>   	{ NULL,		NULL,		0,		0},
>   };
>

WBR, Sergei

  parent reply	other threads:[~2011-08-10 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-09 21:08 [PATCH V3] ARM: tegra: paz00: add clocks required for usb operation Marc Dietrich
2011-08-09 21:08 ` Marc Dietrich
     [not found] ` <201108092308.11580.marvin24-Mmb7MZpHnFY@public.gmane.org>
2011-08-10 11:24   ` Sergei Shtylyov [this message]
2011-08-10 11:24     ` Sergei Shtylyov
     [not found]     ` <4E426A71.1000100-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2011-08-10 11:31       ` Marc Dietich
2011-08-10 11:31         ` Marc Dietich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E426A71.1000100@ru.mvista.com \
    --to=sshtylyov-igf4poytycdqt0dzr+alfa@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.