From: Wolfgang Grandegger <wg@grandegger.com>
To: Robin Holt <holt@sgi.com>
Cc: netdev@vger.kernel.org, U Bhaskar-B22300 <B22300@freescale.com>,
socketcan-core@lists.berlios.de,
Scott Wood <scottwood@freescale.com>,
PPC list <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 16:41:03 +0200 [thread overview]
Message-ID: <4E42987F.9040304@grandegger.com> (raw)
In-Reply-To: <20110810141550.GQ4926@sgi.com>
On 08/10/2011 04:15 PM, Robin Holt wrote:
> On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:
...
> Done, except the
>> compatible = "fsl,p1010-flexcan", "fsl,flexcan";
>
> line is
> compatible = "fsl,flexcan", "fsl,flexcan-p1010";
IIRC, there order is more to less specific, e.g. for I2C:
compatible = "fsl,mpc5200-i2c", "fsl-i2c"
...
>> Please also correct the node names (not using the number suffix).
>
> So the node names should be
> can@1c000 {
> can@1d000 {
> correct?
Yes, just have a look how other node names are constructed, e.g. for
sata, serial, rtc, etc.:
$ grep serial@ *.dts
...
pdm360ng.dts: serial@11000 {
pdm360ng.dts: serial@11100 {
pdm360ng.dts: serial@11200 {
pdm360ng.dts: serial@11300 {
pdm360ng.dts: serial@11400 {
pdm360ng.dts: serial@11600 {
pdm360ng.dts: serial@11800 {
pdm360ng.dts: serial@11B00 {
...
Wolfgang.
WARNING: multiple messages have this Message-ID (diff)
From: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
To: Robin Holt <holt-sJ/iWh9BUns@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
U Bhaskar-B22300 <B22300-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Kumar Gala
<galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
PPC list <linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>
Subject: Re: [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding.
Date: Wed, 10 Aug 2011 16:41:03 +0200 [thread overview]
Message-ID: <4E42987F.9040304@grandegger.com> (raw)
In-Reply-To: <20110810141550.GQ4926-sJ/iWh9BUns@public.gmane.org>
On 08/10/2011 04:15 PM, Robin Holt wrote:
> On Wed, Aug 10, 2011 at 03:47:43PM +0200, Wolfgang Grandegger wrote:
...
> Done, except the
>> compatible = "fsl,p1010-flexcan", "fsl,flexcan";
>
> line is
> compatible = "fsl,flexcan", "fsl,flexcan-p1010";
IIRC, there order is more to less specific, e.g. for I2C:
compatible = "fsl,mpc5200-i2c", "fsl-i2c"
...
>> Please also correct the node names (not using the number suffix).
>
> So the node names should be
> can@1c000 {
> can@1d000 {
> correct?
Yes, just have a look how other node names are constructed, e.g. for
sata, serial, rtc, etc.:
$ grep serial@ *.dts
...
pdm360ng.dts: serial@11000 {
pdm360ng.dts: serial@11100 {
pdm360ng.dts: serial@11200 {
pdm360ng.dts: serial@11300 {
pdm360ng.dts: serial@11400 {
pdm360ng.dts: serial@11600 {
pdm360ng.dts: serial@11800 {
pdm360ng.dts: serial@11B00 {
...
Wolfgang.
next prev parent reply other threads:[~2011-08-10 14:41 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 3:05 [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Robin Holt
2011-08-10 3:05 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 1/5] [flexcan] Remove #include <mach/clock.h> Robin Holt
2011-08-10 3:06 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 2/5] [flexcan] Abstract off read/write for big/little endian Robin Holt
2011-08-10 3:06 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 3/5] [flexcan] Add of_match to platform_device definition Robin Holt
2011-08-10 3:06 ` Robin Holt
2011-08-10 14:33 ` Robin Holt
2011-08-10 14:33 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 4/5] [powerpc] Add flexcan device support for p1010rdb Robin Holt
2011-08-10 3:06 ` Robin Holt
2011-08-10 9:56 ` Marc Kleine-Budde
2011-08-10 9:56 ` Marc Kleine-Budde
2011-08-10 10:15 ` Robin Holt
2011-08-10 10:15 ` Robin Holt
2011-08-10 3:06 ` [PATCH v10 5/5] [powerpc] Fix up fsl-flexcan device tree binding Robin Holt
2011-08-10 3:06 ` Robin Holt
2011-08-10 8:15 ` Robert Schwebel
2011-08-10 8:15 ` Robert Schwebel
2011-08-10 10:09 ` Robin Holt
2011-08-10 10:09 ` Robin Holt
2011-08-10 13:47 ` Wolfgang Grandegger
2011-08-10 13:47 ` Wolfgang Grandegger
2011-08-10 14:15 ` Robin Holt
2011-08-10 14:15 ` Robin Holt
2011-08-10 14:36 ` U Bhaskar-B22300
2011-08-10 14:36 ` U Bhaskar-B22300
2011-08-10 16:00 ` Robin Holt
2011-08-10 16:00 ` Robin Holt
2011-08-10 16:53 ` Kumar Gala
2011-08-10 16:53 ` Kumar Gala
2011-08-10 17:16 ` Robin Holt
2011-08-10 17:16 ` Robin Holt
2011-08-10 17:17 ` Kumar Gala
2011-08-10 17:17 ` Kumar Gala
2011-08-10 17:20 ` Robin Holt
2011-08-10 17:20 ` Robin Holt
2011-08-10 17:26 ` Kumar Gala
2011-08-10 17:26 ` Kumar Gala
2011-08-10 18:23 ` Wolfgang Grandegger
2011-08-10 18:23 ` Wolfgang Grandegger
2011-08-10 18:27 ` Scott Wood
2011-08-10 18:27 ` Scott Wood
2011-08-10 18:35 ` Robin Holt
2011-08-10 18:35 ` Robin Holt
2011-08-10 18:39 ` Scott Wood
2011-08-10 18:39 ` Scott Wood
2011-08-10 14:41 ` Wolfgang Grandegger [this message]
2011-08-10 14:41 ` Wolfgang Grandegger
2011-08-10 14:46 ` Kumar Gala
2011-08-10 14:46 ` Kumar Gala
2011-08-10 14:45 ` Kumar Gala
2011-08-10 14:45 ` Kumar Gala
2011-08-10 15:35 ` Robin Holt
2011-08-10 15:35 ` Robin Holt
2011-08-10 10:01 ` [PATCH v10 0/5] [flexcan/powerpc] Add support for powerpc flexcan (freescale p1010) Marc Kleine-Budde
2011-08-10 10:01 ` Marc Kleine-Budde
2011-08-10 10:11 ` Robin Holt
2011-08-10 10:11 ` Robin Holt
2011-08-10 10:24 ` Marc Kleine-Budde
2011-08-10 10:24 ` Marc Kleine-Budde
2011-08-10 11:09 ` Marc Kleine-Budde
2011-08-10 11:09 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E42987F.9040304@grandegger.com \
--to=wg@grandegger.com \
--cc=B22300@freescale.com \
--cc=holt@sgi.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=socketcan-core@lists.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.