* Unable to Compile Latest Kernel from Git
@ 2011-08-06 1:58 Billy Hass
[not found] ` <CALPVbefsY4Ddw6QOZu9BckCx+Q0YJg8tgbjK6xN5sQxbpdD16w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Billy Hass @ 2011-08-06 1:58 UTC (permalink / raw)
To: linux-nfs
Hey all,
I am unable to compile the latest kernel from the git tree.
git clone git://git.linux-nfs.org/projects/bhalevy/linux-pnfs.git
cd linux-pnfs
make oldconfig
make -j5 -s
=A0=A0=A0=A0 [ ... ]
=A0=A0=A0=A0 [A lot of warnings, but no errors]
=A0=A0=A0=A0 [ ... ]
make install
=A0=A0=A0=A0 sh /usr/src/kernels/3.0.0/linux-
pnfs/arch/x86/boot/install.sh 3.0.0-pnfs arch/x86/boot/bzImage \
=A0=A0 =A0 =A0 =A0 System.map "/boot"
=A0 =A0 =A0 *** Missing file: arch/x86/boot/bzImage
=A0=A0=A0=A0=A0 *** You need to run "make" before "make install".
=A0=A0=A0=A0 make[1]: *** [install] Error 1
=A0=A0=A0=A0 make: *** [install] Error 2
When I try to do the make again, here is the output
make -j5 -s
=A0=A0=A0=A0 fs/nfsd/built-in.o: In function `pnfs_roc':
=A0=A0=A0=A0 (.text+0x226d1): multiple definition of `pnfs_roc'
=A0=A0=A0=A0 fs/nfs/built-in.o:(.text+0x304ee): first defined here
=A0=A0=A0=A0 make[1]: *** [fs/built-in.o] Error 1
=A0=A0=A0=A0 make: *** [fs] Error 2
=A0=A0=A0=A0 make: *** Waiting for unfinished jobs....
Thanks for any help!
Bill
--
Bill D. Hass
Major | Electrical Engineering BSE
Minor | Mathematics
University of Michigan '13
College of Engineering
(715) 923-8382
^ permalink raw reply [flat|nested] 11+ messages in thread[parent not found: <CALPVbefsY4Ddw6QOZu9BckCx+Q0YJg8tgbjK6xN5sQxbpdD16w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Unable to Compile Latest Kernel from Git [not found] ` <CALPVbefsY4Ddw6QOZu9BckCx+Q0YJg8tgbjK6xN5sQxbpdD16w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-08-08 19:01 ` Olga Kornievskaia 2011-08-09 8:52 ` Benny Halevy 0 siblings, 1 reply; 11+ messages in thread From: Olga Kornievskaia @ 2011-08-08 19:01 UTC (permalink / raw) To: Billy Hass; +Cc: linux-nfs I'd like to 2nd this. Current pnfs server doesn't build if chosen to be build into the kernel. It does build, if built as a module. when client and server code is build into the kernel it seems that both sides try to define pnfs_roc() function and stepping on each others toes.. On Fri, Aug 5, 2011 at 9:58 PM, Billy Hass <billdh16@gmail.com> wrote: > Hey all, > > I am unable to compile the latest kernel from the git tree. > > git clone git://git.linux-nfs.org/projects/bhalevy/linux-pnfs.git > cd linux-pnfs > make oldconfig > make -j5 -s > =A0=A0=A0=A0 [ ... ] > =A0=A0=A0=A0 [A lot of warnings, but no errors] > =A0=A0=A0=A0 [ ... ] > make install > =A0=A0=A0=A0 sh /usr/src/kernels/3.0.0/linux- > =A0 =A0 pnfs/arch/x86/boot/install.sh 3.0.0-pnfs arch/x86/boot/bzImag= e \ > =A0=A0 =A0 =A0 =A0 System.map "/boot" > =A0 =A0 =A0 *** Missing file: arch/x86/boot/bzImage > =A0=A0=A0=A0=A0 *** You need to run "make" before "make install". > =A0=A0=A0=A0 make[1]: *** [install] Error 1 > =A0=A0=A0=A0 make: *** [install] Error 2 > > When I try to do the make again, here is the output > make -j5 -s > =A0=A0=A0=A0 fs/nfsd/built-in.o: In function `pnfs_roc': > =A0=A0=A0=A0 (.text+0x226d1): multiple definition of `pnfs_roc' > =A0=A0=A0=A0 fs/nfs/built-in.o:(.text+0x304ee): first defined here > =A0=A0=A0=A0 make[1]: *** [fs/built-in.o] Error 1 > =A0=A0=A0=A0 make: *** [fs] Error 2 > =A0=A0=A0=A0 make: *** Waiting for unfinished jobs.... > > Thanks for any help! > > Bill > > -- > Bill D. Hass > Major | Electrical Engineering BSE > Minor | Mathematics > University of Michigan '13 > College of Engineering > (715) 923-8382 > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git 2011-08-08 19:01 ` Olga Kornievskaia @ 2011-08-09 8:52 ` Benny Halevy 2011-08-10 17:29 ` Billy Hass 0 siblings, 1 reply; 11+ messages in thread From: Benny Halevy @ 2011-08-09 8:52 UTC (permalink / raw) To: Olga Kornievskaia; +Cc: Billy Hass, linux-nfs On 2011-08-08 15:01, Olga Kornievskaia wrote: > I'd like to 2nd this. > > Current pnfs server doesn't build if chosen to be build into the > kernel. It does build, if built as a module. > > when client and server code is build into the kernel it seems that > both sides try to define pnfs_roc() function and stepping on each > others toes.. > > On Fri, Aug 5, 2011 at 9:58 PM, Billy Hass <billdh16@gmail.com> wrote: >> Hey all, >> >> I am unable to compile the latest kernel from the git tree. >> >> git clone git://git.linux-nfs.org/projects/bhalevy/linux-pnfs.git >> cd linux-pnfs >> make oldconfig >> make -j5 -s >> [ ... ] >> [A lot of warnings, but no errors] >> [ ... ] >> make install >> sh /usr/src/kernels/3.0.0/linux- >> pnfs/arch/x86/boot/install.sh 3.0.0-pnfs arch/x86/boot/bzImage \ >> System.map "/boot" >> *** Missing file: arch/x86/boot/bzImage >> *** You need to run "make" before "make install". >> make[1]: *** [install] Error 1 >> make: *** [install] Error 2 >> >> When I try to do the make again, here is the output >> make -j5 -s >> fs/nfsd/built-in.o: In function `pnfs_roc': >> (.text+0x226d1): multiple definition of `pnfs_roc' >> fs/nfs/built-in.o:(.text+0x304ee): first defined here >> make[1]: *** [fs/built-in.o] Error 1 >> make: *** [fs] Error 2 >> make: *** Waiting for unfinished jobs.... >> >> Thanks for any help! >> >> Bill >> >> -- >> Bill D. Hass >> Major | Electrical Engineering BSE >> Minor | Mathematics >> University of Michigan '13 >> College of Engineering >> (715) 923-8382 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Right. The following patch simply renames the function for pnfsd. I'm pushing it to pnfs-all-3.0 and I'll add it to the 3.1-rc tree (pnfs-all-latest) once I finish rebasing and testing it. Benny >From d76f73eca38fd7b803d80e78cfa8f9468e83a9b3 Mon Sep 17 00:00:00 2001 From: Benny Halevy <benny@tonian.com> Date: Tue, 9 Aug 2011 01:11:16 -0400 Subject: [PATCH] SQUASHME: pnfsd: rename pnfs_roc to pnfsd_roc It clashes with a function called the same in the nfs module Signed-off-by: Benny Halevy <benny@tonian.com> --- fs/nfsd/nfs4pnfsd.c | 2 +- fs/nfsd/nfs4state.c | 2 +- fs/nfsd/pnfsd.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c index b1f67eb..e0669ad 100644 --- a/fs/nfsd/nfs4pnfsd.c +++ b/fs/nfsd/nfs4pnfsd.c @@ -1336,7 +1336,7 @@ nomatching_layout(struct nfs4_layoutrecall *clr) * the layout and simulate a layout_return. Surly the client has forgotten * these layouts or it would return them before the close. */ -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp) +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp) { struct nfs4_layout *lo, *nextlp; diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index 1941051..b95589e 100644 --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -3620,7 +3620,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, update_stateid(&stp->st_stateid); memcpy(&close->cl_stateid, &stp->st_stateid, sizeof(stateid_t)); - pnfs_roc(stp->st_stateowner->so_client, stp->st_file); + pnfsd_roc(stp->st_stateowner->so_client, stp->st_file); /* release_stateid() calls nfsd_close() if needed */ release_open_stateid(stp); diff --git a/fs/nfsd/pnfsd.h b/fs/nfsd/pnfsd.h index a4c8a9c..6e60d2c 100644 --- a/fs/nfsd/pnfsd.h +++ b/fs/nfsd/pnfsd.h @@ -125,7 +125,7 @@ int nfs4_pnfs_cb_change_state(struct pnfs_get_state *); void nfs4_ds_get_verifier(stateid_t *, struct super_block *, u32 *); int put_layoutrecall(struct nfs4_layoutrecall *); void nomatching_layout(struct nfs4_layoutrecall *); -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp); +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp); void *layoutrecall_done(struct nfs4_layoutrecall *); void nfsd4_cb_layout(struct nfs4_layoutrecall *); int _nfsd_layout_recall_cb(struct super_block *, struct inode *, -- 1.7.6 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git 2011-08-09 8:52 ` Benny Halevy @ 2011-08-10 17:29 ` Billy Hass [not found] ` <CALPVbedY4WV=Bsqr8Z0JUeYgrgVGLFc-NYdxJfewUAO0bJpR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Billy Hass @ 2011-08-10 17:29 UTC (permalink / raw) To: Benny Halevy; +Cc: Olga Kornievskaia, linux-nfs On Tue, Aug 9, 2011 at 4:52 AM, Benny Halevy <bhalevy@tonian.com> wrote= : > On 2011-08-08 15:01, Olga Kornievskaia wrote: >> I'd like to 2nd this. >> >> Current pnfs server doesn't build if chosen to be build into the >> kernel. It does build, if built as a module. >> >> when client and server code is build into the kernel it seems that >> both sides try to define pnfs_roc() function and stepping on each >> others toes.. >> >> On Fri, Aug 5, 2011 at 9:58 PM, Billy Hass <billdh16@gmail.com> wrot= e: >>> Hey all, >>> >>> I am unable to compile the latest kernel from the git tree. >>> >>> git clone git://git.linux-nfs.org/projects/bhalevy/linux-pnfs.git >>> cd linux-pnfs >>> make oldconfig >>> make -j5 -s >>> =A0 =A0 =A0[ ... ] >>> =A0 =A0 =A0[A lot of warnings, but no errors] >>> =A0 =A0 =A0[ ... ] >>> make install >>> =A0 =A0 =A0sh /usr/src/kernels/3.0.0/linux- >>> =A0 =A0 pnfs/arch/x86/boot/install.sh 3.0.0-pnfs arch/x86/boot/bzIm= age \ >>> =A0 =A0 =A0 =A0 =A0System.map "/boot" >>> =A0 =A0 =A0 *** Missing file: arch/x86/boot/bzImage >>> =A0 =A0 =A0 *** You need to run "make" before "make install". >>> =A0 =A0 =A0make[1]: *** [install] Error 1 >>> =A0 =A0 =A0make: *** [install] Error 2 >>> >>> When I try to do the make again, here is the output >>> make -j5 -s >>> =A0 =A0 =A0fs/nfsd/built-in.o: In function `pnfs_roc': >>> =A0 =A0 =A0(.text+0x226d1): multiple definition of `pnfs_roc' >>> =A0 =A0 =A0fs/nfs/built-in.o:(.text+0x304ee): first defined here >>> =A0 =A0 =A0make[1]: *** [fs/built-in.o] Error 1 >>> =A0 =A0 =A0make: *** [fs] Error 2 >>> =A0 =A0 =A0make: *** Waiting for unfinished jobs.... >>> >>> Thanks for any help! >>> >>> Bill >>> >>> -- >>> Bill D. Hass >>> Major | Electrical Engineering BSE >>> Minor | Mathematics >>> University of Michigan '13 >>> College of Engineering >>> (715) 923-8382 >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs= " in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at =A0http://vger.kernel.org/majordomo-info.htm= l >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs"= in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at =A0http://vger.kernel.org/majordomo-info.html > > Right. =A0The following patch simply renames the function for pnfsd. > I'm pushing it to pnfs-all-3.0 and I'll add it to the 3.1-rc tree > (pnfs-all-latest) once I finish rebasing and testing it. > > Benny > > From d76f73eca38fd7b803d80e78cfa8f9468e83a9b3 Mon Sep 17 00:00:00 200= 1 > From: Benny Halevy <benny@tonian.com> > Date: Tue, 9 Aug 2011 01:11:16 -0400 > Subject: [PATCH] SQUASHME: pnfsd: rename pnfs_roc to pnfsd_roc > > It clashes with a function called the same in the nfs module > > Signed-off-by: Benny Halevy <benny@tonian.com> > --- > =A0fs/nfsd/nfs4pnfsd.c | =A0 =A02 +- > =A0fs/nfsd/nfs4state.c | =A0 =A02 +- > =A0fs/nfsd/pnfsd.h =A0 =A0 | =A0 =A02 +- > =A03 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c > index b1f67eb..e0669ad 100644 > --- a/fs/nfsd/nfs4pnfsd.c > +++ b/fs/nfsd/nfs4pnfsd.c > @@ -1336,7 +1336,7 @@ nomatching_layout(struct nfs4_layoutrecall *clr= ) > =A0* =A0 the layout and simulate a layout_return. Surly the client ha= s forgotten > =A0* =A0 these layouts or it would return them before the close. > =A0*/ > -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp) > +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp) > =A0{ > =A0 =A0 =A0 =A0struct nfs4_layout *lo, *nextlp; > > diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c > index 1941051..b95589e 100644 > --- a/fs/nfsd/nfs4state.c > +++ b/fs/nfsd/nfs4state.c > @@ -3620,7 +3620,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfsd= 4_compound_state *cstate, > =A0 =A0 =A0 =A0update_stateid(&stp->st_stateid); > =A0 =A0 =A0 =A0memcpy(&close->cl_stateid, &stp->st_stateid, sizeof(st= ateid_t)); > > - =A0 =A0 =A0 pnfs_roc(stp->st_stateowner->so_client, stp->st_file); > + =A0 =A0 =A0 pnfsd_roc(stp->st_stateowner->so_client, stp->st_file); > > =A0 =A0 =A0 =A0/* release_stateid() calls nfsd_close() if needed */ > =A0 =A0 =A0 =A0release_open_stateid(stp); > diff --git a/fs/nfsd/pnfsd.h b/fs/nfsd/pnfsd.h > index a4c8a9c..6e60d2c 100644 > --- a/fs/nfsd/pnfsd.h > +++ b/fs/nfsd/pnfsd.h > @@ -125,7 +125,7 @@ int nfs4_pnfs_cb_change_state(struct pnfs_get_sta= te *); > =A0void nfs4_ds_get_verifier(stateid_t *, struct super_block *, u32 *= ); > =A0int put_layoutrecall(struct nfs4_layoutrecall *); > =A0void nomatching_layout(struct nfs4_layoutrecall *); > -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp); > +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp); > =A0void *layoutrecall_done(struct nfs4_layoutrecall *); > =A0void nfsd4_cb_layout(struct nfs4_layoutrecall *); > =A0int _nfsd_layout_recall_cb(struct super_block *, struct inode *, > -- > 1.7.6 > > I updated to the latest git today and I am still having trouble compili= ng. [root@pdsi8 linux-pnfs]# make -j5 -s [...] drivers/isdn/hardware/mISDN/hfcpci.c:2319:2: warning: ignoring return value of =91driver_for_each_device=92, declared with attribute warn_unused_result [-Wunused-result] drivers/isdn/hardware/eicon/message.c: In function =91mixer_notify_upda= te=92: drivers/isdn/hardware/eicon/message.c:11308:54: warning: array subscript is above array bounds [-Warray-bounds] fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 make[1]: *** [fs/xfs] Error 2 make: *** [fs] Error 2 make: *** Waiting for unfinished jobs.... In file included from drivers/message/i2o/config-osm.c:39:0: drivers/message/i2o/i2o_config.c: In function =91i2o_cfg_passthru=92: [...] [root@pdsi8 linux-pnfs]# make modules && make modules_install && make i= nstall CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CC [M] fs/xfs/linux-2.6/xfs_iops.o fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 make[1]: *** [fs/xfs] Error 2 make: *** [fs] Error 2 Here is my second make after a failed make: [root@pdsi8 linux-pnfs]# make -j5 -s fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 make[1]: *** [fs/xfs] Error 2 make: *** [fs] Error 2 make: *** Waiting for unfinished jobs.... --=20 Bill D. Hass Major | Electrical Engineering BSE Minor | Mathematics University of Michigan '13 College of Engineering (715) 923-8382 ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CALPVbedY4WV=Bsqr8Z0JUeYgrgVGLFc-NYdxJfewUAO0bJpR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Unable to Compile Latest Kernel from Git [not found] ` <CALPVbedY4WV=Bsqr8Z0JUeYgrgVGLFc-NYdxJfewUAO0bJpR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-08-10 18:11 ` Bryan Schumaker 2011-08-10 18:29 ` Boaz Harrosh 0 siblings, 1 reply; 11+ messages in thread From: Bryan Schumaker @ 2011-08-10 18:11 UTC (permalink / raw) To: Billy Hass; +Cc: Benny Halevy, Olga Kornievskaia, linux-nfs On 08/10/2011 01:29 PM, Billy Hass wrote: > On Tue, Aug 9, 2011 at 4:52 AM, Benny Halevy <bhalevy@tonian.com> wro= te: >> On 2011-08-08 15:01, Olga Kornievskaia wrote: >>> I'd like to 2nd this. >>> >>> Current pnfs server doesn't build if chosen to be build into the >>> kernel. It does build, if built as a module. >>> >>> when client and server code is build into the kernel it seems that >>> both sides try to define pnfs_roc() function and stepping on each >>> others toes.. >>> >>> On Fri, Aug 5, 2011 at 9:58 PM, Billy Hass <billdh16@gmail.com> wro= te: >>>> Hey all, >>>> >>>> I am unable to compile the latest kernel from the git tree. >>>> >>>> git clone git://git.linux-nfs.org/projects/bhalevy/linux-pnfs.git >>>> cd linux-pnfs >>>> make oldconfig >>>> make -j5 -s >>>> [ ... ] >>>> [A lot of warnings, but no errors] >>>> [ ... ] >>>> make install >>>> sh /usr/src/kernels/3.0.0/linux- >>>> pnfs/arch/x86/boot/install.sh 3.0.0-pnfs arch/x86/boot/bzImage= \ >>>> System.map "/boot" >>>> *** Missing file: arch/x86/boot/bzImage >>>> *** You need to run "make" before "make install". >>>> make[1]: *** [install] Error 1 >>>> make: *** [install] Error 2 >>>> >>>> When I try to do the make again, here is the output >>>> make -j5 -s >>>> fs/nfsd/built-in.o: In function `pnfs_roc': >>>> (.text+0x226d1): multiple definition of `pnfs_roc' >>>> fs/nfs/built-in.o:(.text+0x304ee): first defined here >>>> make[1]: *** [fs/built-in.o] Error 1 >>>> make: *** [fs] Error 2 >>>> make: *** Waiting for unfinished jobs.... >>>> >>>> Thanks for any help! >>>> >>>> Bill >>>> >>>> -- >>>> Bill D. Hass >>>> Major | Electrical Engineering BSE >>>> Minor | Mathematics >>>> University of Michigan '13 >>>> College of Engineering >>>> (715) 923-8382 >>>> -- >>>> To unsubscribe from this list: send the line "unsubscribe linux-nf= s" in >>>> the body of a message to majordomo@vger.kernel.org >>>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs= " in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> Right. The following patch simply renames the function for pnfsd. >> I'm pushing it to pnfs-all-3.0 and I'll add it to the 3.1-rc tree >> (pnfs-all-latest) once I finish rebasing and testing it. >> >> Benny >> >> From d76f73eca38fd7b803d80e78cfa8f9468e83a9b3 Mon Sep 17 00:00:00 20= 01 >> From: Benny Halevy <benny@tonian.com> >> Date: Tue, 9 Aug 2011 01:11:16 -0400 >> Subject: [PATCH] SQUASHME: pnfsd: rename pnfs_roc to pnfsd_roc >> >> It clashes with a function called the same in the nfs module >> >> Signed-off-by: Benny Halevy <benny@tonian.com> >> --- >> fs/nfsd/nfs4pnfsd.c | 2 +- >> fs/nfsd/nfs4state.c | 2 +- >> fs/nfsd/pnfsd.h | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/fs/nfsd/nfs4pnfsd.c b/fs/nfsd/nfs4pnfsd.c >> index b1f67eb..e0669ad 100644 >> --- a/fs/nfsd/nfs4pnfsd.c >> +++ b/fs/nfsd/nfs4pnfsd.c >> @@ -1336,7 +1336,7 @@ nomatching_layout(struct nfs4_layoutrecall *cl= r) >> * the layout and simulate a layout_return. Surly the client has f= orgotten >> * these layouts or it would return them before the close. >> */ >> -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp) >> +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp) >> { >> struct nfs4_layout *lo, *nextlp; >> >> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c >> index 1941051..b95589e 100644 >> --- a/fs/nfsd/nfs4state.c >> +++ b/fs/nfsd/nfs4state.c >> @@ -3620,7 +3620,7 @@ nfsd4_close(struct svc_rqst *rqstp, struct nfs= d4_compound_state *cstate, >> update_stateid(&stp->st_stateid); >> memcpy(&close->cl_stateid, &stp->st_stateid, sizeof(stateid_t= )); >> >> - pnfs_roc(stp->st_stateowner->so_client, stp->st_file); >> + pnfsd_roc(stp->st_stateowner->so_client, stp->st_file); >> >> /* release_stateid() calls nfsd_close() if needed */ >> release_open_stateid(stp); >> diff --git a/fs/nfsd/pnfsd.h b/fs/nfsd/pnfsd.h >> index a4c8a9c..6e60d2c 100644 >> --- a/fs/nfsd/pnfsd.h >> +++ b/fs/nfsd/pnfsd.h >> @@ -125,7 +125,7 @@ int nfs4_pnfs_cb_change_state(struct pnfs_get_st= ate *); >> void nfs4_ds_get_verifier(stateid_t *, struct super_block *, u32 *)= ; >> int put_layoutrecall(struct nfs4_layoutrecall *); >> void nomatching_layout(struct nfs4_layoutrecall *); >> -void pnfs_roc(struct nfs4_client *clp, struct nfs4_file *fp); >> +void pnfsd_roc(struct nfs4_client *clp, struct nfs4_file *fp); >> void *layoutrecall_done(struct nfs4_layoutrecall *); >> void nfsd4_cb_layout(struct nfs4_layoutrecall *); >> int _nfsd_layout_recall_cb(struct super_block *, struct inode *, >> -- >> 1.7.6 >> >> >=20 > I updated to the latest git today and I am still having trouble compi= ling. >=20 > [root@pdsi8 linux-pnfs]# make -j5 -s > [...] > drivers/isdn/hardware/mISDN/hfcpci.c:2319:2: warning: ignoring return > value of =91driver_for_each_device=92, declared with attribute > warn_unused_result [-Wunused-result] > drivers/isdn/hardware/eicon/message.c: In function =91mixer_notify_up= date=92: > drivers/isdn/hardware/eicon/message.c:11308:54: warning: array > subscript is above array bounds [-Warray-bounds] > fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: > fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of > function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] > cc1: some warnings being treated as errors > make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 > make[1]: *** [fs/xfs] Error 2 > make: *** [fs] Error 2 > make: *** Waiting for unfinished jobs.... > In file included from drivers/message/i2o/config-osm.c:39:0: > drivers/message/i2o/i2o_config.c: In function =91i2o_cfg_passthru=92: > [...] >=20 > [root@pdsi8 linux-pnfs]# make modules && make modules_install && make= install > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CC [M] fs/xfs/linux-2.6/xfs_iops.o > fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: > fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of > function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] > cc1: some warnings being treated as errors > make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 > make[1]: *** [fs/xfs] Error 2 > make: *** [fs] Error 2 This looks like an XFS problem now... did you see if any of the NFS cod= e compiled this time? I've had these issues before, and it's usually caused by something in m= y .config. Generating a new one usually fixes it for me. - Bryan >=20 > Here is my second make after a failed make: > [root@pdsi8 linux-pnfs]# make -j5 -s > fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: > fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of > function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration] > cc1: some warnings being treated as errors > make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 > make[1]: *** [fs/xfs] Error 2 > make: *** [fs] Error 2 > make: *** Waiting for unfinished jobs.... >=20 >=20 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git 2011-08-10 18:11 ` Bryan Schumaker @ 2011-08-10 18:29 ` Boaz Harrosh 0 siblings, 0 replies; 11+ messages in thread From: Boaz Harrosh @ 2011-08-10 18:29 UTC (permalink / raw) To: Bryan Schumaker Cc: Billy Hass, Benny Halevy, Olga Kornievskaia, linux-nfs, linux-fsdevel On 08/10/2011 11:11 AM, Bryan Schumaker wrote: > On 08/10/2011 01:29 PM, Billy Hass wrote: >> [root@pdsi8 linux-pnfs]# make modules && make modules_install && mak= e install >> CHK include/linux/version.h >> CHK include/generated/utsrelease.h >> CALL scripts/checksyscalls.sh >> CC [M] fs/xfs/linux-2.6/xfs_iops.o >> fs/xfs/linux-2.6/xfs_iops.c: In function =E2=80=98_xfs_vn_fallocate=E2= =80=99: >> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >> function =E2=80=98xfs_setattr=E2=80=99 [-Werror=3Dimplicit-function-= declaration] >> cc1: some warnings being treated as errors >> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >> make[1]: *** [fs/xfs] Error 2 >> make: *** [fs] Error 2 >=20 > This looks like an XFS problem now... did you see if any of the NFS c= ode compiled this time? >=20 > I've had these issues before, and it's usually caused by something in= my .config. Generating a new one usually fixes it for me. >=20 > - Bryan >=20 Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure the= xfs guys would like to fix it. Send this report with an attached .config file to: linux-fsdevel <linux-fsdevel@vger.kernel.org> Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git @ 2011-08-10 18:29 ` Boaz Harrosh 0 siblings, 0 replies; 11+ messages in thread From: Boaz Harrosh @ 2011-08-10 18:29 UTC (permalink / raw) To: Bryan Schumaker Cc: Billy Hass, Benny Halevy, Olga Kornievskaia, linux-nfs, linux-fsdevel On 08/10/2011 11:11 AM, Bryan Schumaker wrote: > On 08/10/2011 01:29 PM, Billy Hass wrote: >> [root@pdsi8 linux-pnfs]# make modules && make modules_install && make install >> CHK include/linux/version.h >> CHK include/generated/utsrelease.h >> CALL scripts/checksyscalls.sh >> CC [M] fs/xfs/linux-2.6/xfs_iops.o >> fs/xfs/linux-2.6/xfs_iops.c: In function ‘_xfs_vn_fallocate’: >> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >> function ‘xfs_setattr’ [-Werror=implicit-function-declaration] >> cc1: some warnings being treated as errors >> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >> make[1]: *** [fs/xfs] Error 2 >> make: *** [fs] Error 2 > > This looks like an XFS problem now... did you see if any of the NFS code compiled this time? > > I've had these issues before, and it's usually caused by something in my .config. Generating a new one usually fixes it for me. > > - Bryan > Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure the xfs guys would like to fix it. Send this report with an attached .config file to: linux-fsdevel <linux-fsdevel@vger.kernel.org> Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git @ 2011-08-10 19:05 ` Billy Hass 0 siblings, 0 replies; 11+ messages in thread From: Billy Hass @ 2011-08-10 19:05 UTC (permalink / raw) To: Boaz Harrosh Cc: Bryan Schumaker, Benny Halevy, Olga Kornievskaia, linux-nfs, linux-fsdevel On Wed, Aug 10, 2011 at 2:29 PM, Boaz Harrosh <bharrosh@panasas.com> wr= ote: > On 08/10/2011 11:11 AM, Bryan Schumaker wrote: >> On 08/10/2011 01:29 PM, Billy Hass wrote: >>> [root@pdsi8 linux-pnfs]# make modules && make modules_install && ma= ke install >>> =A0 CHK =A0 =A0 include/linux/version.h >>> =A0 CHK =A0 =A0 include/generated/utsrelease.h >>> =A0 CALL =A0 =A0scripts/checksyscalls.sh >>> =A0 CC [M] =A0fs/xfs/linux-2.6/xfs_iops.o >>> fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: >>> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >>> function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaration= ] >>> cc1: some warnings being treated as errors >>> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >>> make[1]: *** [fs/xfs] Error 2 >>> make: *** [fs] Error 2 >> >> This looks like an XFS problem now... did you see if any of the NFS = code compiled this time? >> >> I've had these issues before, and it's usually caused by something i= n my .config. =A0Generating a new one usually fixes it for me. >> >> - Bryan >> > > Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure t= he xfs guys > would like to fix it. > > Send this report with an attached .config file to: > =A0 =A0 =A0 =A0linux-fsdevel <linux-fsdevel@vger.kernel.org> > > Thanks > Boaz > I tried v3.1-rc1 and it compiled successfully. Thanks for the help. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git @ 2011-08-10 19:05 ` Billy Hass 0 siblings, 0 replies; 11+ messages in thread From: Billy Hass @ 2011-08-10 19:05 UTC (permalink / raw) To: Boaz Harrosh Cc: Bryan Schumaker, Benny Halevy, Olga Kornievskaia, linux-nfs-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel On Wed, Aug 10, 2011 at 2:29 PM, Boaz Harrosh <bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> wrote: > On 08/10/2011 11:11 AM, Bryan Schumaker wrote: >> On 08/10/2011 01:29 PM, Billy Hass wrote: >>> [root@pdsi8 linux-pnfs]# make modules && make modules_install && make install >>> CHK include/linux/version.h >>> CHK include/generated/utsrelease.h >>> CALL scripts/checksyscalls.sh >>> CC [M] fs/xfs/linux-2.6/xfs_iops.o >>> fs/xfs/linux-2.6/xfs_iops.c: In function ‘_xfs_vn_fallocate’: >>> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >>> function ‘xfs_setattr’ [-Werror=implicit-function-declaration] >>> cc1: some warnings being treated as errors >>> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >>> make[1]: *** [fs/xfs] Error 2 >>> make: *** [fs] Error 2 >> >> This looks like an XFS problem now... did you see if any of the NFS code compiled this time? >> >> I've had these issues before, and it's usually caused by something in my .config. Generating a new one usually fixes it for me. >> >> - Bryan >> > > Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure the xfs guys > would like to fix it. > > Send this report with an attached .config file to: > linux-fsdevel <linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> > > Thanks > Boaz > I tried v3.1-rc1 and it compiled successfully. Thanks for the help. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CALPVbecSxKKbzo_CQqb075cZhiD5kOG7Aao71=cwktK1dSU2Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: Unable to Compile Latest Kernel from Git [not found] ` <CALPVbecSxKKbzo_CQqb075cZhiD5kOG7Aao71=cwktK1dSU2Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2011-08-11 12:17 ` Benny Halevy 0 siblings, 0 replies; 11+ messages in thread From: Benny Halevy @ 2011-08-11 12:17 UTC (permalink / raw) To: Billy Hass Cc: Boaz Harrosh, Bryan Schumaker, Olga Kornievskaia, linux-nfs, linux-fsdevel On 2011-08-10 22:05, Billy Hass wrote: > On Wed, Aug 10, 2011 at 2:29 PM, Boaz Harrosh <bharrosh@panasas.com> = wrote: >> On 08/10/2011 11:11 AM, Bryan Schumaker wrote: >>> On 08/10/2011 01:29 PM, Billy Hass wrote: >>>> [root@pdsi8 linux-pnfs]# make modules && make modules_install && m= ake install >>>> CHK include/linux/version.h >>>> CHK include/generated/utsrelease.h >>>> CALL scripts/checksyscalls.sh >>>> CC [M] fs/xfs/linux-2.6/xfs_iops.o >>>> fs/xfs/linux-2.6/xfs_iops.c: In function =91_xfs_vn_fallocate=92: >>>> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >>>> function =91xfs_setattr=92 [-Werror=3Dimplicit-function-declaratio= n] >>>> cc1: some warnings being treated as errors >>>> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >>>> make[1]: *** [fs/xfs] Error 2 >>>> make: *** [fs] Error 2 >>> >>> This looks like an XFS problem now... did you see if any of the NFS= code compiled this time? >>> >>> I've had these issues before, and it's usually caused by something = in my .config. Generating a new one usually fixes it for me. >>> >>> - Bryan >>> >> >> Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure = the xfs guys >> would like to fix it. >> >> Send this report with an attached .config file to: >> linux-fsdevel <linux-fsdevel@vger.kernel.org> >> >> Thanks >> Boaz >> >=20 > I tried v3.1-rc1 and it compiled successfully. >=20 > Thanks for the help. > -- The problem was a bad merge/rebase on my side. Should be fixed now. Thanks for reporting! Benny ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: Unable to Compile Latest Kernel from Git @ 2011-08-11 12:17 ` Benny Halevy 0 siblings, 0 replies; 11+ messages in thread From: Benny Halevy @ 2011-08-11 12:17 UTC (permalink / raw) To: Billy Hass Cc: Boaz Harrosh, Bryan Schumaker, Olga Kornievskaia, linux-nfs-u79uwXL29TY76Z2rM5mHXA, linux-fsdevel On 2011-08-10 22:05, Billy Hass wrote: > On Wed, Aug 10, 2011 at 2:29 PM, Boaz Harrosh <bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org> wrote: >> On 08/10/2011 11:11 AM, Bryan Schumaker wrote: >>> On 08/10/2011 01:29 PM, Billy Hass wrote: >>>> [root@pdsi8 linux-pnfs]# make modules && make modules_install && make install >>>> CHK include/linux/version.h >>>> CHK include/generated/utsrelease.h >>>> CALL scripts/checksyscalls.sh >>>> CC [M] fs/xfs/linux-2.6/xfs_iops.o >>>> fs/xfs/linux-2.6/xfs_iops.c: In function ‘_xfs_vn_fallocate’: >>>> fs/xfs/linux-2.6/xfs_iops.c:1070:3: error: implicit declaration of >>>> function ‘xfs_setattr’ [-Werror=implicit-function-declaration] >>>> cc1: some warnings being treated as errors >>>> make[2]: *** [fs/xfs/linux-2.6/xfs_iops.o] Error 1 >>>> make[1]: *** [fs/xfs] Error 2 >>>> make: *** [fs] Error 2 >>> >>> This looks like an XFS problem now... did you see if any of the NFS code compiled this time? >>> >>> I've had these issues before, and it's usually caused by something in my .config. Generating a new one usually fixes it for me. >>> >>> - Bryan >>> >> >> Please try v3.1-rc1 (git checkout v3.1-rc1) if it persists I'm sure the xfs guys >> would like to fix it. >> >> Send this report with an attached .config file to: >> linux-fsdevel <linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> >> >> Thanks >> Boaz >> > > I tried v3.1-rc1 and it compiled successfully. > > Thanks for the help. > -- The problem was a bad merge/rebase on my side. Should be fixed now. Thanks for reporting! Benny -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-08-11 12:17 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-06 1:58 Unable to Compile Latest Kernel from Git Billy Hass
[not found] ` <CALPVbefsY4Ddw6QOZu9BckCx+Q0YJg8tgbjK6xN5sQxbpdD16w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-08 19:01 ` Olga Kornievskaia
2011-08-09 8:52 ` Benny Halevy
2011-08-10 17:29 ` Billy Hass
[not found] ` <CALPVbedY4WV=Bsqr8Z0JUeYgrgVGLFc-NYdxJfewUAO0bJpR8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-10 18:11 ` Bryan Schumaker
2011-08-10 18:29 ` Boaz Harrosh
2011-08-10 18:29 ` Boaz Harrosh
2011-08-10 19:05 ` Billy Hass
2011-08-10 19:05 ` Billy Hass
[not found] ` <CALPVbecSxKKbzo_CQqb075cZhiD5kOG7Aao71=cwktK1dSU2Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-08-11 12:17 ` Benny Halevy
2011-08-11 12:17 ` Benny Halevy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.