From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoC: Add missing break in WM8994 probe
Date: Wed, 10 Aug 2011 22:28:06 +0100 [thread overview]
Message-ID: <4E42F7E6.8050406@ti.com> (raw)
In-Reply-To: <1312982420-3486-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 10/08/11 14:20, Mark Brown wrote:
> This error would have no effect on current silicon revisions, the fall
> through case has the same behaviour.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8994.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
> index 1a9ef7f..e1fb844 100644
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -3042,6 +3042,7 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
> wm8994->hubs.dcs_readback_mode = 2;
> break;
> }
> + break;
>
> case WM8958:
> wm8994->hubs.dcs_readback_mode = 1;
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-08-10 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 13:20 [PATCH] ASoC: Add missing break in WM8994 probe Mark Brown
2011-08-10 21:28 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E42F7E6.8050406@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.