* [PATCH] ASoC: Add missing break in WM8994 probe
@ 2011-08-10 13:20 Mark Brown
2011-08-10 21:28 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-08-10 13:20 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
This error would have no effect on current silicon revisions, the fall
through case has the same behaviour.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8994.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 1a9ef7f..e1fb844 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -3042,6 +3042,7 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
wm8994->hubs.dcs_readback_mode = 2;
break;
}
+ break;
case WM8958:
wm8994->hubs.dcs_readback_mode = 1;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Add missing break in WM8994 probe
2011-08-10 13:20 [PATCH] ASoC: Add missing break in WM8994 probe Mark Brown
@ 2011-08-10 21:28 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-08-10 21:28 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
On 10/08/11 14:20, Mark Brown wrote:
> This error would have no effect on current silicon revisions, the fall
> through case has the same behaviour.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8994.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
> index 1a9ef7f..e1fb844 100644
> --- a/sound/soc/codecs/wm8994.c
> +++ b/sound/soc/codecs/wm8994.c
> @@ -3042,6 +3042,7 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec)
> wm8994->hubs.dcs_readback_mode = 2;
> break;
> }
> + break;
>
> case WM8958:
> wm8994->hubs.dcs_readback_mode = 1;
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-10 21:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-10 13:20 [PATCH] ASoC: Add missing break in WM8994 probe Mark Brown
2011-08-10 21:28 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.