All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raghavendra K T <raghukt@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	Arend van Spriel <arend@broadcom.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"David S. Miller" <davem@davemloft.net>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	Balbir Singh <bsingharora@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ying Han <yinghan@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg
Date: Thu, 11 Aug 2011 13:46:19 +0530	[thread overview]
Message-ID: <4E438FD3.7070000@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110811075337.GA8023@tiehlicka.suse.cz>

On 08/11/2011 01:23 PM, Michal Hocko wrote:
> On Wed 10-08-11 22:59:17, Raghavendra K T wrote:
>> Hi,
>>   This is the memcg cleanup patch for that was talked little ago to change the  "struct
>>   mem_cgroup *mem" variable to  "struct mem_cgroup *memcg".
>>
>>   The patch is though trivial, it is huge one.
>>   Testing : Compile tested with following configurations.
>>   1) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=y
>>   2) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
>>   3) CONFIG_CGROUP_MEM_RES_CTLR=n  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
>
> How exactly have you tested? Compiled and compared before/after binaries
> (it shouldn't change, right)?
Yes, But idea was to ensure that both #ifdef and #else part are hit 
during compilation, which could expose some corrections needed.
>
>>
>>   Also tested basic mounting with memcgroup.
>>   Raghu.
>
> Thanks


WARNING: multiple messages have this Message-ID (diff)
From: Raghavendra K T <raghukt@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
	Arend van Spriel <arend@broadcom.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	"David S. Miller" <davem@davemloft.net>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	Balbir Singh <bsingharora@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Mauro Carvalho Chehab <mchehab@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ying Han <yinghan@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg
Date: Thu, 11 Aug 2011 13:46:19 +0530	[thread overview]
Message-ID: <4E438FD3.7070000@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110811075337.GA8023@tiehlicka.suse.cz>

On 08/11/2011 01:23 PM, Michal Hocko wrote:
> On Wed 10-08-11 22:59:17, Raghavendra K T wrote:
>> Hi,
>>   This is the memcg cleanup patch for that was talked little ago to change the  "struct
>>   mem_cgroup *mem" variable to  "struct mem_cgroup *memcg".
>>
>>   The patch is though trivial, it is huge one.
>>   Testing : Compile tested with following configurations.
>>   1) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=y
>>   2) CONFIG_CGROUP_MEM_RES_CTLR=y  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
>>   3) CONFIG_CGROUP_MEM_RES_CTLR=n  CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
>
> How exactly have you tested? Compiled and compared before/after binaries
> (it shouldn't change, right)?
Yes, But idea was to ensure that both #ifdef and #else part are hit 
during compilation, which could expose some corrections needed.
>
>>
>>   Also tested basic mounting with memcgroup.
>>   Raghu.
>
> Thanks

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-08-11  8:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 17:29 [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg Raghavendra K T
2011-08-10 17:29 ` Raghavendra K T
2011-08-10 17:29 ` [PATCH 1/2][cleanup] " Raghavendra K T
2011-08-10 17:29   ` Raghavendra K T
2011-08-10 23:58   ` KAMEZAWA Hiroyuki
2011-08-10 23:58     ` KAMEZAWA Hiroyuki
2011-08-11  8:04   ` Michal Hocko
2011-08-11  8:04     ` Michal Hocko
2011-08-11  8:57     ` Raghavendra K T
2011-08-11  8:57       ` Raghavendra K T
2011-08-11  9:03       ` Michal Hocko
2011-08-11  9:03         ` Michal Hocko
2011-08-12  6:59         ` Raghavendra K T
2011-08-12  6:59           ` Raghavendra K T
2011-08-10 17:29 ` [PATCH 2/2][cleanup] " Raghavendra K T
2011-08-10 17:29   ` Raghavendra K T
2011-08-10 23:59   ` KAMEZAWA Hiroyuki
2011-08-10 23:59     ` KAMEZAWA Hiroyuki
2011-08-11  8:05   ` Michal Hocko
2011-08-11  8:05     ` Michal Hocko
2011-08-11  8:21     ` Raghavendra K T
2011-08-11  8:21       ` Raghavendra K T
2011-08-11  7:53 ` [PATCH 0/2][cleanup] " Michal Hocko
2011-08-11  7:53   ` Michal Hocko
2011-08-11  8:16   ` Raghavendra K T [this message]
2011-08-11  8:16     ` Raghavendra K T
2011-08-11  8:26     ` Michal Hocko
2011-08-11  8:26       ` Michal Hocko
2011-08-11  8:41       ` Raghavendra K T
2011-08-11  8:41         ` Raghavendra K T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E438FD3.7070000@linux.vnet.ibm.com \
    --to=raghukt@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=arend@broadcom.com \
    --cc=bsingharora@gmail.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linville@tuxdriver.com \
    --cc=mchehab@redhat.com \
    --cc=mhocko@suse.cz \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.