All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: device-drivers-devel@blackfin.uclinux.org,
	alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	Mike Frysinger <vapier.adi@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch
Date: Thu, 11 Aug 2011 11:59:36 +0200	[thread overview]
Message-ID: <4E43A808.4050105@metafoo.de> (raw)
In-Reply-To: <20110811093140.GB18454@opensource.wolfsonmicro.com>

On 08/11/2011 11:31 AM, Mark Brown wrote:
> On Wed, Aug 10, 2011 at 05:52:41AM +0200, Lars-Peter Clausen wrote:
>> Currently it is only possible to route one source per switch into a mixer.
>> This patch modifies the code, so that it is possible to route multiple sources
>> into a mixer via the same switch. One use-case for this is routing a stereo
>> channel pair into a mono-mixer via the same switch.
>
> I'd have thought the dapm_is_shared_control() stuff should handle this?


The dapm_is_shared_control() stuff is about sharing kcontrols between multiple
muxes. This is about sharing the same kcontrol between multiple paths of the
same mixer.

i.e

{ "Mono Mixer", "DAC", "Left DAC" },
{ "Mono Mixer", "DAC", "Right DAC" },

doesn't work without this patch.

WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
	alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
	device-drivers-devel@blackfin.uclinux.org,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch
Date: Thu, 11 Aug 2011 11:59:36 +0200	[thread overview]
Message-ID: <4E43A808.4050105@metafoo.de> (raw)
In-Reply-To: <20110811093140.GB18454@opensource.wolfsonmicro.com>

On 08/11/2011 11:31 AM, Mark Brown wrote:
> On Wed, Aug 10, 2011 at 05:52:41AM +0200, Lars-Peter Clausen wrote:
>> Currently it is only possible to route one source per switch into a mixer.
>> This patch modifies the code, so that it is possible to route multiple sources
>> into a mixer via the same switch. One use-case for this is routing a stereo
>> channel pair into a mono-mixer via the same switch.
>
> I'd have thought the dapm_is_shared_control() stuff should handle this?


The dapm_is_shared_control() stuff is about sharing kcontrols between multiple
muxes. This is about sharing the same kcontrol between multiple paths of the
same mixer.

i.e

{ "Mono Mixer", "DAC", "Left DAC" },
{ "Mono Mixer", "DAC", "Right DAC" },

doesn't work without this patch.

  reply	other threads:[~2011-08-11 10:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10  3:52 [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch Lars-Peter Clausen
2011-08-10  3:52 ` Lars-Peter Clausen
2011-08-10  3:52 ` [PATCH 2/4] ASoC: Add ADAU1373 codec support Lars-Peter Clausen
2011-08-10  3:52   ` Lars-Peter Clausen
2011-08-10  6:11   ` Lars-Peter Clausen
2011-08-10  6:11     ` Lars-Peter Clausen
2011-08-11  9:27   ` Mark Brown
2011-08-11  9:27     ` Mark Brown
2011-08-11 10:11     ` Lars-Peter Clausen
2011-08-11 10:11       ` Lars-Peter Clausen
2011-08-11 13:16       ` Mark Brown
2011-08-11 13:16         ` Mark Brown
2011-08-12  0:20         ` Lars-Peter Clausen
2011-08-12  0:20           ` Lars-Peter Clausen
2011-08-12  1:20           ` Mark Brown
2011-08-12  1:20             ` Mark Brown
2011-08-13  3:25             ` Lars-Peter Clausen
2011-08-13  3:25               ` Lars-Peter Clausen
2011-08-14 10:24               ` Mark Brown
2011-08-14 10:24                 ` Mark Brown
2011-08-10  3:52 ` [PATCH 3/4] ASoC: Blackfin: ADAU1373 eval board support Lars-Peter Clausen
2011-08-10  3:52   ` Lars-Peter Clausen
2011-08-10  5:27   ` Scott Jiang
2011-08-10  5:27     ` [alsa-devel] " Scott Jiang
2011-08-10  6:09     ` Lars-Peter Clausen
2011-08-10  6:09       ` [alsa-devel] " Lars-Peter Clausen
2011-08-10  3:52 ` [PATCH 4/4] Blackfin: bf537: Stamp: Register ASoC EVAL-ADAU1373 board driver Lars-Peter Clausen
2011-08-10  3:52   ` Lars-Peter Clausen
2011-08-11  9:31 ` [PATCH 1/4] ASoC: DAPM: Allow multiple mixer sources to be routed via the same switch Mark Brown
2011-08-11  9:31   ` Mark Brown
2011-08-11  9:59   ` Lars-Peter Clausen [this message]
2011-08-11  9:59     ` [alsa-devel] " Lars-Peter Clausen
2011-08-12  1:22     ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2011-08-15 18:15 Lars-Peter Clausen
2011-08-15 18:15 ` Lars-Peter Clausen
2011-08-15 23:25 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E43A808.4050105@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.