From: Richard Henderson <rth@twiddle.net>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "Alexander Graf" <agraf@suse.de>,
"qemu-devel Developers" <qemu-devel@nongnu.org>,
"Kirill Batuzov" <batuzovk@ispras.ru>,
"Andreas Färber" <andreas.faerber@web.de>,
"Avi Kivity" <avi@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops
Date: Thu, 11 Aug 2011 11:14:55 -0700 [thread overview]
Message-ID: <4E441C1F.5090902@twiddle.net> (raw)
In-Reply-To: <CAAu8pHsHWDeskgELDcm+5zt1_AbkApFhfkFvMBgf0nKBbX0Opw@mail.gmail.com>
On 08/11/2011 09:38 AM, Blue Swirl wrote:
> On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity <avi@redhat.com> wrote:
>> On 08/11/2011 03:36 PM, Alexander Graf wrote:
>>>
>>>>
>>>> Or to have automatic generation of the optionals based on the
>>>> primitives, if the optionals are not present.
>>>
>>> That's what's happening in the background already, no? The line is towards
>>> tcg users though, not it tcg internal code.
>>>
>>
>> Yes, and it doesn't make sense to optimize through synthetic instructions.
>
> I'd just create all INDEX_op_* enums and adjust TCG targets etc. to
> call tcg_abort() in the default case.
>
Seconded. We can still expand the optional enums exactly as we do now,
but make sure that the enum is always present. That'll clean up a *lot*
of ifdefs throughout tcg/*.
r~
next prev parent reply other threads:[~2011-08-11 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 10:50 [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops Alexander Graf
2011-08-11 11:24 ` malc
2011-08-11 11:40 ` Alexander Graf
2011-08-11 12:28 ` Avi Kivity
2011-08-11 12:36 ` Alexander Graf
2011-08-11 12:58 ` Avi Kivity
2011-08-11 16:38 ` Blue Swirl
2011-08-11 18:14 ` Richard Henderson [this message]
2011-08-21 20:22 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E441C1F.5090902@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=batuzovk@ispras.ru \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.