* [PATCH v3] tune-ppc: Update to pass glibc configure option to get cpu specific support
@ 2011-08-11 6:17 Kumar Gala
2011-08-11 21:51 ` Saul Wold
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2011-08-11 6:17 UTC (permalink / raw)
To: openembedded-core
We need --with-cpu based to glibc to get proper support on 603e & e500mc
to pickup proper math libs to deal with sqrt. These core do not
implement the fsqrt[s] instructions that the normal PPC math libs
utilize.
This causes use to not set AVAILTUNES specifically to the sub-arch only
as we arent generically compatiable.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
v3:
- utilize TUNE_FEATURES for how we set GLIBC_EXTRA_OECONF
meta/conf/machine/include/tune-ppc603e.inc | 5 ++++-
meta/conf/machine/include/tune-ppce500mc.inc | 5 ++++-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/meta/conf/machine/include/tune-ppc603e.inc b/meta/conf/machine/include/tune-ppc603e.inc
index 9abb694..44a708a 100644
--- a/meta/conf/machine/include/tune-ppc603e.inc
+++ b/meta/conf/machine/include/tune-ppc603e.inc
@@ -6,6 +6,9 @@ TUNEVALID[ppc603e] = "Enable ppc603e specific processor optimizations"
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-mcpu=603e", "", d)}"
TUNE_PKGARCH = "${@bb.utils.contains('TUNE_FEATURES', 'ppc603e', 'ppc603e', '${PPCPKGARCH}', d)}"
-AVAILTUNES += "ppc603e"
+AVAILTUNES = "ppc603e"
TUNE_FEATURES_tune-ppc603e = "m32 ppc603e"
PACKAGE_EXTRA_ARCHS_tune-ppc603e = "powerpc ppc603e"
+
+# glibc configure options to get 603e specific library (for sqrt)
+GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-with-cpu=603e", "", d)}"
diff --git a/meta/conf/machine/include/tune-ppce500mc.inc b/meta/conf/machine/include/tune-ppce500mc.inc
index b5031f4..9849603 100644
--- a/meta/conf/machine/include/tune-ppce500mc.inc
+++ b/meta/conf/machine/include/tune-ppce500mc.inc
@@ -6,6 +6,9 @@ TUNEVALID[ppce500mc] = "Enable ppce500mc specific processor optimizations"
TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-mcpu=e500mc", "", d)}"
TUNE_PKGARCH = "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "ppce500mc", "${PPCPKGARCH}", d)}"
-AVAILTUNES += "ppce500mc"
+AVAILTUNES = "ppce500mc"
TUNE_FEATURES_tune-ppce500mc = "m32 ppce500mc"
PACKAGE_EXTRA_ARCHS_tune-ppce500mc = "powerpc ppce500mc"
+
+# glibc configure options to get e500mc specific library (for sqrt)
+GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-with-cpu=e500mc", "", d)}"
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] tune-ppc: Update to pass glibc configure option to get cpu specific support
2011-08-11 6:17 [PATCH v3] tune-ppc: Update to pass glibc configure option to get cpu specific support Kumar Gala
@ 2011-08-11 21:51 ` Saul Wold
2011-08-12 4:49 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2011-08-11 21:51 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 08/10/2011 11:17 PM, Kumar Gala wrote:
> We need --with-cpu based to glibc to get proper support on 603e& e500mc
> to pickup proper math libs to deal with sqrt. These core do not
> implement the fsqrt[s] instructions that the normal PPC math libs
> utilize.
>
> This causes use to not set AVAILTUNES specifically to the sub-arch only
> as we arent generically compatiable.
>
> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
> ---
> v3:
> - utilize TUNE_FEATURES for how we set GLIBC_EXTRA_OECONF
>
> meta/conf/machine/include/tune-ppc603e.inc | 5 ++++-
> meta/conf/machine/include/tune-ppce500mc.inc | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/meta/conf/machine/include/tune-ppc603e.inc b/meta/conf/machine/include/tune-ppc603e.inc
> index 9abb694..44a708a 100644
> --- a/meta/conf/machine/include/tune-ppc603e.inc
> +++ b/meta/conf/machine/include/tune-ppc603e.inc
> @@ -6,6 +6,9 @@ TUNEVALID[ppc603e] = "Enable ppc603e specific processor optimizations"
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-mcpu=603e", "", d)}"
> TUNE_PKGARCH = "${@bb.utils.contains('TUNE_FEATURES', 'ppc603e', 'ppc603e', '${PPCPKGARCH}', d)}"
>
> -AVAILTUNES += "ppc603e"
> +AVAILTUNES = "ppc603e"
> TUNE_FEATURES_tune-ppc603e = "m32 ppc603e"
> PACKAGE_EXTRA_ARCHS_tune-ppc603e = "powerpc ppc603e"
> +
> +# glibc configure options to get 603e specific library (for sqrt)
> +GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-with-cpu=603e", "", d)}"
> diff --git a/meta/conf/machine/include/tune-ppce500mc.inc b/meta/conf/machine/include/tune-ppce500mc.inc
> index b5031f4..9849603 100644
> --- a/meta/conf/machine/include/tune-ppce500mc.inc
> +++ b/meta/conf/machine/include/tune-ppce500mc.inc
> @@ -6,6 +6,9 @@ TUNEVALID[ppce500mc] = "Enable ppce500mc specific processor optimizations"
> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-mcpu=e500mc", "", d)}"
> TUNE_PKGARCH = "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "ppce500mc", "${PPCPKGARCH}", d)}"
>
> -AVAILTUNES += "ppce500mc"
> +AVAILTUNES = "ppce500mc"
> TUNE_FEATURES_tune-ppce500mc = "m32 ppce500mc"
> PACKAGE_EXTRA_ARCHS_tune-ppce500mc = "powerpc ppce500mc"
> +
> +# glibc configure options to get e500mc specific library (for sqrt)
> +GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-with-cpu=e500mc", "", d)}"
Kumar,
This patch is not applying directly it seems that you might have some
difference in the TUNE_FEATURES and PACKAGE_EXTRA_ARCHS_ that is
throwing things off, have you rebased against master?
Sau!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] tune-ppc: Update to pass glibc configure option to get cpu specific support
2011-08-11 21:51 ` Saul Wold
@ 2011-08-12 4:49 ` Kumar Gala
0 siblings, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2011-08-12 4:49 UTC (permalink / raw)
To: Saul Wold; +Cc: Patches and discussions about the oe-core layer
On Aug 11, 2011, at 4:51 PM, Saul Wold wrote:
> On 08/10/2011 11:17 PM, Kumar Gala wrote:
>> We need --with-cpu based to glibc to get proper support on 603e& e500mc
>> to pickup proper math libs to deal with sqrt. These core do not
>> implement the fsqrt[s] instructions that the normal PPC math libs
>> utilize.
>>
>> This causes use to not set AVAILTUNES specifically to the sub-arch only
>> as we arent generically compatiable.
>>
>> Signed-off-by: Kumar Gala<galak@kernel.crashing.org>
>> ---
>> v3:
>> - utilize TUNE_FEATURES for how we set GLIBC_EXTRA_OECONF
>>
>> meta/conf/machine/include/tune-ppc603e.inc | 5 ++++-
>> meta/conf/machine/include/tune-ppce500mc.inc | 5 ++++-
>> 2 files changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/tune-ppc603e.inc b/meta/conf/machine/include/tune-ppc603e.inc
>> index 9abb694..44a708a 100644
>> --- a/meta/conf/machine/include/tune-ppc603e.inc
>> +++ b/meta/conf/machine/include/tune-ppc603e.inc
>> @@ -6,6 +6,9 @@ TUNEVALID[ppc603e] = "Enable ppc603e specific processor optimizations"
>> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-mcpu=603e", "", d)}"
>> TUNE_PKGARCH = "${@bb.utils.contains('TUNE_FEATURES', 'ppc603e', 'ppc603e', '${PPCPKGARCH}', d)}"
>>
>> -AVAILTUNES += "ppc603e"
>> +AVAILTUNES = "ppc603e"
>> TUNE_FEATURES_tune-ppc603e = "m32 ppc603e"
>> PACKAGE_EXTRA_ARCHS_tune-ppc603e = "powerpc ppc603e"
>> +
>> +# glibc configure options to get 603e specific library (for sqrt)
>> +GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-with-cpu=603e", "", d)}"
>> diff --git a/meta/conf/machine/include/tune-ppce500mc.inc b/meta/conf/machine/include/tune-ppce500mc.inc
>> index b5031f4..9849603 100644
>> --- a/meta/conf/machine/include/tune-ppce500mc.inc
>> +++ b/meta/conf/machine/include/tune-ppce500mc.inc
>> @@ -6,6 +6,9 @@ TUNEVALID[ppce500mc] = "Enable ppce500mc specific processor optimizations"
>> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-mcpu=e500mc", "", d)}"
>> TUNE_PKGARCH = "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "ppce500mc", "${PPCPKGARCH}", d)}"
>>
>> -AVAILTUNES += "ppce500mc"
>> +AVAILTUNES = "ppce500mc"
>> TUNE_FEATURES_tune-ppce500mc = "m32 ppce500mc"
>> PACKAGE_EXTRA_ARCHS_tune-ppce500mc = "powerpc ppce500mc"
>> +
>> +# glibc configure options to get e500mc specific library (for sqrt)
>> +GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-with-cpu=e500mc", "", d)}"
>
> Kumar,
>
> This patch is not applying directly it seems that you might have some difference in the TUNE_FEATURES and PACKAGE_EXTRA_ARCHS_ that is throwing things off, have you rebased against master?
>
> Sau!
>
I'll post a clean version.
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-12 4:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-11 6:17 [PATCH v3] tune-ppc: Update to pass glibc configure option to get cpu specific support Kumar Gala
2011-08-11 21:51 ` Saul Wold
2011-08-12 4:49 ` Kumar Gala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.