From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [PATCH V2 4/4] b43: HT-PHY: init: init BPHY and upload 0x1a table
Date: Fri, 12 Aug 2011 10:36:37 -0500 [thread overview]
Message-ID: <4E454885.1060107@lwfinger.net> (raw)
In-Reply-To: <CACna6ryX=N+vZ4-+CRkcZatB81U-5Acm_NfH9eNMrWZwpAvfVw@mail.gmail.com>
On 08/12/2011 10:22 AM, Rafa? Mi?ecki wrote:
> W dniu 12 sierpnia 2011 17:16 u?ytkownik Larry Finger
> <Larry.Finger@lwfinger.net> napisa?:
>> On 08/12/2011 08:27 AM, Rafa? Mi?ecki wrote:
>>>
>>> Signed-off-by: Rafa? Mi?ecki<zajec5@gmail.com>
>>> ---
>>> BPHY is something partially known from N-PHY.
>>>
>>> This 0x1a table with 0xc0 offset is a little tricky. We already upload
>>> something like that earlier, but this is needed to stop radio going crazy
>>> and transmissint crap.
>>
>> I don't care that the commit message contains "crap", but others might. I
>> do, however, want you to change from the nonexistent "transmissint" to
>> "transmission" or "transmitting", whichever you mean.
>>
>> Other than that, ACK. Note, I have no HT device, thus I have done no
>> testing.
>
> Err, that's comment, not commit message. Won't be visible in "git log".
>
> Should I still change it?
Sorry I missed the ---. In the comment, it is OK.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [PATCH V2 4/4] b43: HT-PHY: init: init BPHY and upload 0x1a table
Date: Fri, 12 Aug 2011 10:36:37 -0500 [thread overview]
Message-ID: <4E454885.1060107@lwfinger.net> (raw)
In-Reply-To: <CACna6ryX=N+vZ4-+CRkcZatB81U-5Acm_NfH9eNMrWZwpAvfVw@mail.gmail.com>
On 08/12/2011 10:22 AM, Rafał Miłecki wrote:
> W dniu 12 sierpnia 2011 17:16 użytkownik Larry Finger
> <Larry.Finger@lwfinger.net> napisał:
>> On 08/12/2011 08:27 AM, Rafał Miłecki wrote:
>>>
>>> Signed-off-by: Rafał Miłecki<zajec5@gmail.com>
>>> ---
>>> BPHY is something partially known from N-PHY.
>>>
>>> This 0x1a table with 0xc0 offset is a little tricky. We already upload
>>> something like that earlier, but this is needed to stop radio going crazy
>>> and transmissint crap.
>>
>> I don't care that the commit message contains "crap", but others might. I
>> do, however, want you to change from the nonexistent "transmissint" to
>> "transmission" or "transmitting", whichever you mean.
>>
>> Other than that, ACK. Note, I have no HT device, thus I have done no
>> testing.
>
> Err, that's comment, not commit message. Won't be visible in "git log".
>
> Should I still change it?
Sorry I missed the ---. In the comment, it is OK.
Larry
next prev parent reply other threads:[~2011-08-12 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 13:27 [PATCH V2 4/4] b43: HT-PHY: init: init BPHY and upload 0x1a table Rafał Miłecki
2011-08-12 13:27 ` Rafał Miłecki
2011-08-12 15:16 ` Larry Finger
2011-08-12 15:16 ` Larry Finger
2011-08-12 15:22 ` Rafał Miłecki
2011-08-12 15:22 ` Rafał Miłecki
2011-08-12 15:36 ` Larry Finger [this message]
2011-08-12 15:36 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E454885.1060107@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.