All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Jin <joe.jin@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Greg Marsden <greg.marsden@oracle.com>,
	Kurt C Hackel <KURT.HACKEL@oracle.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] xen-blkback: sync I/O after backend disconnected
Date: Tue, 16 Aug 2011 14:56:30 +0800	[thread overview]
Message-ID: <4E4A149E.5080608@oracle.com> (raw)
In-Reply-To: <20110815144610.GA3707@infradead.org>

On 08/15/11 22:46, Christoph Hellwig wrote:
> On Mon, Aug 15, 2011 at 12:55:02PM +0800, Joe Jin wrote:
>> When backend disconnect, sync IO requests to the disk.
> 
> Care to explain why?

When backend disconnect, I think we'd better flush all dirty data 
to the disk ASAP.

> 
> Also you'll just need a sync_blockdev, fsync_bdev does far to many
> things that don't make any sense when you don't have a file system
> mounted on a device.
> 

xen-blkback support physical device and loopback file, so I think
here should be fsync_bdev()? 

Thanks,
Joe

WARNING: multiple messages have this Message-ID (diff)
From: Joe Jin <joe.jin@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Jens Axboe <jaxboe@fusionio.com>,
	Greg Marsden <greg.marsden@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ian Campbell <Ian.Campbell@eu.citrix.com>,
	Kurt C Hackel <KURT.HACKEL@oracle.com>
Subject: Re: [patch] xen-blkback: sync I/O after backend disconnected
Date: Tue, 16 Aug 2011 14:56:30 +0800	[thread overview]
Message-ID: <4E4A149E.5080608@oracle.com> (raw)
In-Reply-To: <20110815144610.GA3707@infradead.org>

On 08/15/11 22:46, Christoph Hellwig wrote:
> On Mon, Aug 15, 2011 at 12:55:02PM +0800, Joe Jin wrote:
>> When backend disconnect, sync IO requests to the disk.
> 
> Care to explain why?

When backend disconnect, I think we'd better flush all dirty data 
to the disk ASAP.

> 
> Also you'll just need a sync_blockdev, fsync_bdev does far to many
> things that don't make any sense when you don't have a file system
> mounted on a device.
> 

xen-blkback support physical device and loopback file, so I think
here should be fsync_bdev()? 

Thanks,
Joe

  parent reply	other threads:[~2011-08-16  6:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15  4:55 [patch] xen-blkback: sync I/O after backend disconnected Joe Jin
2011-08-15  4:55 ` Joe Jin
2011-08-15 14:46 ` Christoph Hellwig
2011-08-15 15:10   ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-08-16  6:56   ` Joe Jin [this message]
2011-08-16  6:56     ` Joe Jin
2011-08-22 14:38     ` Christoph Hellwig
     [not found]   ` <m2n.s.1QsyrJ-132485@chiark.greenend.org.uk>
2011-08-25 16:15     ` [Xen-devel] " Ian Jackson
2011-09-07 12:48       ` Konrad Rzeszutek Wilk
2011-09-07 12:48         ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4A149E.5080608@oracle.com \
    --to=joe.jin@oracle.com \
    --cc=Ian.Campbell@eu.citrix.com \
    --cc=KURT.HACKEL@oracle.com \
    --cc=greg.marsden@oracle.com \
    --cc=hch@infradead.org \
    --cc=jaxboe@fusionio.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.