All of lore.kernel.org
 help / color / mirror / Atom feed
* [ath9k-devel] [BUG] ath9k truncated management packets from TKIP connected stations
@ 2011-08-16 21:31 ` Bill Jordan
  0 siblings, 0 replies; 17+ messages in thread
From: Bill Jordan @ 2011-08-16 21:31 UTC (permalink / raw)
  To: ath9k-devel

I'm not quite sure what the correct fix is for this.

Ath9k in AP mode with a TKIP security: If a connected station sends a
management packet, the packet is truncated by 8 bytes before being
delivered to hostapd. This prevents the station from reauthenticating
or connecting to a different SSID on the same radio.

In ath9k_rx_accept, for management packets, strip_mic will be true,
and RX_FLAG_MMIC_STRIPPED will be set in rxs->flag. In
ath9k_rx_skb_postprocess, if ah->sw_mgmt_crypto is set,
RX_FLAG_DECRYPTED will be cleared. However, RX_FLAG_MMIC_STRIPPED will
still be set, so, in ath_rx_tasklet, 8 bytes will be trimmed off the
end of the skb.

I'm thinking that in ath9k_rx_accept, is_valid_tkip ?should also
consider ieee80211_is_mgmt(fc). But this wouldn't take into
consideration ah->sw_mgmt_crypto.

Alternatively, RX_FLAG_MMIC_STRIPPED could be cleared in
ath9k_rx_skb_postprocess when RX_FLAG_DECRYPTED is cleared.

I'm looking for input from someone who understands this code better.

Thanks,
Bill Jordan

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2011-08-24  3:12 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-16 21:31 [ath9k-devel] [BUG] ath9k truncated management packets from TKIP connected stations Bill Jordan
2011-08-16 21:31 ` Bill Jordan
2011-08-16 22:52 ` [ath9k-devel] " Felix Fietkau
2011-08-16 22:52   ` Felix Fietkau
2011-08-17 20:06   ` [ath9k-devel] [PATCH] ath9k: fix MGMT packets when using TKIP Bill Jordan
2011-08-17 20:06     ` Bill Jordan
2011-08-18  0:52     ` [ath9k-devel] " Felix Fietkau
2011-08-18  0:52       ` Felix Fietkau
2011-08-19 15:10       ` [ath9k-devel] " Bill Jordan
2011-08-19 15:10         ` Bill Jordan
2011-08-22  8:11         ` [ath9k-devel] " Kalle Valo
2011-08-22  8:11           ` Kalle Valo
2011-08-23 21:59           ` [ath9k-devel] " Bill Jordan
2011-08-23 21:59             ` Bill Jordan
2011-08-23 22:14             ` [ath9k-devel] " Christian Lamparter
2011-08-23 22:14               ` Christian Lamparter
2011-08-24  3:12               ` [ath9k-devel] " Senthilkumar Balasubramanian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.