From: Bernd Schubert <bernd.schubert@itwm.fraunhofer.de>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org,
hch@infradead.org, yong.fan@whamcloud.com,
linux-fsdevel@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 2/6] Return 32/64-bit dir name hash according to usage type
Date: Wed, 17 Aug 2011 11:17:24 +0200 [thread overview]
Message-ID: <4E4B8724.4050101@itwm.fraunhofer.de> (raw)
In-Reply-To: <123AAA92-9EEF-4FB7-AA7B-B179BC0626BA@whamcloud.com>
On 08/16/2011 11:22 PM, Andreas Dilger wrote:
>> +static inline int is_32bit_api(void) +{ +#ifdef
>> HAVE_IS_COMPAT_TASK + return is_compat_task();
>
> Looking more closely, this should actually be "#ifdef CONFIG_COMPAT"
> in the mainline kernel.
>
> HAVE_IS_COMPAT_TASK is from the Lustre configure script for detecting
> which kernel is_compat_task() was added in, since it appeared in some
> kernels at 2.6.17 but wasn't in most arches until 2.6.29.
>
> Sorry I didn't notice this earlier.
>
Oh no, I also should have noticed it :( I even made a small test program
[1], but I then never executed it in 32bit mode :(
Cheers,
Bernd
[1]
http://www.pci.uni-heidelberg.de/tc/usr/bernd/downloads/test_seekdir/
next prev parent reply other threads:[~2011-08-17 9:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 11:25 [PATCH 0/2] 32/64 bit llseek hashes Bernd Schubert
2011-08-16 11:25 ` [PATCH 1/6] Add new FMODE flags: FMODE_32bithash and FMODE_64bithash Bernd Schubert
2011-08-16 11:25 ` [PATCH 2/6] Return 32/64-bit dir name hash according to usage type Bernd Schubert
2011-08-16 21:22 ` Andreas Dilger
2011-08-17 9:17 ` Bernd Schubert [this message]
2011-08-16 11:25 ` [PATCH 3/6] nfsd_open(): rename 'int access' to 'int may_flags' in nfsd_open() Bernd Schubert
2011-08-16 11:25 ` Bernd Schubert
2011-08-16 11:25 ` [PATCH 4/6] nfsd: vfs_llseek() with 32 or 64 bit offsets (hashes) Bernd Schubert
2011-08-16 11:25 ` Bernd Schubert
2011-08-16 11:26 ` [PATCH 5/6] Fix possible Null pointer dereference in ipoib_start_xmit() Bernd Schubert
2011-08-16 11:26 ` [PATCH 6/6] Rename 'n' into a longer variable name Bernd Schubert
2011-08-16 11:42 ` Ivan Shmakov
2011-08-16 11:56 ` [PATCH 0/2] 32/64 bit llseek hashes Bernd Schubert
2011-08-16 11:56 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4B8724.4050101@itwm.fraunhofer.de \
--to=bernd.schubert@itwm.fraunhofer.de \
--cc=adilger@whamcloud.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yong.fan@whamcloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.