From: Ivan Shmakov <ivan@gray.siamics.net>
To: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 6/6] Rename 'n' into a longer variable name.
Date: Tue, 16 Aug 2011 18:42:58 +0700 [thread overview]
Message-ID: <8662lx4m65.fsf@gray.siamics.net> (raw)
In-Reply-To: 20110816112607.1808464.44359.stgit@fsdevel3
>>>>> Bernd Schubert <bernd.schubert@itwm.fraunhofer.de> writes:
> When it comes to me variable names consisting of a single letter
> should be forbidden by coding style guide lines, as it is rather
> difficult to search for single letter, such as 'n'.
The incremental regexp search in GNU Emacs (M-C-s, M-C-r) copes
with that just fine. The regexp I'd use is: \<n\>.
FWIW, I tend to use shorter (including one-character) names for
the variables of narrow (less than a screenful of code) scope.
OTOH, for the globals, and structure members, I'd certainly
prefer more verbose (and descriptive) names.
> Rename struct neighbour *n to dst_neigh
[…]
--
FSF associate member #7257
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-16 11:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 11:25 [PATCH 0/2] 32/64 bit llseek hashes Bernd Schubert
2011-08-16 11:25 ` [PATCH 1/6] Add new FMODE flags: FMODE_32bithash and FMODE_64bithash Bernd Schubert
2011-08-16 11:25 ` [PATCH 2/6] Return 32/64-bit dir name hash according to usage type Bernd Schubert
2011-08-16 21:22 ` Andreas Dilger
2011-08-17 9:17 ` Bernd Schubert
2011-08-16 11:25 ` [PATCH 3/6] nfsd_open(): rename 'int access' to 'int may_flags' in nfsd_open() Bernd Schubert
2011-08-16 11:25 ` Bernd Schubert
2011-08-16 11:25 ` [PATCH 4/6] nfsd: vfs_llseek() with 32 or 64 bit offsets (hashes) Bernd Schubert
2011-08-16 11:25 ` Bernd Schubert
2011-08-16 11:26 ` [PATCH 5/6] Fix possible Null pointer dereference in ipoib_start_xmit() Bernd Schubert
2011-08-16 11:26 ` [PATCH 6/6] Rename 'n' into a longer variable name Bernd Schubert
2011-08-16 11:42 ` Ivan Shmakov [this message]
2011-08-16 11:56 ` [PATCH 0/2] 32/64 bit llseek hashes Bernd Schubert
2011-08-16 11:56 ` Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8662lx4m65.fsf@gray.siamics.net \
--to=ivan@gray.siamics.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=oneingray@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.