All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] script/runqemu: change boot command line for qemuppc
@ 2011-08-19 10:06 Liming Wang
  2011-08-19 13:50 ` Darren Hart
  2011-08-19 16:28 ` Richard Purdie
  0 siblings, 2 replies; 5+ messages in thread
From: Liming Wang @ 2011-08-19 10:06 UTC (permalink / raw)
  To: Bruce.Ashfield; +Cc: yocto, dvhart

Because qemuppc has no graphic emulation, remove console=tty0
and make it run into 3 run level. This can reduce boot time
for qemuppc booting.

Signed-off-by: Liming Wang <liming.wang@windriver.com>
---
 scripts/runqemu-internal |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index c15632d..883fa5b 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
     BIOS=powerpc_rom.bin
     QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
     if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
-        KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
+        KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
     fi
     if [ "$FSTYPE" = "nfs" ]; then
@@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
             cleanup
             return
         fi
-        KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
+        KERNCMDLINE="root=/dev/nfs console=ttyS0 3 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
     fi
 fi
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] script/runqemu: change boot command line for qemuppc
  2011-08-19 10:06 [PATCH] script/runqemu: change boot command line for qemuppc Liming Wang
@ 2011-08-19 13:50 ` Darren Hart
  2011-08-19 16:28 ` Richard Purdie
  1 sibling, 0 replies; 5+ messages in thread
From: Darren Hart @ 2011-08-19 13:50 UTC (permalink / raw)
  To: Liming Wang; +Cc: yocto



On 08/19/2011 03:06 AM, Liming Wang wrote:
> Because qemuppc has no graphic emulation, remove console=tty0
> and make it run into 3 run level. This can reduce boot time
> for qemuppc booting.
> 
> Signed-off-by: Liming Wang <liming.wang@windriver.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>  scripts/runqemu-internal |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index c15632d..883fa5b 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>      BIOS=powerpc_rom.bin
>      QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
>      if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
> -        KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
> +        KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>          QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
>      fi
>      if [ "$FSTYPE" = "nfs" ]; then
> @@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>              cleanup
>              return
>          fi
> -        KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
> +        KERNCMDLINE="root=/dev/nfs console=ttyS0 3 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>          QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
>      fi
>  fi

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] script/runqemu: change boot command line for qemuppc
  2011-08-19 10:06 [PATCH] script/runqemu: change boot command line for qemuppc Liming Wang
  2011-08-19 13:50 ` Darren Hart
@ 2011-08-19 16:28 ` Richard Purdie
  2011-08-22  8:21   ` Liming Wang
  1 sibling, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2011-08-19 16:28 UTC (permalink / raw)
  To: Liming Wang; +Cc: yocto, dvhart

On Fri, 2011-08-19 at 18:06 +0800, Liming Wang wrote:
> Because qemuppc has no graphic emulation, remove console=tty0
> and make it run into 3 run level. This can reduce boot time
> for qemuppc booting.
> 
> Signed-off-by: Liming Wang <liming.wang@windriver.com>
> ---
>  scripts/runqemu-internal |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index c15632d..883fa5b 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>      BIOS=powerpc_rom.bin
>      QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
>      if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
> -        KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
> +        KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>          QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
>      fi
>      if [ "$FSTYPE" = "nfs" ]; then
> @@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>              cleanup
>              return
>          fi
> -        KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
> +        KERNCMDLINE="root=/dev/nfs console=ttyS0 3 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>          QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
>      fi
>  fi

Can we not fix the X scripts so that if an fbdev X server is in use and
the framebuffer device node does not exist, it just exits cleanly with a
suitable message and doesn't timeout on boot?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] script/runqemu: change boot command line for qemuppc
  2011-08-19 16:28 ` Richard Purdie
@ 2011-08-22  8:21   ` Liming Wang
  2011-08-22 15:52     ` Bruce Ashfield
  0 siblings, 1 reply; 5+ messages in thread
From: Liming Wang @ 2011-08-22  8:21 UTC (permalink / raw)
  To: Richard Purdie; +Cc: yocto, dvhart

On 2011-8-20 0:28, Richard Purdie wrote:
> On Fri, 2011-08-19 at 18:06 +0800, Liming Wang wrote:
>> Because qemuppc has no graphic emulation, remove console=tty0
>> and make it run into 3 run level. This can reduce boot time
>> for qemuppc booting.
>>
>> Signed-off-by: Liming Wang<liming.wang@windriver.com>
>> ---
>>   scripts/runqemu-internal |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
>> index c15632d..883fa5b 100755
>> --- a/scripts/runqemu-internal
>> +++ b/scripts/runqemu-internal
>> @@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>>       BIOS=powerpc_rom.bin
>>       QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
>>       if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
>> -        KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>> +        KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>>           QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
>>       fi
>>       if [ "$FSTYPE" = "nfs" ]; then
>> @@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>>               cleanup
>>               return
>>           fi
>> -        KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>> +        KERNCMDLINE="root=/dev/nfs console=ttyS0 3 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>>           QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
>>       fi
>>   fi
> Can we not fix the X scripts so that if an fbdev X server is in use and
X scripts serve for all the boards. And we also can't assume all the 
boards use the same
framebuffer device. So how to detect whether the framebuffer device 
exists is board dependent.
Maybe we can see whether the device /dev/fb0 exists(it could be created 
manually, so we should try to open it to verify)
or the file /proc/fb exists to confirm the framebuffer device. Anyway, 
any modification should be
tested on all boards to see whether it works. I prefer to mark it as 
todo task in 1.1

Liming Wang
> the framebuffer device node does not exist, it just exits cleanly with a
> suitable message and doesn't timeout on boot?
>
> Cheers,
>
> Richard
>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] script/runqemu: change boot command line for qemuppc
  2011-08-22  8:21   ` Liming Wang
@ 2011-08-22 15:52     ` Bruce Ashfield
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Ashfield @ 2011-08-22 15:52 UTC (permalink / raw)
  To: Liming Wang; +Cc: yocto, dvhart

On 11-08-22 04:21 AM, Liming Wang wrote:
> On 2011-8-20 0:28, Richard Purdie wrote:
>> On Fri, 2011-08-19 at 18:06 +0800, Liming Wang wrote:
>>> Because qemuppc has no graphic emulation, remove console=tty0
>>> and make it run into 3 run level. This can reduce boot time
>>> for qemuppc booting.
>>>
>>> Signed-off-by: Liming Wang<liming.wang@windriver.com>
>>> ---
>>> scripts/runqemu-internal | 4 ++--
>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
>>> index c15632d..883fa5b 100755
>>> --- a/scripts/runqemu-internal
>>> +++ b/scripts/runqemu-internal
>>> @@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>>> BIOS=powerpc_rom.bin
>>> QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
>>> if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
>>> - KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0
>>> $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
>>> + KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD
>>> mem=$QEMU_MEMORY"
>>> QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE
>>> -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
>>> fi
>>> if [ "$FSTYPE" = "nfs" ]; then
>>> @@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
>>> cleanup
>>> return
>>> fi
>>> - KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0
>>> nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD
>>> mem=$QEMU_MEMORY"
>>> + KERNCMDLINE="root=/dev/nfs console=ttyS0 3
>>> nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD
>>> mem=$QEMU_MEMORY"
>>> QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE
>>> -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
>>> fi
>>> fi
>> Can we not fix the X scripts so that if an fbdev X server is in use and
> X scripts serve for all the boards. And we also can't assume all the
> boards use the same
> framebuffer device. So how to detect whether the framebuffer device
> exists is board dependent.
> Maybe we can see whether the device /dev/fb0 exists(it could be created
> manually, so we should try to open it to verify)
> or the file /proc/fb exists to confirm the framebuffer device. Anyway,
> any modification should be
> tested on all boards to see whether it works. I prefer to mark it as
> todo task in 1.1

I know I'm ok with this strategy, since time is short in the
1.1 cycle. We can always open a bugzilla item to track this,
just to be sure it isn't forgotten. Preferably we'll get a
qemuppc with a framebuffer in 1.x timeframe and we won't need
this at all. Coming up with something generic and the amount
of testing required doesn't fit the timeframe that we currently
have for 1.1.

But in the end, this is up to Richard, this is just my 2 cents
worth.

Bruce

>
> Liming Wang
>> the framebuffer device node does not exist, it just exits cleanly with a
>> suitable message and doesn't timeout on boot?
>>
>> Cheers,
>>
>> Richard
>>
>>
>



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-08-22 15:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-19 10:06 [PATCH] script/runqemu: change boot command line for qemuppc Liming Wang
2011-08-19 13:50 ` Darren Hart
2011-08-19 16:28 ` Richard Purdie
2011-08-22  8:21   ` Liming Wang
2011-08-22 15:52     ` Bruce Ashfield

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.