All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart De Schuymer <bdschuym@pandora.be>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: bridge@linux-foundation.org, Ed Swierk <eswierk@bigswitch.com>,
	Nick Carter <ncarter100@gmail.com>,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	David Lamparter <equinox@diac24.net>
Subject: Re: [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses
Date: Sat, 20 Aug 2011 17:31:04 +0200	[thread overview]
Message-ID: <4E4FD338.5080100@pandora.be> (raw)
In-Reply-To: <20110819135810.1a529ab2@nehalam.ftrdhcpuser.net>

Op 19/08/2011 22:58, Stephen Hemminger schreef:

> Signed-off-by: Stephen Hemminger<shemminger@vyatta.com>
>
> ---
>   include/linux/netfilter_bridge.h      |    5 ++++-
>   net/bridge/br_input.c                 |   15 ++++++++++++---
>   net/bridge/netfilter/ebtable_filter.c |   18 ++++++++++++++++--
>   3 files changed, 32 insertions(+), 6 deletions(-)
>
> --- a/include/linux/netfilter_bridge.h	2011-08-19 13:11:51.972125670 -0700
> +++ b/include/linux/netfilter_bridge.h	2011-08-19 13:13:36.452130443 -0700
> @@ -22,7 +22,10 @@
>   #define NF_BR_POST_ROUTING	4
>   /* Not really a hook, but used for the ebtables broute table */
>   #define NF_BR_BROUTING		5
> -#define NF_BR_NUMHOOKS		6
> +/* Packets to link local multicast addresses (01-80-C2-00-00-XX) */
> +#define NF_BR_LINK_LOCAL_IN	6
> +
> +#define NF_BR_NUMHOOKS		7
>

You will need to make sure you don't break backwards compatibility with 
the ebtables userspace tool. ebtables.h::struct ebt_replace is a 
structure used for communication between userspace and the kernel. It 
has the member hook_entry defined like this:
struct ebt_entries __user *hook_entry[NF_BR_NUMHOOKS];

cheers,
Bart



-- 
Bart De Schuymer
www.artinalgorithms.be

WARNING: multiple messages have this Message-ID (diff)
From: Bart De Schuymer <bdschuym@pandora.be>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Lamparter <equinox@diac24.net>,
	Nick Carter <ncarter100@gmail.com>,
	Ed Swierk <eswierk@bigswitch.com>,
	netdev@vger.kernel.org, bridge@linux-foundation.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses
Date: Sat, 20 Aug 2011 17:31:04 +0200	[thread overview]
Message-ID: <4E4FD338.5080100@pandora.be> (raw)
In-Reply-To: <20110819135810.1a529ab2@nehalam.ftrdhcpuser.net>

Op 19/08/2011 22:58, Stephen Hemminger schreef:

> Signed-off-by: Stephen Hemminger<shemminger@vyatta.com>
>
> ---
>   include/linux/netfilter_bridge.h      |    5 ++++-
>   net/bridge/br_input.c                 |   15 ++++++++++++---
>   net/bridge/netfilter/ebtable_filter.c |   18 ++++++++++++++++--
>   3 files changed, 32 insertions(+), 6 deletions(-)
>
> --- a/include/linux/netfilter_bridge.h	2011-08-19 13:11:51.972125670 -0700
> +++ b/include/linux/netfilter_bridge.h	2011-08-19 13:13:36.452130443 -0700
> @@ -22,7 +22,10 @@
>   #define NF_BR_POST_ROUTING	4
>   /* Not really a hook, but used for the ebtables broute table */
>   #define NF_BR_BROUTING		5
> -#define NF_BR_NUMHOOKS		6
> +/* Packets to link local multicast addresses (01-80-C2-00-00-XX) */
> +#define NF_BR_LINK_LOCAL_IN	6
> +
> +#define NF_BR_NUMHOOKS		7
>

You will need to make sure you don't break backwards compatibility with 
the ebtables userspace tool. ebtables.h::struct ebt_replace is a 
structure used for communication between userspace and the kernel. It 
has the member hook_entry defined like this:
struct ebt_entries __user *hook_entry[NF_BR_NUMHOOKS];

cheers,
Bart



-- 
Bart De Schuymer
www.artinalgorithms.be

  parent reply	other threads:[~2011-08-20 15:31 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAF5U64C+WgQhfJL3zfVnvzE7p=G61humQCObHGUxAvY2-MGAFQ@mail.gmail.com>
2011-08-12 22:37 ` [PATCH] bridge: mask forwarding of IEEE 802 local multicast groups Ed Swierk
2011-08-12 22:45   ` Stephen Hemminger
2011-08-13  5:43     ` Ed Swierk
2011-08-15 22:05       ` [Bridge] [RFC] bridge: allow passing link-local multicast Stephen Hemminger
2011-08-15 22:05         ` Stephen Hemminger
2011-08-18 15:06         ` [Bridge] " Nick Carter
2011-08-18 15:06           ` Nick Carter
2011-08-18 15:10           ` [Bridge] " Stephen Hemminger
2011-08-18 15:10             ` Stephen Hemminger
2011-08-18 15:52             ` [Bridge] " Nick Carter
2011-08-18 15:52               ` Nick Carter
2011-08-18 16:39               ` [Bridge] " Stephen Hemminger
2011-08-18 16:39                 ` Stephen Hemminger
2011-08-19  2:27                 ` [Bridge] " David Lamparter
2011-08-19  2:27                   ` David Lamparter
2011-08-19 20:58                   ` [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses Stephen Hemminger
2011-08-19 20:58                     ` Stephen Hemminger
2011-08-19 22:18                     ` [Bridge] " Christian Benvenuti (benve)
2011-08-19 22:18                       ` Christian Benvenuti (benve)
2011-08-19 22:24                       ` [Bridge] " Stephen Hemminger
2011-08-19 22:24                         ` Stephen Hemminger
2011-08-20 15:31                     ` Bart De Schuymer [this message]
2011-08-20 15:31                       ` Bart De Schuymer
2011-08-22 13:59                     ` [Bridge] " David Lamparter
2011-08-22 13:59                       ` David Lamparter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4FD338.5080100@pandora.be \
    --to=bdschuym@pandora.be \
    --cc=bridge@linux-foundation.org \
    --cc=equinox@diac24.net \
    --cc=eswierk@bigswitch.com \
    --cc=ncarter100@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.