* [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962
@ 2011-08-21 11:58 Mark Brown
2011-08-22 10:25 ` Liam Girdwood
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-08-21 11:58 UTC (permalink / raw)
To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown
This should never happen with level triggered IRQs.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8962.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index 0c61c2f..b877fa9 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -3577,6 +3577,9 @@ static irqreturn_t wm8962_irq(int irq, void *data)
active = snd_soc_read(codec, WM8962_INTERRUPT_STATUS_2);
active &= ~mask;
+ if (!active)
+ return IRQ_NONE;
+
/* Acknowledge the interrupts */
snd_soc_write(codec, WM8962_INTERRUPT_STATUS_2, active);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962
2011-08-21 11:58 [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962 Mark Brown
@ 2011-08-22 10:25 ` Liam Girdwood
0 siblings, 0 replies; 2+ messages in thread
From: Liam Girdwood @ 2011-08-22 10:25 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
On 21/08/11 12:58, Mark Brown wrote:
> This should never happen with level triggered IRQs.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index 0c61c2f..b877fa9 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -3577,6 +3577,9 @@ static irqreturn_t wm8962_irq(int irq, void *data)
> active = snd_soc_read(codec, WM8962_INTERRUPT_STATUS_2);
> active &= ~mask;
>
> + if (!active)
> + return IRQ_NONE;
> +
> /* Acknowledge the interrupts */
> snd_soc_write(codec, WM8962_INTERRUPT_STATUS_2, active);
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-22 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-21 11:58 [PATCH] ASoC: Report IRQ_NONE when we don't see an interrupt from WM8962 Mark Brown
2011-08-22 10:25 ` Liam Girdwood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.