From: Pierre Louis Aublin <pierre-louis.aublin@inria.fr>
To: Julia Lawall <julia@diku.dk>
Cc: Bing Zhao <bzhao@marvell.com>,
kernel-janitors@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized
Date: Mon, 22 Aug 2011 14:11:24 +0000 [thread overview]
Message-ID: <4E52638C.8080407@inria.fr> (raw)
In-Reply-To: <1314021636-11528-4-git-send-email-julia@diku.dk>
Hello all
On 08/22/2011 04:00 PM, Julia Lawall wrote:
> - if (!bss_desc) {
> + if (!beacon_ie) {
> dev_err(priv->adapter->dev, " failed to alloc bss_desc\n");
Shouldn't we also modify the error message, from "failed to alloc
bss_desc" to "failed to alloc beacon_ie" ?
Sincerely
Pierre Louis Aublin
WARNING: multiple messages have this Message-ID (diff)
From: Pierre Louis Aublin <pierre-louis.aublin@inria.fr>
To: Julia Lawall <julia@diku.dk>
Cc: Bing Zhao <bzhao@marvell.com>,
kernel-janitors@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value
Date: Mon, 22 Aug 2011 16:11:24 +0200 [thread overview]
Message-ID: <4E52638C.8080407@inria.fr> (raw)
In-Reply-To: <1314021636-11528-4-git-send-email-julia@diku.dk>
Hello all
On 08/22/2011 04:00 PM, Julia Lawall wrote:
> - if (!bss_desc) {
> + if (!beacon_ie) {
> dev_err(priv->adapter->dev, " failed to alloc bss_desc\n");
Shouldn't we also modify the error message, from "failed to alloc
bss_desc" to "failed to alloc beacon_ie" ?
Sincerely
Pierre Louis Aublin
next prev parent reply other threads:[~2011-08-22 14:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 14:00 [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Julia Lawall
2011-08-22 14:00 ` Julia Lawall
2011-08-22 14:00 ` Julia Lawall
2011-08-22 14:11 ` Pierre Louis Aublin [this message]
2011-08-22 14:11 ` Pierre Louis Aublin
2011-08-22 14:12 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the Julia Lawall
2011-08-22 14:12 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Julia Lawall
2011-08-22 14:16 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized Julia Lawall
2011-08-22 14:16 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Julia Lawall
2011-08-22 14:16 ` Julia Lawall
2011-08-22 19:02 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the Bing Zhao
2011-08-22 19:02 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Bing Zhao
2011-08-22 19:09 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized walter harms
2011-08-22 19:09 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value walter harms
2011-08-22 19:09 ` walter harms
2011-08-22 19:29 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the Bing Zhao
2011-08-22 19:29 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Bing Zhao
2011-08-22 19:29 ` Bing Zhao
2011-08-22 15:19 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized Larry Finger
2011-08-22 15:19 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Larry Finger
2011-08-22 15:28 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the Julia Lawall
2011-08-22 15:28 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: test the just-initialized value Julia Lawall
2012-01-09 9:40 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: convert GFP_KERNEL to GFP_ATOMIC Julia Lawall
2012-01-09 9:40 ` Julia Lawall
2012-01-09 18:49 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: convert Bing Zhao
2012-01-09 18:49 ` [PATCH 4/4] drivers/net/wireless/mwifiex/scan.c: convert GFP_KERNEL to GFP_ATOMIC Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E52638C.8080407@inria.fr \
--to=pierre-louis.aublin@inria.fr \
--cc=bzhao@marvell.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.