All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: "devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"Nayak, Rajendra" <rnayak@ti.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1
Date: Tue, 23 Aug 2011 14:38:21 +0200	[thread overview]
Message-ID: <4E539F3D.4010602@ti.com> (raw)
In-Reply-To: <4E537ECB.1060704@ti.com>

Hi Manju,

Few "minor" comments about your subjects in this series.

> Patch series reworked from:
> http://permalink.gmane.org/gmane.linux.ports.arm.omap/61674
> Also added support for i2c1 controller on omap4 based panda
> board.
>
> Baseline:
> =========
> git://git.secretlab.ca/git/linux-2.6.git
> Branch: devicetree/test
> The above branch is rebased with v3.1-rc2 mainline.
> +
> pdev decoupling patches from kevin hilman
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg53534.html
>
> The patch series is also available at:
> https://gitorious.org/devicetree/dt_omap/commits/devicetree/dt_rfcv2

Please provide the git URL + branch and not the link to the web page.
It will allow to copy paste directly the line and do a git fetch <repo> 
<branch>.

> Testing:
> ========
> Build : dt and not dt build for omap2plus_defconfig
> Boot: OMAP3530 Beagle Board and OMAP4430 Panda board
>
> Limitation:
> ===========
> The current implementation of omap-device build through
> device tree supports only single instance of hwmod and
> multiple instances are not supported.
>
> G, Manjunath Kondaiah (13):
>     OMAP: omap_device: Add device tree node pointer
>     dt: Add pd_size to AUXDATA structure
>     dt: omap3: add soc file for handling i2c controllers
>     dt: omap3: beagle board: set clock freq for i2c devices
>     dt: omap3: add generic board file for dt support
>     dt: omap3: add omap-device compatible property
>     dt: omap: create platform bus for omap devices
>     dt: omap: i2c: add dt support for i2c1 controller
>     dt: omap4: add soc file for handling i2c controllers
>     dt: omap4: panda board: set clock freq for i2c devices
>     dt: omap4: add generic board file for dt support
>     dt: omap4: enable dt support for i2c1 controller
>     dt: omap: i2c: dt usage model documentation

You should adapt the prefix depending of the subsystem your patch is 
changing. Most patches are changing files inside mach-omap2 and thus in 
that case should not be prefix with dt: but rather OMAP2+:
The dts files modification should then be prefixed with arm/dt or arm/dts.


Regards,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1
Date: Tue, 23 Aug 2011 14:38:21 +0200	[thread overview]
Message-ID: <4E539F3D.4010602@ti.com> (raw)
In-Reply-To: <4E537ECB.1060704@ti.com>

Hi Manju,

Few "minor" comments about your subjects in this series.

> Patch series reworked from:
> http://permalink.gmane.org/gmane.linux.ports.arm.omap/61674
> Also added support for i2c1 controller on omap4 based panda
> board.
>
> Baseline:
> =========
> git://git.secretlab.ca/git/linux-2.6.git
> Branch: devicetree/test
> The above branch is rebased with v3.1-rc2 mainline.
> +
> pdev decoupling patches from kevin hilman
> http://www.mail-archive.com/linux-omap at vger.kernel.org/msg53534.html
>
> The patch series is also available at:
> https://gitorious.org/devicetree/dt_omap/commits/devicetree/dt_rfcv2

Please provide the git URL + branch and not the link to the web page.
It will allow to copy paste directly the line and do a git fetch <repo> 
<branch>.

> Testing:
> ========
> Build : dt and not dt build for omap2plus_defconfig
> Boot: OMAP3530 Beagle Board and OMAP4430 Panda board
>
> Limitation:
> ===========
> The current implementation of omap-device build through
> device tree supports only single instance of hwmod and
> multiple instances are not supported.
>
> G, Manjunath Kondaiah (13):
>     OMAP: omap_device: Add device tree node pointer
>     dt: Add pd_size to AUXDATA structure
>     dt: omap3: add soc file for handling i2c controllers
>     dt: omap3: beagle board: set clock freq for i2c devices
>     dt: omap3: add generic board file for dt support
>     dt: omap3: add omap-device compatible property
>     dt: omap: create platform bus for omap devices
>     dt: omap: i2c: add dt support for i2c1 controller
>     dt: omap4: add soc file for handling i2c controllers
>     dt: omap4: panda board: set clock freq for i2c devices
>     dt: omap4: add generic board file for dt support
>     dt: omap4: enable dt support for i2c1 controller
>     dt: omap: i2c: dt usage model documentation

You should adapt the prefix depending of the subsystem your patch is 
changing. Most patches are changing files inside mach-omap2 and thus in 
that case should not be prefix with dt: but rather OMAP2+:
The dts files modification should then be prefixed with arm/dt or arm/dts.


Regards,
Benoit

  parent reply	other threads:[~2011-08-23 12:38 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-23  5:03 [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1 G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 01/13] OMAP: omap_device: Add device tree node pointer G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 02/13] dt: Add pd_size to AUXDATA structure G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 03/13] dt: omap3: add soc file for handling i2c controllers G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 04/13] dt: omap3: beagle board: set clock freq for i2c devices G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 05/13] dt: omap3: add generic board file for dt support G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 06/13] dt: omap3: add omap-device compatible property G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 07/13] dt: omap: create platform bus for omap devices G, Manjunath Kondaiah
2011-08-23  9:07   ` Jamie Iles
2011-08-23  9:07     ` Jamie Iles
2011-08-23 15:19     ` G, Manjunath Kondaiah
2011-08-23 15:19       ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 08/13] dt: omap: i2c: add dt support for i2c1 controller G, Manjunath Kondaiah
2011-08-23 15:46   ` G, Manjunath Kondaiah
2011-08-23 15:46     ` G, Manjunath Kondaiah
2011-09-01 17:34     ` Cousson, Benoit
2011-09-01 17:34       ` Cousson, Benoit
2011-09-02  3:22       ` G, Manjunath Kondaiah
2011-09-02  3:22         ` G, Manjunath Kondaiah
     [not found]   ` <4E537F53.4030405@ti.com>
2011-08-23 19:15     ` Fwd: " Cousson, Benoit
2011-08-23 19:15       ` Cousson, Benoit
2011-08-23  5:03 ` [RFC/PATCH v2 09/13] dt: omap4: add soc file for handling i2c controllers G, Manjunath Kondaiah
2011-08-23  8:23   ` Rajendra Nayak
2011-08-23  8:23     ` Rajendra Nayak
2011-08-23 15:11     ` G, Manjunath Kondaiah
2011-08-23 15:11       ` G, Manjunath Kondaiah
     [not found]   ` <4E537FA7.3050609@ti.com>
2011-08-23 13:48     ` Fwd: " Cousson, Benoit
2011-08-23 13:48       ` Cousson, Benoit
2011-08-23 15:18       ` G, Manjunath Kondaiah
2011-08-23 15:18         ` G, Manjunath Kondaiah
2011-08-23 19:45         ` Cousson, Benoit
2011-08-23 19:45           ` Cousson, Benoit
2011-08-23  5:03 ` [RFC/PATCH v2 10/13] dt: omap4: panda board: set clock freq for i2c devices G, Manjunath Kondaiah
     [not found]   ` <4E537F6B.4060608@ti.com>
2011-08-23 19:03     ` Cousson, Benoit
2011-08-23 19:03       ` Cousson, Benoit
2011-08-23 19:15       ` G, Manjunath Kondaiah
2011-08-23 19:15         ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 11/13] dt: omap4: add generic board file for dt support G, Manjunath Kondaiah
     [not found]   ` <4E537F80.1060001@ti.com>
     [not found]     ` <4E537F80.1060001-l0cyMroinI0@public.gmane.org>
2011-08-23 13:05       ` Fwd: " Cousson, Benoit
2011-08-23 13:05         ` Cousson, Benoit
2011-08-23 15:30         ` G, Manjunath Kondaiah
2011-08-23 15:30           ` G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 12/13] dt: omap4: enable dt support for i2c1 controller G, Manjunath Kondaiah
2011-08-23  5:03 ` [RFC/PATCH v2 13/13] dt: omap: i2c: dt usage model documentation G, Manjunath Kondaiah
     [not found] ` <4E537ECB.1060704@ti.com>
2011-08-23 12:38   ` Cousson, Benoit [this message]
2011-08-23 12:38     ` [RFC/PATCH v2 00/13] dt: omap: dt binding with omap_device and support for i2c1 Cousson, Benoit
2011-08-23 15:41 ` G, Manjunath Kondaiah
2011-08-23 15:41   ` G, Manjunath Kondaiah
2011-08-24  9:41   ` Cousson, Benoit
2011-08-24  9:41     ` Cousson, Benoit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E539F3D.4010602@ti.com \
    --to=b-cousson@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=manjugk@ti.com \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.