From: Liam Girdwood <lrg@ti.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ASoC: Tegra: wm8903 machine driver: Drop Ventana support
Date: Tue, 23 Aug 2011 20:26:59 +0100 [thread overview]
Message-ID: <4E53FF03.1030100@ti.com> (raw)
In-Reply-To: <1314119788-23000-1-git-send-email-swarren@nvidia.com>
On 23/08/11 18:16, Stephen Warren wrote:
> Board file support for Ventana is not yet mainlined, and probably won't
> ever be given the move to Device-Tree. Consequently, the Ventana entry
> is being removed from arch/arm/tools/mach-types in the next merge window,
> since it was registered over a year ago.
>
> This will also remove function machine_is_ventana(), which is used by
> the ASoC Tegra WM8903 machine driver. This will cause compilation
> failures. Drop Ventana support to resolve this.
>
> Hopefully, in the not-too-distant future, tegra_wm8903.c will be able to
> configure itself from Device-Tree, and hence we'll be able to re-instate
> Ventana support just by creating a .dts file for the board.
>
> Also note that Aebl support is in a similar boat. However, that board
> isn't scheduled for deprecation for at least another 5 months, and
> perhaps we will have completely removed non-Device-Tree support from
> tegra_wm8903.c by then and/or adjusted mach-types policy.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Liam Girdwood <lrg@ti.com>
> ---
> sound/soc/tegra/tegra_wm8903.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c
> index 661373c..be27f1d 100644
> --- a/sound/soc/tegra/tegra_wm8903.c
> +++ b/sound/soc/tegra/tegra_wm8903.c
> @@ -319,7 +319,7 @@ static int tegra_wm8903_init(struct snd_soc_pcm_runtime *rtd)
> snd_soc_dapm_force_enable_pin(dapm, "Mic Bias");
>
> /* FIXME: Calculate automatically based on DAPM routes? */
> - if (!machine_is_harmony() && !machine_is_ventana())
> + if (!machine_is_harmony())
> snd_soc_dapm_nc_pin(dapm, "IN1L");
> if (!machine_is_seaboard() && !machine_is_aebl())
> snd_soc_dapm_nc_pin(dapm, "IN1R");
> @@ -395,7 +395,7 @@ static __devinit int tegra_wm8903_driver_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, card);
> snd_soc_card_set_drvdata(card, machine);
>
> - if (machine_is_harmony() || machine_is_ventana()) {
> + if (machine_is_harmony()) {
> card->dapm_routes = harmony_audio_map;
> card->num_dapm_routes = ARRAY_SIZE(harmony_audio_map);
> } else if (machine_is_seaboard()) {
WARNING: multiple messages have this Message-ID (diff)
From: lrg@ti.com (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: Tegra: wm8903 machine driver: Drop Ventana support
Date: Tue, 23 Aug 2011 20:26:59 +0100 [thread overview]
Message-ID: <4E53FF03.1030100@ti.com> (raw)
In-Reply-To: <1314119788-23000-1-git-send-email-swarren@nvidia.com>
On 23/08/11 18:16, Stephen Warren wrote:
> Board file support for Ventana is not yet mainlined, and probably won't
> ever be given the move to Device-Tree. Consequently, the Ventana entry
> is being removed from arch/arm/tools/mach-types in the next merge window,
> since it was registered over a year ago.
>
> This will also remove function machine_is_ventana(), which is used by
> the ASoC Tegra WM8903 machine driver. This will cause compilation
> failures. Drop Ventana support to resolve this.
>
> Hopefully, in the not-too-distant future, tegra_wm8903.c will be able to
> configure itself from Device-Tree, and hence we'll be able to re-instate
> Ventana support just by creating a .dts file for the board.
>
> Also note that Aebl support is in a similar boat. However, that board
> isn't scheduled for deprecation for at least another 5 months, and
> perhaps we will have completely removed non-Device-Tree support from
> tegra_wm8903.c by then and/or adjusted mach-types policy.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Liam Girdwood <lrg@ti.com>
> ---
> sound/soc/tegra/tegra_wm8903.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_wm8903.c b/sound/soc/tegra/tegra_wm8903.c
> index 661373c..be27f1d 100644
> --- a/sound/soc/tegra/tegra_wm8903.c
> +++ b/sound/soc/tegra/tegra_wm8903.c
> @@ -319,7 +319,7 @@ static int tegra_wm8903_init(struct snd_soc_pcm_runtime *rtd)
> snd_soc_dapm_force_enable_pin(dapm, "Mic Bias");
>
> /* FIXME: Calculate automatically based on DAPM routes? */
> - if (!machine_is_harmony() && !machine_is_ventana())
> + if (!machine_is_harmony())
> snd_soc_dapm_nc_pin(dapm, "IN1L");
> if (!machine_is_seaboard() && !machine_is_aebl())
> snd_soc_dapm_nc_pin(dapm, "IN1R");
> @@ -395,7 +395,7 @@ static __devinit int tegra_wm8903_driver_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, card);
> snd_soc_card_set_drvdata(card, machine);
>
> - if (machine_is_harmony() || machine_is_ventana()) {
> + if (machine_is_harmony()) {
> card->dapm_routes = harmony_audio_map;
> card->num_dapm_routes = ARRAY_SIZE(harmony_audio_map);
> } else if (machine_is_seaboard()) {
next prev parent reply other threads:[~2011-08-23 19:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 17:16 [PATCH] ASoC: Tegra: wm8903 machine driver: Drop Ventana support Stephen Warren
2011-08-23 17:16 ` Stephen Warren
2011-08-23 19:26 ` Liam Girdwood [this message]
2011-08-23 19:26 ` Liam Girdwood
[not found] ` <1314119788-23000-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2011-08-24 9:33 ` Mark Brown
2011-08-24 9:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E53FF03.1030100@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.