From: Avi Kivity <avi@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors
Date: Wed, 24 Aug 2011 12:22:10 +0300 [thread overview]
Message-ID: <4E54C2C2.3030603@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1108221603050.24813@bbs.intern>
On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote:
> Hello Avi,
>
> Thnx, fixed: OK, maybe some credits :-)
>
> Acked-by: Gerhard Wiesinger <lists@wiesinger.com>
>
> This pattern is still present at (maybe some further problems!!!) and
> I guess it has to be fixed, too:
>
> grep -ir 'ops, s, "' .
> ./hw/rtl8139.c: memory_region_init_io(&s->bar_io, &rtl8139_io_ops,
> s, "rtl8139", 0x100);
> ./hw/rtl8139.c: memory_region_init_io(&s->bar_mem,
> &rtl8139_mmio_ops, s, "rtl8139", 0x100);
Usually, when you have
memory_region_init_io(&s->something, ..., s, ...)
it means everything is fine. Lance/pcnet is special in this regard.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors
Date: Wed, 24 Aug 2011 12:22:10 +0300 [thread overview]
Message-ID: <4E54C2C2.3030603@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1108221603050.24813@bbs.intern>
On 08/22/2011 05:16 PM, Gerhard Wiesinger wrote:
> Hello Avi,
>
> Thnx, fixed: OK, maybe some credits :-)
>
> Acked-by: Gerhard Wiesinger <lists@wiesinger.com>
>
> This pattern is still present at (maybe some further problems!!!) and
> I guess it has to be fixed, too:
>
> grep -ir 'ops, s, "' .
> ./hw/rtl8139.c: memory_region_init_io(&s->bar_io, &rtl8139_io_ops,
> s, "rtl8139", 0x100);
> ./hw/rtl8139.c: memory_region_init_io(&s->bar_mem,
> &rtl8139_mmio_ops, s, "rtl8139", 0x100);
Usually, when you have
memory_region_init_io(&s->something, ..., s, ...)
it means everything is fine. Lance/pcnet is special in this regard.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-08-24 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 13:58 [PATCH] pcnet-pci: fix wrong opaque given to I/O accessors Avi Kivity
2011-08-22 13:58 ` [Qemu-devel] " Avi Kivity
2011-08-22 14:16 ` Gerhard Wiesinger
2011-08-22 14:16 ` [Qemu-devel] " Gerhard Wiesinger
2011-08-24 9:22 ` Avi Kivity [this message]
2011-08-24 9:22 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E54C2C2.3030603@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.