All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/1] script/runqemu: change boot command line for qemuppc
@ 2011-08-24  8:48 Liming Wang
  2011-08-24  8:48 ` [PATCH 1/1] " Liming Wang
  2011-08-24 18:33 ` [PATCH 0/1] " Bruce Ashfield
  0 siblings, 2 replies; 4+ messages in thread
From: Liming Wang @ 2011-08-24  8:48 UTC (permalink / raw)
  To: Bruce.Ashfield; +Cc: yocto, dvhart

This patch is just a workaround to speed up boot time of qemuppc, because
qemuppc has no framebuffer support, no need to start X server for qemuppc.

Richard suggested to fix the X scripts so that if an fbdev X server is in use and
the framebuffer device node does not exist, it just exits cleanly with a
suitable message and doesn't timeout on boot.

But I think it needs more time to implement and test.
> X scripts serve for all the boards. And we also can't assume all the
> boards use the same
> framebuffer device. So how to detect whether the framebuffer device
> exists is board dependent.
> Maybe we can see whether the device /dev/fb0 exists(it could be created
> manually, so we should try to open it to verify)
> or the file /proc/fb exists to confirm the framebuffer device. Anyway,
> any modification should be
> tested on all boards to see whether it works. I prefer to mark it as
> todo task in 1.1

Bruce also suggests:
> I know I'm ok with this strategy, since time is short in the
> 1.1 cycle. We can always open a bugzilla item to track this,
> just to be sure it isn't forgotten. Preferably we'll get a
> qemuppc with a framebuffer in 1.x timeframe and we won't need
> this at all. Coming up with something generic and the amount
> of testing required doesn't fit the timeframe that we currently
> have for 1.1.


Liming Wang (1):
      script/runqemu: change boot command line for qemuppc

 scripts/runqemu-internal |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)



^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] script/runqemu: change boot command line for qemuppc
  2011-08-24  8:48 [PATCH 0/1] script/runqemu: change boot command line for qemuppc Liming Wang
@ 2011-08-24  8:48 ` Liming Wang
  2011-08-24 18:33 ` [PATCH 0/1] " Bruce Ashfield
  1 sibling, 0 replies; 4+ messages in thread
From: Liming Wang @ 2011-08-24  8:48 UTC (permalink / raw)
  To: Bruce.Ashfield; +Cc: yocto, dvhart

Because qemuppc has no graphic emulation, remove console=tty0
and make it run into 3 run level. This can reduce boot time
for qemuppc booting.

Signed-off-by: Liming Wang <liming.wang@windriver.com>
---
 scripts/runqemu-internal |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
index c15632d..883fa5b 100755
--- a/scripts/runqemu-internal
+++ b/scripts/runqemu-internal
@@ -384,7 +384,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
     BIOS=powerpc_rom.bin
     QEMU_UI_OPTIONS="$QEMU_UI_OPTIONS -nographic"
     if [ "$FSTYPE" = "ext3" -o "$FSTYPE" = "btrfs" ]; then
-        KERNCMDLINE="root=/dev/hda rw console=ttyS0 console=tty0 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
+        KERNCMDLINE="root=/dev/hda rw console=ttyS0 3 $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -hda $ROOTFS -no-reboot $QEMU_UI_OPTIONS"
     fi
     if [ "$FSTYPE" = "nfs" ]; then
@@ -393,7 +393,7 @@ if [ "$MACHINE" = "qemuppc" ]; then
             cleanup
             return
         fi
-        KERNCMDLINE="root=/dev/nfs console=ttyS0 console=tty0 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
+        KERNCMDLINE="root=/dev/nfs console=ttyS0 3 nfsroot=$NFS_SERVER:$NFS_DIR,$UNFS_OPTS rw $KERNEL_NETWORK_CMD mem=$QEMU_MEMORY"
         QEMUOPTIONS="$QEMU_NETWORK_CMD -cpu $CPU_SUBTYPE -M $MACHINE_SUBTYPE -bios $BIOS -no-reboot $QEMU_UI_OPTIONS"
     fi
 fi
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1] script/runqemu: change boot command line for qemuppc
  2011-08-24  8:48 [PATCH 0/1] script/runqemu: change boot command line for qemuppc Liming Wang
  2011-08-24  8:48 ` [PATCH 1/1] " Liming Wang
@ 2011-08-24 18:33 ` Bruce Ashfield
  2011-08-30 21:26   ` Richard Purdie
  1 sibling, 1 reply; 4+ messages in thread
From: Bruce Ashfield @ 2011-08-24 18:33 UTC (permalink / raw)
  To: Liming Wang; +Cc: yocto, dvhart, Saul Wold

On 11-08-24 04:48 AM, Liming Wang wrote:
> This patch is just a workaround to speed up boot time of qemuppc, because
> qemuppc has no framebuffer support, no need to start X server for qemuppc.
>
> Richard suggested to fix the X scripts so that if an fbdev X server is in use and
> the framebuffer device node does not exist, it just exits cleanly with a
> suitable message and doesn't timeout on boot.
>
> But I think it needs more time to implement and test.
>> X scripts serve for all the boards. And we also can't assume all the
>> boards use the same
>> framebuffer device. So how to detect whether the framebuffer device
>> exists is board dependent.
>> Maybe we can see whether the device /dev/fb0 exists(it could be created
>> manually, so we should try to open it to verify)
>> or the file /proc/fb exists to confirm the framebuffer device. Anyway,
>> any modification should be
>> tested on all boards to see whether it works. I prefer to mark it as
>> todo task in 1.1

We need to cc Richard/Saul on this, so they can re-consider
and merge this as appropriate. But for me, I'm acking this
change.

Bruce

>
> Bruce also suggests:
>> I know I'm ok with this strategy, since time is short in the
>> 1.1 cycle. We can always open a bugzilla item to track this,
>> just to be sure it isn't forgotten. Preferably we'll get a
>> qemuppc with a framebuffer in 1.x timeframe and we won't need
>> this at all. Coming up with something generic and the amount
>> of testing required doesn't fit the timeframe that we currently
>> have for 1.1.
>
>
> Liming Wang (1):
>        script/runqemu: change boot command line for qemuppc
>
>   scripts/runqemu-internal |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/1] script/runqemu: change boot command line for qemuppc
  2011-08-24 18:33 ` [PATCH 0/1] " Bruce Ashfield
@ 2011-08-30 21:26   ` Richard Purdie
  0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2011-08-30 21:26 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: yocto, dvhart, Saul Wold

On Wed, 2011-08-24 at 14:33 -0400, Bruce Ashfield wrote:
> On 11-08-24 04:48 AM, Liming Wang wrote:
> > This patch is just a workaround to speed up boot time of qemuppc, because
> > qemuppc has no framebuffer support, no need to start X server for qemuppc.
> >
> > Richard suggested to fix the X scripts so that if an fbdev X server is in use and
> > the framebuffer device node does not exist, it just exits cleanly with a
> > suitable message and doesn't timeout on boot.
> >
> > But I think it needs more time to implement and test.
> >> X scripts serve for all the boards. And we also can't assume all the
> >> boards use the same
> >> framebuffer device. So how to detect whether the framebuffer device
> >> exists is board dependent.
> >> Maybe we can see whether the device /dev/fb0 exists(it could be created
> >> manually, so we should try to open it to verify)
> >> or the file /proc/fb exists to confirm the framebuffer device. Anyway,
> >> any modification should be
> >> tested on all boards to see whether it works. I prefer to mark it as
> >> todo task in 1.1
> 
> We need to cc Richard/Saul on this, so they can re-consider
> and merge this as appropriate. But for me, I'm acking this
> change.

I've reluctantly merged this but I consider this a bit of a cop-out :(

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-08-30 21:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-24  8:48 [PATCH 0/1] script/runqemu: change boot command line for qemuppc Liming Wang
2011-08-24  8:48 ` [PATCH 1/1] " Liming Wang
2011-08-24 18:33 ` [PATCH 0/1] " Bruce Ashfield
2011-08-30 21:26   ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.