From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Avi Kivity <avi@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] vga: Silence bogus gcc warning about uninitialized variables
Date: Thu, 25 Aug 2011 11:10:13 +0200 [thread overview]
Message-ID: <4E561175.8080800@siemens.com> (raw)
In-Reply-To: <4E556681.2060207@codemonkey.ws>
Some gcc versions do not properly detect that all possible cases are
covered and base and size are always initialized. Please gcc by defining
a pseudo default case.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/vga.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index 851fd68..125fb29 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -176,6 +176,7 @@ static void vga_update_memory_access(VGACommonState *s)
size = 0x8000;
break;
case 3:
+ default:
base = 0xb8000;
size = 0x8000;
break;
--
1.7.3.4
next prev parent reply other threads:[~2011-08-25 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 12:07 [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access() Avi Kivity
2011-08-24 12:46 ` Jan Kiszka
2011-08-24 12:58 ` Avi Kivity
2011-08-24 13:00 ` Jan Kiszka
2011-08-24 13:07 ` Avi Kivity
2011-08-24 21:00 ` Anthony Liguori
2011-08-25 9:10 ` Jan Kiszka [this message]
2011-08-25 22:41 ` [Qemu-devel] [PATCH] vga: Silence bogus gcc warning about uninitialized variables Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E561175.8080800@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.